Completed
Pull Request — master (#594)
by Mateusz
03:09
created
code/model/StateMachineFactory.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,17 +58,17 @@
 block discarded – undo
58 58
 
59 59
 	protected function addHandlers($machine) {
60 60
 		$class = get_class($machine->getObject());
61
-		if (empty($this->config()->handlers[$class])) return;
61
+		if(empty($this->config()->handlers[$class])) return;
62 62
 
63 63
 		$transitions = $this->config()->handlers[$class];
64
-		foreach ($transitions as $transName => $handlers) {
65
-			if (!is_array($handlers)) {
64
+		foreach($transitions as $transName => $handlers) {
65
+			if(!is_array($handlers)) {
66 66
 				throw new Exception(sprintf('Transition %s must be configured as an assoc array.', $transName));
67 67
 			}
68 68
 
69
-			foreach ($handlers as $handlerClass => $handlerMethod) {
69
+			foreach($handlers as $handlerClass => $handlerMethod) {
70 70
 				$handlerObj = Injector::inst()->get($handlerClass);
71
-				if (!is_callable([$handlerObj, $handlerMethod])) {
71
+				if(!is_callable([$handlerObj, $handlerMethod])) {
72 72
 					throw new Exception(sprintf('Handler %s is not callable on %s.', $handlerMethod, $handlerClass));
73 73
 				}
74 74
 				$machine->getDispatcher()->addListener(
Please login to merge, or discard this patch.
code/control/DNDeploymentHandlers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 	protected function sendEmailToApprover(DNDeployment $deployment) {
13 13
 		$deployer = $deployment->Deployer();
14 14
 		$approver = $deployment->Approver();
15
-		if (!$approver || !$approver->exists()) {
15
+		if(!$approver || !$approver->exists()) {
16 16
 			return false;
17 17
 		}
18 18
 
Please login to merge, or discard this patch.
code/tasks/MigrateDeploymentStatusTask.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -4,28 +4,28 @@
 block discarded – undo
4 4
 
5 5
 	public function run($request) {
6 6
 		$log = function($message) {
7
-			$message = sprintf('[%s] ', date('Y-m-d H:i:s')) . $message;
8
-			echo $message . PHP_EOL;
7
+			$message = sprintf('[%s] ', date('Y-m-d H:i:s')).$message;
8
+			echo $message.PHP_EOL;
9 9
 		};
10 10
 
11
-		if (!Director::is_cli()) {
11
+		if(!Director::is_cli()) {
12 12
 			$log('This command can only run via CLI');
13 13
 			return;
14 14
 		}
15 15
 
16 16
 		$columns = DB::query('SHOW COLUMNS FROM "DNDeployment"')->column();
17
-		if (!in_array('Status', $columns)) {
17
+		if(!in_array('Status', $columns)) {
18 18
 			$log('Migration has already been run');
19 19
 			return;
20 20
 		}
21 21
 
22
-		foreach (DB::query('SELECT "ID", "Status" FROM "DNDeployment"') as $record) {
22
+		foreach(DB::query('SELECT "ID", "Status" FROM "DNDeployment"') as $record) {
23 23
 			// This record looks to be already migrated
24
-			if (empty($record['Status'])) {
24
+			if(empty($record['Status'])) {
25 25
 				continue;
26 26
 			}
27 27
 
28
-			switch ($record['Status']) {
28
+			switch($record['Status']) {
29 29
 				case 'Queued':
30 30
 					DB::query(sprintf('UPDATE "DNDeployment" SET "State" = \'Queued\' WHERE "ID" = %s', $record['ID']));
31 31
 					break;
Please login to merge, or discard this patch.
code/model/jobs/DNDeployment.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	}
101 101
 
102 102
 	public function LogLink() {
103
-		return $this->Link() . '/log';
103
+		return $this->Link().'/log';
104 104
 	}
105 105
 
106 106
 	public function canView($member = null) {
@@ -219,12 +219,12 @@  discard block
 block discarded – undo
219 219
 	 */
220 220
 	public function getFullDeployMessages() {
221 221
 		$strategy = $this->getDeploymentStrategy();
222
-		if ($strategy->getActionCode()!=='full') return null;
222
+		if($strategy->getActionCode() !== 'full') return null;
223 223
 
224 224
 		$changes = $strategy->getChangesModificationNeeded();
225 225
 		$messages = [];
226
-		foreach ($changes as $change => $details) {
227
-			if ($change==='Code version') continue;
226
+		foreach($changes as $change => $details) {
227
+			if($change === 'Code version') continue;
228 228
 
229 229
 			$messages[] = [
230 230
 				'Flag' => sprintf(
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 			];
236 236
 		}
237 237
 
238
-		if (empty($messages)) {
238
+		if(empty($messages)) {
239 239
 			$messages[] = [
240 240
 				'Flag' => '',
241 241
 				'Text' => '<i>Environment changes have been made.</i>'
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 
285 285
 			// if there is a compare URL, and a description or a change (something actually changed)
286 286
 			// then show the URL. Otherwise don't show anything, as there is no comparison to be made.
287
-			if ($changed || $description) {
287
+			if($changed || $description) {
288 288
 				$compareUrl = isset($change['compareUrl']) ? $change['compareUrl'] : '';
289 289
 			}
290 290
 
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 
349 349
 	public function getSigFile() {
350 350
 		$dir = DNData::inst()->getSignalDir();
351
-		if (!is_dir($dir)) {
351
+		if(!is_dir($dir)) {
352 352
 			`mkdir $dir`;
353 353
 		}
354 354
 		return sprintf(
Please login to merge, or discard this patch.
code/backends/CapistranoDeploymentBackend.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
 			try {
86 86
 				$args['build_filename'] = $this->packageGenerator->getPackageFilename($project->Name, $sha, $repository, $log);
87
-			} catch (Exception $e) {
87
+			} catch(Exception $e) {
88 88
 				$log->write($e->getMessage());
89 89
 				throw $e;
90 90
 			}
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 			$this->enableMaintenance($environment, $log, $project);
119 119
 		}
120 120
 
121
-		if ($url) {
121
+		if($url) {
122 122
 			$runner = $this->getJob()->runOp(
123 123
 				'Smoketest',
124 124
 				new \SilverStripe\Platform\Core\Rainforest\Anthill\Operations\Params\Smoketest([
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 				]),
127 127
 				new DeploynautPsrOutputAdapter($log)
128 128
 			);
129
-			if ($runner->isSuccessful()) {
129
+			if($runner->isSuccessful()) {
130 130
 				$log->write(sprintf('Smoketest to "%s" succeeded.', $url));
131 131
 
132 132
 			} else {
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 		} else {
206 206
 			$environment = $dataTransfer->Environment();
207 207
 			$project = $environment->Project();
208
-			$workingDir = TEMP_FOLDER . DIRECTORY_SEPARATOR . 'deploynaut-transfer-' . $dataTransfer->ID;
208
+			$workingDir = TEMP_FOLDER.DIRECTORY_SEPARATOR.'deploynaut-transfer-'.$dataTransfer->ID;
209 209
 			$archive = $dataTransfer->DataArchive();
210 210
 
211 211
 			// extract the sspak contents, we'll need these so capistrano can restore that content
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 		if(!$args) {
252 252
 			$args = array();
253 253
 		}
254
-		$args['history_path'] = realpath(DEPLOYNAUT_LOG_PATH . '/');
254
+		$args['history_path'] = realpath(DEPLOYNAUT_LOG_PATH.'/');
255 255
 		$args['environment_id'] = $environment->ID;
256 256
 
257 257
 		// Inject env string directly into the command.
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 
267 267
 		$data = DNData::inst();
268 268
 		// Generate a capfile from a template
269
-		$capTemplate = file_get_contents(BASE_PATH . '/deploynaut/Capfile.template');
269
+		$capTemplate = file_get_contents(BASE_PATH.'/deploynaut/Capfile.template');
270 270
 		$cap = str_replace(
271 271
 			array('<config root>', '<ssh key>', '<base path>'),
272 272
 			array($data->getEnvironmentDir(), DEPLOYNAUT_SSH_KEY, BASE_PATH),
@@ -276,13 +276,13 @@  discard block
 block discarded – undo
276 276
 		if(defined('DEPLOYNAUT_CAPFILE')) {
277 277
 			$capFile = DEPLOYNAUT_CAPFILE;
278 278
 		} else {
279
-			$capFile = ASSETS_PATH . '/Capfile';
279
+			$capFile = ASSETS_PATH.'/Capfile';
280 280
 		}
281 281
 		file_put_contents($capFile, $cap);
282 282
 
283
-		$command = "{$envString}cap -f " . escapeshellarg($capFile) . " -vv $name $action ROLES=$roles";
283
+		$command = "{$envString}cap -f ".escapeshellarg($capFile)." -vv $name $action ROLES=$roles";
284 284
 		foreach($args as $argName => $argVal) {
285
-			$command .= ' -s ' . escapeshellarg($argName) . '=' . escapeshellarg($argVal);
285
+			$command .= ' -s '.escapeshellarg($argName).'='.escapeshellarg($argVal);
286 286
 		}
287 287
 
288 288
 		$log->write(sprintf('Running command: %s', $command));
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 		$filepathBase = $dataArchive->generateFilepath($dataTransfer);
317 317
 		mkdir($filepathBase, 0700, true);
318 318
 
319
-		$databasePath = $filepathBase . DIRECTORY_SEPARATOR . 'database.sql';
319
+		$databasePath = $filepathBase.DIRECTORY_SEPARATOR.'database.sql';
320 320
 
321 321
 		// Backup database
322 322
 		if(in_array($dataTransfer->Mode, array('all', 'db'))) {
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
 		$log->write('Creating sspak...');
355 355
 
356 356
 		$sspakFilename = sprintf('%s.sspak', $dataArchive->generateFilename($dataTransfer));
357
-		$sspakFilepath = $filepathBase . DIRECTORY_SEPARATOR . $sspakFilename;
357
+		$sspakFilepath = $filepathBase.DIRECTORY_SEPARATOR.$sspakFilename;
358 358
 
359 359
 		try {
360 360
 			$dataArchive->attachFile($sspakFilepath, $dataTransfer);
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
 		// Restore database into target environment
422 422
 		if(in_array($dataTransfer->Mode, array('all', 'db'))) {
423 423
 			$log->write(sprintf('Restore of database to "%s" started', $name));
424
-			$args = array('data_path' => $workingDir . DIRECTORY_SEPARATOR . 'database.sql');
424
+			$args = array('data_path' => $workingDir.DIRECTORY_SEPARATOR.'database.sql');
425 425
 			$command = $this->getCommand('data:pushdb', 'db', $environment, $args, $log);
426 426
 			$command->run(function($type, $buffer) use($log) {
427 427
 				$log->write($buffer);
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 		// Restore assets into target environment
439 439
 		if(in_array($dataTransfer->Mode, array('all', 'assets'))) {
440 440
 			$log->write(sprintf('Restore of assets to "%s" started', $name));
441
-			$args = array('data_path' => $workingDir . DIRECTORY_SEPARATOR . 'assets');
441
+			$args = array('data_path' => $workingDir.DIRECTORY_SEPARATOR.'assets');
442 442
 			$command = $this->getCommand('data:pushassets', 'web', $environment, $args, $log);
443 443
 			$command->run(function($type, $buffer) use($log) {
444 444
 				$log->write($buffer);
Please login to merge, or discard this patch.
code/jobs/AnthillJob.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 		$params = $this->args['params'];
33 33
 		$paramClass = sprintf('SilverStripe\Platform\Core\Rainforest\Anthill\Operations\Params\%s', $opName);
34 34
 		$runner = $this->runOp($opName, new $paramClass($params));
35
-		if (!$runner->isSuccessful()) {
35
+		if(!$runner->isSuccessful()) {
36 36
 			throw $runner->getFailureException();
37 37
 		}
38 38
 	}
Please login to merge, or discard this patch.
code/jobs/DeploynautJob.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -19,9 +19,9 @@  discard block
 block discarded – undo
19 19
 	 */
20 20
 	public function alarmHandler() {
21 21
 		$sigFile = $this->args['sigFile'];
22
-		if (file_exists($sigFile) && is_readable($sigFile) && is_writable($sigFile)) {
22
+		if(file_exists($sigFile) && is_readable($sigFile) && is_writable($sigFile)) {
23 23
 			$signal = (int)file_get_contents($sigFile);
24
-			if (is_int($signal) && in_array((int)$signal, [
24
+			if(is_int($signal) && in_array((int)$signal, [
25 25
 				// The following signals are trapped by both Resque and Rainforest.
26 26
 				SIGTERM,
27 27
 				SIGINT,
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 				SIGCONT
33 33
 			])) {
34 34
 				echo sprintf(
35
-					'[-] Signal "%s" received, delivering to own process group, PID "%s".' . PHP_EOL,
35
+					'[-] Signal "%s" received, delivering to own process group, PID "%s".'.PHP_EOL,
36 36
 					$signal,
37 37
 					getmypid()
38 38
 				);
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 
43 43
 				// Dispatch to own process group.
44 44
 				$pgid = posix_getpgid(getmypid());
45
-				if ($pgid<=0) {
45
+				if($pgid <= 0) {
46 46
 					echo sprintf(
47
-						'[-] Unable to send signal to invalid PGID "%s".' . PHP_EOL,
47
+						'[-] Unable to send signal to invalid PGID "%s".'.PHP_EOL,
48 48
 						$pgid
49 49
 					);
50 50
 				} else {
@@ -63,8 +63,8 @@  discard block
 block discarded – undo
63 63
 		posix_setsid();
64 64
 
65 65
 		if(function_exists('pcntl_alarm') && function_exists('pcntl_signal')) {
66
-			if (!empty($this->args['sigFile'])) {
67
-				echo sprintf('[-] Signal file requested, polling "%s".' . PHP_EOL, $this->args['sigFile']);
66
+			if(!empty($this->args['sigFile'])) {
67
+				echo sprintf('[-] Signal file requested, polling "%s".'.PHP_EOL, $this->args['sigFile']);
68 68
 				declare(ticks = 1);
69 69
 				pcntl_signal(SIGALRM, [$this, 'alarmHandler']);
70 70
 				pcntl_alarm(1);
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 	}
83 83
 
84 84
 	public function runOp($opName, Anthill\Interfaces\Params $params, \Psr\Log\LoggerInterface $logger = null) {
85
-		if (!$logger) {
85
+		if(!$logger) {
86 86
 			$logger = new \Psr\Log\NullLogger;
87 87
 		}
88 88
 		$container = Anthill\Anthill::bootstrap(
Please login to merge, or discard this patch.