SmokeTestPipelineStepTest::testSmokeTestPass() - Code Metrics - Inspection of "Added standard Scrutinizer config" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#513)

by Helpful

created 2016-02-21 21:40 UTC

SmokeTestPipelineStepTest::testSmokeTestPass() A

↳ Parent: SmokeTestPipelineStepTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	12
Ratio	100 %

Metric	Value
dl	12
loc	12
rs	9.4285
cc	1
eloc	10
nc	1
nop	0

<?php

class SmokeTestPipelineStepTest extends PipelineTest {
namespace YourVendor;

class YourClass { }

	protected static $fixture_file = 'PipelineTest.yml';

	/**
	 * Make the dummy deployment step
	 *
	 * @return SmokeTestPipelineStep
	 */
	public function getDummySmokeTestStep($name) {

		// Load data inte step and pipeline
		$data = $this->getPipelineConfig();
		$smokeStep = $this->objFromFixture('SmokeTestPipelineStep', 'testsmoketest');
		$pipeline = $smokeStep->Pipeline();
		$pipeline->Config = serialize($data);
		$pipeline->write();
		$smokeStep->Config = serialize($pipeline->getConfigSetting('Steps', $name));
		$smokeStep->write();
		return $smokeStep;
	}

	/**
	 * Test successful smoke test
	 */
	public function testSmokeTestPass() {

		$this->markTestSkipped("Failing sporadically");

		return;

		$step = $this->getDummySmokeTestStep('SmokeTest');
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
		$this->assertTrue($step->start());
		$this->assertHasLog('Starting smoke test "Videos" to URL http://www.youtube.com/');
		$this->assertHasLog('Smoke test "Videos" to URL http://www.youtube.com/ successful');
		$this->assertHasLog('Starting smoke test "Home" to URL https://github.com/');
		$this->assertHasLog('Smoke test "Home" to URL https://github.com/ successful');
		$this->assertEquals('Finished', $step->Status);
	}

	/**
	 * Test failed smoke test
	 */
	public function testSmokeTestFail() {

		// the testsmokefaile yml config contains a invalid smoketest url
		// which is how it fails
		$step = $this->getDummySmokeTestStep('FailTest');
		$this->assertFalse($step->start());

		$this->assertHasLog('Starting smoke test "BrokenPage" to URL http://bob.bob.bob.bob/');
		$this->assertHasLog('Curl error: ');
		$this->assertHasLog('Starting smoke test "Home" to URL https://github.com/');
		$this->assertHasLog('Smoke test "Home" to URL https://github.com/ successful');
		$this->assertEquals('Failed', $step->Status);

	}

	public function testReattempts() {
		// the testsmokefaile yml config contains a invalid smoketest url which is how it fails
		$step = $this->getDummySmokeTestStep('RepeatTest');
		$this->assertFalse($step->start());

		$this->assertHasLog('Starting smoke test "BrokenPage" to URL http://bob.bob.bob.bob/');
		$this->assertHasLog('Curl error: ');
		$this->assertHasLog('Starting smoke test "Home" to URL https://github.com/');
		$this->assertHasLog('Smoke test "Home" to URL https://github.com/ successful');
		$this->assertHasLog('Request failed, performing reattempt (#1)');
		$this->assertHasLog('Request failed, performing reattempt (#2)');
		$this->assertHasLog('Failed after 3 attempts');
		$this->assertEquals('Failed', $step->Status);

	}
}


1		<?php
2
3		class SmokeTestPipelineStepTest extends PipelineTest {
		1 ignored issue – show Coding Style Compatibility introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5		protected static $fixture_file = 'PipelineTest.yml';
6
7		/**
8		* Make the dummy deployment step
9		*
10		* @return SmokeTestPipelineStep
11		*/
12	View Code Duplication	public function getDummySmokeTestStep($name) {
		0 ignored issues – show Duplication introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		// Load data inte step and pipeline
14		$data = $this->getPipelineConfig();
15		$smokeStep = $this->objFromFixture('SmokeTestPipelineStep', 'testsmoketest');
16		$pipeline = $smokeStep->Pipeline();
17		$pipeline->Config = serialize($data);
18		$pipeline->write();
19		$smokeStep->Config = serialize($pipeline->getConfigSetting('Steps', $name));
20		$smokeStep->write();
21		return $smokeStep;
22		}
23
24		/**
25		* Test successful smoke test
26		*/
27	View Code Duplication	public function testSmokeTestPass() {
		0 ignored issues – show Duplication introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		$this->markTestSkipped("Failing sporadically");
		0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `markTestSkipped()` does not seem to exist on `object<SmokeTestPipelineStepTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29		return;
30
31		$step = $this->getDummySmokeTestStep('SmokeTest');
		0 ignored issues – show Unused Code introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report `$step = $this->getDummyS...eTestStep('SmokeTest');` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
32		$this->assertTrue($step->start());
33		$this->assertHasLog('Starting smoke test "Videos" to URL http://www.youtube.com/');
34		$this->assertHasLog('Smoke test "Videos" to URL http://www.youtube.com/ successful');
35		$this->assertHasLog('Starting smoke test "Home" to URL https://github.com/');
36		$this->assertHasLog('Smoke test "Home" to URL https://github.com/ successful');
37		$this->assertEquals('Finished', $step->Status);
38		}
39
40		/**
41		* Test failed smoke test
42		*/
43	View Code Duplication	public function testSmokeTestFail() {
		0 ignored issues – show Duplication introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		// the testsmokefaile yml config contains a invalid smoketest url
45		// which is how it fails
46		$step = $this->getDummySmokeTestStep('FailTest');
47		$this->assertFalse($step->start());
		0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<SmokeTestPipelineStepTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48		$this->assertHasLog('Starting smoke test "BrokenPage" to URL http://bob.bob.bob.bob/');
49		$this->assertHasLog('Curl error: ');
50		$this->assertHasLog('Starting smoke test "Home" to URL https://github.com/');
51		$this->assertHasLog('Smoke test "Home" to URL https://github.com/ successful');
52		$this->assertEquals('Failed', $step->Status);
		1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<SmokeTestPipelineStepTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
53		}
54
55		public function testReattempts() {
56		// the testsmokefaile yml config contains a invalid smoketest url which is how it fails
57		$step = $this->getDummySmokeTestStep('RepeatTest');
58		$this->assertFalse($step->start());
		0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<SmokeTestPipelineStepTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
59		$this->assertHasLog('Starting smoke test "BrokenPage" to URL http://bob.bob.bob.bob/');
60		$this->assertHasLog('Curl error: ');
61		$this->assertHasLog('Starting smoke test "Home" to URL https://github.com/');
62		$this->assertHasLog('Smoke test "Home" to URL https://github.com/ successful');
63		$this->assertHasLog('Request failed, performing reattempt (#1)');
64		$this->assertHasLog('Request failed, performing reattempt (#2)');
65		$this->assertHasLog('Failed after 3 attempts');
66		$this->assertEquals('Failed', $step->Status);
		1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<SmokeTestPipelineStepTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
67		}
68		}
69

silverstripe / deploynaut

Pull Request — master (#513)

SmokeTestPipelineStepTest::testSmokeTestPass() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like