DNProjectTest::testNonViewerGroupAllowedIsFalse() - Code Metrics - Inspection of "Added standard Scrutinizer config" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#513)

by Helpful

created 2016-02-21 21:40 UTC

DNProjectTest::testNonViewerGroupAllowedIsFalse() A

↳ Parent: DNProjectTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	5

Duplication

Lines	6
Ratio	100 %

Metric	Value
dl	6
loc	6
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php


class DNProjectTest extends DeploynautTest {
namespace YourVendor;

class YourClass { }

	protected static $fixture_file = 'DNProjectTest.yml';

	/**
	 * @var DNProject
	 */
	protected $project = null;

	public function setUp() {
		parent::setUp();

		$this->project = DNProject::create();
		$this->project->Name = 'testproject';
	}

	/**
	 *
	 */
	public function testOnBeforeWriteShouldNotCreateCapFolder() {

		$this->assertTrue(file_exists($this->envPath));

		$this->assertFalse(file_exists($this->envPath.'/testproject'));

		$this->project->onBeforeWrite();
		$this->assertFalse(file_exists($this->envPath.'/testproject'), 'Folder should not have been created');

	}

	public function testOnBeforeWriteShouldCreateCapFolder() {

		$this->assertTrue(file_exists($this->envPath));

		$this->assertFalse(file_exists($this->envPath.'/testproject'));

		$this->project->CreateEnvFolder = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->project->onBeforeWrite();
		$this->assertTrue(file_exists($this->envPath.'/testproject'), 'Folder should have been created');

	}

	public function testSetCreateProjectFolderFieldNoFolderExists() {
		$fields = new FieldList();
		$fields->push(new TextField('Name'));
		$this->project->setCreateProjectFolderField($fields);
		$this->assertInstanceOf('LabelField', $fields->fieldByName('CreateEnvFolderNotice'));

		$this->assertInstanceOf('CheckboxField', $fields->fieldByName('CreateEnvFolder'));

	}

	public function testSetCreateProjectFolderFieldFolderExists() {
		$this->assertFalse(

			file_exists($this->envPath.'/'.$this->project->Name),
			'project folder shouldnt exist prior to save'
		);
		$this->project->CreateEnvFolder = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$this->project->onBeforeWrite();
		$fields = new FieldList();
		$fields->push(new TextField('Name'));
		$this->project->setCreateProjectFolderField($fields);
		$this->assertNull($fields->fieldByName('CreateEnvFolderNotice'));

		$this->assertNull($fields->fieldByName('CreateEnvFolder'));

	}

	public function testExceededDiskQuota() {
		$project = $this->getMock('DNProject', array('getUsedQuotaMB'));

		$project->expects($this->any())->method('getUsedQuotaMB')->will($this->returnValue(5));

		$project->DiskQuotaMB = 1;
		$this->assertTrue($project->HasExceededDiskQuota());

		$project->DiskQuotaMB = 100;
		$this->assertFalse($project->HasExceededDiskQuota());

	}

	public function testHasDiskQuota() {
		Config::inst()->update('DNProject', 'defaults', array('DiskQuotaMB' => 0));
		$this->assertFalse($this->project->HasDiskQuota());


		Config::inst()->update('DNProject', 'defaults', array('DiskQuotaMB' => 2048));
		$this->assertTrue($this->project->HasDiskQuota());


		$this->project->DiskQuotaMB = 2;
		$this->assertTrue($this->project->HasDiskQuota());

	}

	public function testAllowed() {
		$project = $this->objFromFixture('DNProject', 'firstProject');
		$viewer = $this->objFromFixture('Member', 'viewer');

		$this->assertTrue(

			$project->allowed('FOO_PERMISSION', $viewer),
			'Member that is in the group that has the code, and is in project\'s Viewers, is allowed'
		);
		$this->assertTrue(

			$project->allowed('BAR_PERMISSION', $viewer),
			'Member that has a role that has the code, and is in project\'s Viewers, is allowed'
		);

		$other = $this->objFromFixture('DNProject', 'otherproject');
		$this->assertFalse(

			$other->allowed('FOO_PERMISSION', $viewer),
			'Member that is in the group that has a code, but that is not in project\'s Viewers, is disallowed'
		);
		$this->assertFalse(

			$other->allowed('BAR_PERMISSION', $viewer),
			'Member that has a role that has the code, but that is not in project\'s Viewers, is disallowed'
		);
	}

	public function testAllowedAny() {
		$project = $this->objFromFixture('DNProject', 'firstProject');
		$viewer = $this->objFromFixture('Member', 'viewer');

		$this->assertTrue(

			$project->allowedAny(array('FOO_PERMISSION', 'NONEXISTENT_PERMISSION'), $viewer),
			'Member that is in the group that has the code, and is in project\'s Viewers, is allowed'
		);
		$this->assertTrue(

			$project->allowedAny(array('BAR_PERMISSION', 'NONEXISTENT_PERMISSION'), $viewer),
			'Member that has a role that has the code, and is in project\'s Viewers, is allowed'
		);

	}

	public function testWhoIsAllowed() {
		$project = $this->objFromFixture('DNProject', 'firstProject');
		$this->assertCount(0, $project->whoIsAllowed('NONEXISTENT_PERMISSION'));

		$this->assertDOSEquals(array(
			array('Email' =>'[email protected]')
		), $project->whoIsAllowed('FOO_PERMISSION'));
		$this->assertDOSEquals(array(
			array('Email' =>'[email protected]')
		), $project->whoIsAllowed('BAR_PERMISSION'));

		$other = $this->objFromFixture('DNProject', 'otherproject');
		$this->assertCount(0, $other->whoIsAllowed('FOO_PERMISSION'));

		$this->assertCount(0, $other->whoIsAllowed('BAR_PERMISSION'));

	}

	public function testWhoIsAllowedAny() {
		$project = $this->objFromFixture('DNProject', 'firstProject');
		$this->assertCount(0, $project->whoIsAllowedAny(array('NONEXISTENT_PERMISSION', 'NONEXISTENT_PERMISSION_2')));

		$this->assertDOSEquals(array(
			array('Email' =>'[email protected]')
		), $project->whoIsAllowedAny(array('FOO_PERMISSION', 'NONEXISTENT_PERMISSION')));
		$this->assertDOSEquals(array(
			array('Email' =>'[email protected]')
		), $project->whoIsAllowedAny(array('BAR_PERMISSION', 'NONEXISTENT_PERMISSION')));
	}

	/**
	 *
	 */
	public function testFooGroupIsAllowedToFooPermission() {

		$firstProject = $this->objFromFixture('DNProject', 'firstProject');
		$firstGroup = $this->objFromFixture('Group', 'firstWithCodeFoo');
		$isAllowed = $firstProject->groupAllowed('FOO_PERMISSION', $firstGroup);
		$this->assertTrue($isAllowed, 'Expected that foo group is allowed to foo perm');

	}

	public function testFooGroupIsNotAllowedToBarPermission() {

		$project = $this->objFromFixture('DNProject', 'firstProject');
		$fooGroup = $this->objFromFixture('Group', 'firstWithCodeFoo');
		$isAllowed = $project->groupAllowed('BAR_PERMISSION', $fooGroup);
		$this->assertFalse($isAllowed, 'Expected that foo group should not have access to bar perm');

	}

	public function testBarGroupIsAllowedToBarPermission() {

		$firstProject = $this->objFromFixture('DNProject', 'firstProject');
		$secondGroup = $this->objFromFixture('Group', 'secondWithRoleBar');
		$isAllowed = $firstProject->groupAllowed('BAR_PERMISSION', $secondGroup);
		$this->assertTrue($isAllowed, 'Group should have "bar" PermissionRoleCode');

	}

	public function testSecondGroupIsNotAllowedToFirstProject() {

		$firstProject = $this->objFromFixture('DNProject', 'firstProject');
		$thirdGroup = $this->objFromFixture('Group', 'thirdWithCodeFoo');
		$isAllowed = $firstProject->groupAllowed('FOO_PERMISSION', $thirdGroup);
		$this->assertFalse($isAllowed, 'Expected that non project group should be denied');

	}

	public function testNonViewerGroupAllowedIsFalse() {

		$otherProject = $this->objFromFixture('DNProject', 'otherproject');
		$firstGroup = $this->objFromFixture('Group', 'firstWithCodeFoo');
		$isAllowed = $otherProject->groupAllowed('FOO_PERMISSION', $firstGroup);
		$this->assertFalse($isAllowed, 'Expected that non project group should be denied');

	}
}


1		<?php
2
3
4		class DNProjectTest extends DeploynautTest {
		1 ignored issue – show Coding Style Compatibility introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5
6		protected static $fixture_file = 'DNProjectTest.yml';
7
8		/**
9		* @var DNProject
10		*/
11		protected $project = null;
12
13		public function setUp() {
14		parent::setUp();
15
16		$this->project = DNProject::create();
17		$this->project->Name = 'testproject';
18		}
19
20		/**
21		*
22		*/
23	View Code Duplication	public function testOnBeforeWriteShouldNotCreateCapFolder() {
		0 ignored issues – show Duplication introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		$this->assertTrue(file_exists($this->envPath));
		1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<DNProjectTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25		$this->assertFalse(file_exists($this->envPath.'/testproject'));
		0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNProjectTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
26		$this->project->onBeforeWrite();
27		$this->assertFalse(file_exists($this->envPath.'/testproject'), 'Folder should not have been created');
		0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNProjectTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
28		}
29
30	View Code Duplication	public function testOnBeforeWriteShouldCreateCapFolder() {
		0 ignored issues – show Duplication introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		$this->assertTrue(file_exists($this->envPath));
		1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<DNProjectTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32		$this->assertFalse(file_exists($this->envPath.'/testproject'));
		0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNProjectTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...

silverstripe / deploynaut

Pull Request — master (#513)

DNProjectTest::testNonViewerGroupAllowedIsFalse() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like