DNEnvironmentTest::testPermissions() - Code Metrics - Inspection of "Added standard Scrutinizer config" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#513)

by Helpful

created 2016-02-21 21:40 UTC

DNEnvironmentTest::testPermissions() B

↳ Parent: DNEnvironmentTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	76
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	76
rs	8.9667
cc	1
eloc	57
nc	1
nop	0

How to fix Long Method

<?php
/**
 *
 */
class DNEnvironmentTest extends DeploynautTest {
namespace YourVendor;

class YourClass { }
	/**
	 * @var string
	 */
	protected static $fixture_file = 'DNEnvironmentTest.yml';

	/**
	 * @return DNEnvironment

	 */
	protected function getEnvironment() {
		return $this->objFromFixture('DNEnvironment', 'uat');
	}

	/**
	 *
	 */
	public function testGetConfigFilename() {
		$environment = $this->getEnvironment();
		$expected = $this->envPath . '/testproject/uat.rb';
		$this->assertEquals($expected, $environment->getConfigFilename());

	}

	public function testPermissions() {
		$environment = $this->getEnvironment();

		// Check deployer / restorer permissions
		$viewer = $this->objFromFixture('Member', 'viewer');
		$viewerbygroup = $this->objFromFixture('Member', 'viewerbygroup');
		$deployer = $this->objFromFixture('Member', 'deployer');
		$deployerbygroup = $this->objFromFixture('Member', 'deployerbygroup');
		$restorer = $this->objFromFixture('Member', 'restorer');
		$restorerbygroup = $this->objFromFixture('Member', 'restorerbygroup');

		$random = new Member(array('Email' => '[email protected]'));
		$random->write();

		$this->assertFalse($environment->canView($random));

		$this->assertTrue($environment->canView($viewer));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canView($viewerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$this->assertTrue($environment->canDeploy($deployer));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canDeploy($deployerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canDeploy($restorer));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canDeploy($restorerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$this->assertFalse($environment->canRestore($deployer));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canRestore($deployerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canRestore($restorer));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canRestore($restorerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		// Check backup / uploader permissions
		$backup = $this->objFromFixture('Member', 'backup');
		$backupbygroup = $this->objFromFixture('Member', 'backupbygroup');
		$uploader = $this->objFromFixture('Member', 'uploader');
		$uploaderbygroup = $this->objFromFixture('Member', 'uploaderbygroup');

		$this->assertTrue($environment->canBackup($backup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canBackup($backupbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canBackup($uploader));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canBackup($uploaderbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$this->assertFalse($environment->canUploadArchive($backup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canUploadArchive($backupbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canUploadArchive($uploader));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canUploadArchive($uploaderbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		// Check downloader / deleters permissions
		$downloader = $this->objFromFixture('Member', 'downloader');
		$downloaderbygroup = $this->objFromFixture('Member', 'downloaderbygroup');
		$deleter = $this->objFromFixture('Member', 'deleter');
		$deleterbygroup = $this->objFromFixture('Member', 'deleterbygroup');

		$this->assertTrue($environment->canDownloadArchive($downloader));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canDownloadArchive($downloaderbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canDownloadArchive($deleter));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canDownloadArchive($deleterbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$this->assertFalse($environment->canDeleteArchive($downloader));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canDeleteArchive($downloaderbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canDeleteArchive($deleter));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canDeleteArchive($deleterbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		// Pipeline permissions
		$approver = $this->objFromFixture('Member', 'approver');
		$approverbygroup = $this->objFromFixture('Member', 'approverbygroup');
		$canceller = $this->objFromFixture('Member', 'canceller');
		$cancellerbygroup = $this->objFromFixture('Member', 'cancellerbygroup');

		$this->assertTrue($environment->canApprove($approver));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canApprove($approverbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canApprove($canceller));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canApprove($cancellerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		$this->assertFalse($environment->canAbort($approver));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertFalse($environment->canAbort($approverbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canAbort($canceller));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$this->assertTrue($environment->canAbort($cancellerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}

	private function checkSnapshots($assert, $env, $member) {
		$this->$assert($env->canRestore($member));
		$this->$assert($env->canBackup($member));
		$this->$assert($env->canDownloadArchive($member));
		$this->$assert($env->canDeleteArchive($member));
	}

	public function testAllows() {
		$prod = $this->objFromFixture('DNEnvironment', 'allowtest-prod');
		$uat = $this->objFromFixture('DNEnvironment', 'allowtest-uat');
		$this->assertTrue($prod->canDeploy($this->objFromFixture('Member', 'allowProdDeployment')));

		$this->assertFalse($prod->canDeploy($this->objFromFixture('Member', 'allowNonProdDeployment')));

		$this->assertFalse($uat->canDeploy($this->objFromFixture('Member', 'allowProdDeployment')));

		$this->assertTrue($uat->canDeploy($this->objFromFixture('Member', 'allowNonProdDeployment')));


		$this->checkSnapshots('assertTrue', $prod, $this->objFromFixture('Member', 'allowProdSnapshot'));
		$this->checkSnapshots('assertFalse', $prod, $this->objFromFixture('Member', 'allowNonProdSnapshot'));
		$this->checkSnapshots('assertFalse', $uat, $this->objFromFixture('Member', 'allowProdSnapshot'));
		$this->checkSnapshots('assertTrue', $uat, $this->objFromFixture('Member', 'allowNonProdSnapshot'));
	}

	public function testViewerPermissionInheritedFromProjectIfNotConfigured() {
		$environment = $this->objFromFixture('DNEnvironment', 'dev');
		$viewerbygroup = $this->objFromFixture('Member', 'viewerbygroup');

		$random = new Member(array('Email' => '[email protected]'));
		$random->write();

		$this->assertFalse($environment->canView($random));

		$this->assertTrue($environment->canView($viewerbygroup));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}

	public function testBackendIdentifierField() {
		// Two backends means that there will be a dropdown field
		$backends = array(
			'BackendOne' => 'One',
			'BackendTwo' => 'Two',
		);

		Config::inst()->remove('DNEnvironment', 'allowed_backends');
		Config::inst()->update('DNEnvironment', 'allowed_backends', $backends);

		$environment = $this->objFromFixture('DNEnvironment', 'dev');
		$fields = $environment->getCMSFields();
		$this->assertEquals($backends, $fields->dataFieldByName('BackendIdentifier')->getSource());



		// One backend means that there won't
		Config::inst()->remove('DNEnvironment', 'allowed_backends');
		Config::inst()->update('DNEnvironment', 'allowed_backends', array('BackendOne' => 'One'));

		$fields = $environment->getCMSFields();
		$this->assertNull($fields->dataFieldByName('BackendIdentifier'));

	}
}

class BackendOne extends DemoDeploymentBackend implements TestOnly {
namespace YourVendor;

class YourClass { }

}

class BackendTwo extends DemoDeploymentBackend implements TestOnly  {
namespace YourVendor;

class YourClass { }

}



1			<?php
2			/**
3			*
4			*/
5			class DNEnvironmentTest extends DeploynautTest {
			1 ignored issue – show Coding Style Compatibility introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			/**
7			* @var string
8			*/
9			protected static $fixture_file = 'DNEnvironmentTest.yml';
10
11			/**
12			* @return DNEnvironment
			0 ignored issues – show Documentation introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report Should the return type not be `DNEnvironment\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
13			*/
14			protected function getEnvironment() {
15			return $this->objFromFixture('DNEnvironment', 'uat');
16			}
17
18			/**
19			*
20			*/
21			public function testGetConfigFilename() {
22			$environment = $this->getEnvironment();
23			$expected = $this->envPath . '/testproject/uat.rb';
24			$this->assertEquals($expected, $environment->getConfigFilename());
			1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DNEnvironmentTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25			}
26
27			public function testPermissions() {
28			$environment = $this->getEnvironment();
29
30			// Check deployer / restorer permissions
31			$viewer = $this->objFromFixture('Member', 'viewer');
32			$viewerbygroup = $this->objFromFixture('Member', 'viewerbygroup');
33			$deployer = $this->objFromFixture('Member', 'deployer');
34			$deployerbygroup = $this->objFromFixture('Member', 'deployerbygroup');
35			$restorer = $this->objFromFixture('Member', 'restorer');
36			$restorerbygroup = $this->objFromFixture('Member', 'restorerbygroup');
37

silverstripe / deploynaut

Pull Request — master (#513)

DNEnvironmentTest::testPermissions() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like