DNDataArchiveTest - Code Metrics - Inspection of "Added standard Scrutinizer config" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#513)

by Helpful

created 2016-02-21 21:40 UTC

DNDataArchiveTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	172
Duplicated Lines	42.44 %

Coupling/Cohesion

Components	1
Dependencies	5

Metric	Value
wmc	10
lcom	1
cbo	5
dl	73
loc	172
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
B	testArchivePermissions()	0	38	1
A	testGenerateFilePath()	20	20	1
A	testGenerateFileName()	19	19	1
B	testCanMoveTo()	0	27	1
A	testValidateArchiveContentsAll()	0	6	1
A	testValidateArchiveContentsDB()	10	10	1
A	testValidateArchiveContentsDBFails()	7	7	1
A	testValidateArchiveContentsAssets()	10	10	1
A	testValidateArchiveContentsAssetsFails()	7	7	1
A	testValidateArchiveContentsFileMissingFails()	0	8	1

How to fix Duplicated Code

<?php

class DNDataArchiveTest extends DeploynautTest {
namespace YourVendor;

class YourClass { }

	protected static $fixture_file = 'DNDataArchiveTest.yml';

	/**
	 * We check a number of different conditionals here (see DNDataArchiveTest.yml for relationships):
	 * - Samantha can upload to & download from project1:uat, but not project1:live
	 * - Sarah can upload to but not download from project1:uat, and can't do anything with project1:live
	 * - Neither Samantha nor Sarah can do anything with project2:uat or project2:live
	 */
	public function testArchivePermissions() {
		$project1 = $this->objFromFixture('DNProject', 'project1');
		$project2 = $this->objFromFixture('DNProject', 'project2');

		$samantha = $this->objFromFixture('Member', 'project1-samantha');
		$sarah = $this->objFromFixture('Member', 'project1-sarah');

		// Samantha can upload to & download from project1:uat, but not project1:live
		$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canUploadArchive($samantha));

		$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canDownloadArchive($samantha));

		$this->assertFalse($project1->Environments()->filter('Name', 'uat')->First()->canDeleteArchive($samantha));

		$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canUploadArchive($samantha));

		$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canDownloadArchive($samantha));

		$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canDeleteArchive($samantha));


		// Sarah can upload to but not download from project1:uat, and can't do anything with project1:live
		$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canUploadArchive($sarah));

		$this->assertFalse($project1->Environments()->filter('Name', 'uat')->First()->canDownloadArchive($sarah));

		$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canDeleteArchive($sarah));

		$this->assertTrue($project1->Environments()->filter('Name', 'live')->First()->canUploadArchive($sarah));

		$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canDownloadArchive($sarah));

		$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canDeleteArchive($sarah));


		// Neither Samantha nor Sarah can do anything with project2:uat or project2:live
		$this->assertFalse($project2->Environments()->filter('Name', 'uat')->First()->canUploadArchive($samantha));

		$this->assertFalse($project2->Environments()->filter('Name', 'uat')->First()->canDownloadArchive($samantha));

		$this->assertFalse($project2->Environments()->filter('Name', 'uat')->First()->canDeleteArchive($samantha));

		$this->assertFalse($project2->Environments()->filter('Name', 'live')->First()->canUploadArchive($samantha));

		$this->assertFalse($project2->Environments()->filter('Name', 'live')->First()->canDownloadArchive($samantha));

		$this->assertFalse($project2->Environments()->filter('Name', 'live')->First()->canDeleteArchive($samantha));


		$this->assertFalse($project2->Environments()->filter('Name', 'uat')->First()->canUploadArchive($sarah));

		$this->assertFalse($project2->Environments()->filter('Name', 'uat')->First()->canDownloadArchive($sarah));

		$this->assertFalse($project2->Environments()->filter('Name', 'uat')->First()->canDeleteArchive($sarah));

		$this->assertFalse($project2->Environments()->filter('Name', 'live')->First()->canUploadArchive($sarah));

		$this->assertFalse($project2->Environments()->filter('Name', 'live')->First()->canDownloadArchive($sarah));

		$this->assertFalse($project2->Environments()->filter('Name', 'live')->First()->canDeleteArchive($sarah));

	}

	public function testGenerateFilePath() {

		// SS_Datetime::mock_now('2010-01-01 23:23:23');

		$project1 = $this->objFromFixture('DNProject', 'project1');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$project1uatEnv = $this->objFromFixture('DNEnvironment', 'project1-uat');

		$dataTransfer = DNDataTransfer::create();
		$dataTransfer->Direction = 'get';
		$dataTransfer->Mode = 'all';
		$dataTransfer->write();

		$archive = DNDataArchive::create();
		$archive->OriginalEnvironmentID = $project1uatEnv->ID;
		$archive->write();

		$filepath1 = $archive->generateFilepath($dataTransfer);
		$this->assertNotNull($filepath1);

		$this->assertContains('project-1', $filepath1);
		$this->assertContains('uat', $filepath1);
		$this->assertContains('transfer-' . $dataTransfer->ID, $filepath1);
	}

	public function testGenerateFileName() {

		$project1 = $this->objFromFixture('DNProject', 'project1');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$project1uatEnv = $this->objFromFixture('DNEnvironment', 'project1-uat');

		$dataTransfer = DNDataTransfer::create();
		$dataTransfer->Direction = 'get';
		$dataTransfer->Mode = 'all';
		$dataTransfer->write();

		$archive = DNDataArchive::create();
		$archive->OriginalEnvironmentID = $project1uatEnv->ID;
		$archive->write();

		$filename = $archive->generateFilename($dataTransfer);
		$this->assertNotNull($filename);

		$this->assertContains('project-1', $filename);
		$this->assertContains('uat', $filename);
		$this->assertContains('all', $filename);
	}

	public function testCanMoveTo() {
		$samantha = $this->objFromFixture('Member', 'project1-samantha');
		$sarah = $this->objFromFixture('Member', 'project1-sarah');
		$eva = $this->objFromFixture('Member', 'eva');
		$uat1 = $this->objFromFixture('DNEnvironment', 'project1-uat');
		$live1 = $this->objFromFixture('DNEnvironment', 'project1-live');
		$uat2 = $this->objFromFixture('DNEnvironment', 'project2-uat');
		$live2 = $this->objFromFixture('DNEnvironment', 'project2-live');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$archive = DNDataArchive::create();
		$archive->EnvironmentID = $uat1->ID;
		$archive->write();

		// Samantha doesn't have upload permission to live1.
		$this->assertFalse($archive->canMoveTo($live1, $samantha));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		// Cross-project moves are forbidden.
		$this->assertFalse($archive->canMoveTo($uat2, $samantha));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		// Eva has upload permission to live1.
		$this->assertTrue($archive->canMoveTo($live1, $eva));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		// Cross-project moves are forbidden.
		$this->assertFalse($archive->canMoveTo($uat2, $eva));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		// Sarah has upload permission to live1, but not download to uat1.
		$this->assertFalse($archive->canMoveTo($live1, $sarah));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

	}

	public function testValidateArchiveContentsAll() {
		$archive = DNDataArchive::create();
		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/all.sspak';
		$result = $archive->validateArchiveContents('all');
		$this->assertTrue($result->valid());

	}

	public function testValidateArchiveContentsDB() {

		$archive = DNDataArchive::create();
		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/all.sspak';
		$result = $archive->validateArchiveContents('db');
		$this->assertTrue($result->valid());


		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/db.sspak';
		$result = $archive->validateArchiveContents('db');
		$this->assertTrue($result->valid());

	}

	public function testValidateArchiveContentsDBFails() {

		$archive = DNDataArchive::create();
		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/assets.sspak';
		$result = $archive->validateArchiveContents('db');
		$this->assertFalse($result->valid());

		$this->assertEquals('The snapshot is missing the database.', current($result->messageList()));

	}

	public function testValidateArchiveContentsAssets() {

		$archive = DNDataArchive::create();
		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/all.sspak';
		$result = $archive->validateArchiveContents('assets');
		$this->assertTrue($result->valid());


		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/assets.sspak';
		$result = $archive->validateArchiveContents('assets');
		$this->assertTrue($result->valid());

	}

	public function testValidateArchiveContentsAssetsFails() {

		$archive = DNDataArchive::create();
		$archive->ArchiveFile()->Filename = __DIR__.'/sspaks/db.sspak';
		$result = $archive->validateArchiveContents('assets');
		$this->assertFalse($result->valid());

		$this->assertEquals('The snapshot is missing assets.', current($result->messageList()));

	}

	public function testValidateArchiveContentsFileMissingFails() {
		$archive = DNDataArchive::create();
		$filename = __DIR__.'/sspaks/not.found.sspak';
		$archive->ArchiveFile()->Filename = $filename;
		$result = $archive->validateArchiveContents('all');
		$this->assertFalse($result->valid());

		$this->assertEquals('SSPak file "'.$filename.'" cannot be read.', current($result->messageList()));

	}
}


1			<?php
2
3			class DNDataArchiveTest extends DeploynautTest {
			1 ignored issue – show Coding Style Compatibility introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5			protected static $fixture_file = 'DNDataArchiveTest.yml';
6
7			/**
8			* We check a number of different conditionals here (see DNDataArchiveTest.yml for relationships):
9			* - Samantha can upload to & download from project1:uat, but not project1:live
10			* - Sarah can upload to but not download from project1:uat, and can't do anything with project1:live
11			* - Neither Samantha nor Sarah can do anything with project2:uat or project2:live
12			*/
13			public function testArchivePermissions() {
14			$project1 = $this->objFromFixture('DNProject', 'project1');
15			$project2 = $this->objFromFixture('DNProject', 'project2');
16
17			$samantha = $this->objFromFixture('Member', 'project1-samantha');
18			$sarah = $this->objFromFixture('Member', 'project1-sarah');
19
20			// Samantha can upload to & download from project1:uat, but not project1:live
21			$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canUploadArchive($samantha));
			1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
22			$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canDownloadArchive($samantha));
			1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
23			$this->assertFalse($project1->Environments()->filter('Name', 'uat')->First()->canDeleteArchive($samantha));
			0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
24			$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canUploadArchive($samantha));
			0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25			$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canDownloadArchive($samantha));
			0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
26			$this->assertFalse($project1->Environments()->filter('Name', 'live')->First()->canDeleteArchive($samantha));
			0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
27
28			// Sarah can upload to but not download from project1:uat, and can't do anything with project1:live
29			$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canUploadArchive($sarah));
			1 ignored issue – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
30			$this->assertFalse($project1->Environments()->filter('Name', 'uat')->First()->canDownloadArchive($sarah));
			0 ignored issues – show Bug introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<DNDataArchiveTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			$this->assertTrue($project1->Environments()->filter('Name', 'uat')->First()->canDeleteArchive($sarah));

silverstripe / deploynaut

Pull Request — master (#513)

DNDataArchiveTest A

Complexity

Size/Duplication

Coupling/Cohesion

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like