Completed
Pull Request — master (#576)
by Sean
05:01 queued 01:56
created
code/model/jobs/DNDeployment.php 2 patches
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -205,12 +205,16 @@
 block discarded – undo
205 205
 	 */
206 206
 	public function getFullDeployMessages() {
207 207
 		$strategy = $this->getDeploymentStrategy();
208
-		if ($strategy->getActionCode()!=='full') return null;
208
+		if ($strategy->getActionCode()!=='full') {
209
+			return null;
210
+		}
209 211
 
210 212
 		$changes = $strategy->getChangesModificationNeeded();
211 213
 		$messages = [];
212 214
 		foreach ($changes as $change => $details) {
213
-			if ($change==='Code version') continue;
215
+			if ($change==='Code version') {
216
+				continue;
217
+			}
214 218
 
215 219
 			$messages[] = [
216 220
 				'Flag' => sprintf(
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	}
74 74
 
75 75
 	public function LogLink() {
76
-		return $this->Link() . '/log';
76
+		return $this->Link().'/log';
77 77
 	}
78 78
 
79 79
 	public function canView($member = null) {
@@ -205,12 +205,12 @@  discard block
 block discarded – undo
205 205
 	 */
206 206
 	public function getFullDeployMessages() {
207 207
 		$strategy = $this->getDeploymentStrategy();
208
-		if ($strategy->getActionCode()!=='full') return null;
208
+		if($strategy->getActionCode() !== 'full') return null;
209 209
 
210 210
 		$changes = $strategy->getChangesModificationNeeded();
211 211
 		$messages = [];
212
-		foreach ($changes as $change => $details) {
213
-			if ($change==='Code version') continue;
212
+		foreach($changes as $change => $details) {
213
+			if($change === 'Code version') continue;
214 214
 
215 215
 			$messages[] = [
216 216
 				'Flag' => sprintf(
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 			];
222 222
 		}
223 223
 
224
-		if (empty($messages)) {
224
+		if(empty($messages)) {
225 225
 			$messages[] = [
226 226
 				'Flag' => '',
227 227
 				'Text' => '<i>Environment changes have been made.</i>'
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 
271 271
 			// if there is a compare URL, and a description or a change (something actually changed)
272 272
 			// then show the URL. Otherwise don't show anything, as there is no comparison to be made.
273
-			if ($changed || $description) {
273
+			if($changed || $description) {
274 274
 				$compareUrl = isset($change['compareUrl']) ? $change['compareUrl'] : '';
275 275
 			}
276 276
 
Please login to merge, or discard this patch.
code/control/DeployForm.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 				substr($sha, 0, 8),
74 74
 				$branch->LastUpdated()->TimeDiff()
75 75
 			);
76
-			$branches[$sha . '-' . $name] = $branchValue;
76
+			$branches[$sha.'-'.$name] = $branchValue;
77 77
 		}
78 78
 
79 79
 		// Tags
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 				substr($sha, 0, 8),
87 87
 				$branch->LastUpdated()->TimeDiff()
88 88
 			);
89
-			$tags[$sha . '-' . $tag] = $tagValue;
89
+			$tags[$sha.'-'.$tag] = $tagValue;
90 90
 		}
91 91
 		$tags = array_reverse($tags);
92 92
 
Please login to merge, or discard this patch.