Completed
Pull Request — master (#583)
by Sean
05:23 queued 02:16
created
code/control/DNDeploymentDispatcher.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 
20 20
 	public function getModel($name) {
21 21
 		$deployment = $this->getDeployment();
22
-		if (!$deployment) {
22
+		if(!$deployment) {
23 23
 			return [];
24 24
 		}
25 25
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	public function getDeployment() {
32 32
 		$id = $this->request->param('Id');
33 33
 		$deployment = DNDeployment::get()->byId($id);
34
-		if (!$deployment || !$deployment->exists()) {
34
+		if(!$deployment || !$deployment->exists()) {
35 35
 			return false;
36 36
 		}
37 37
 		return $deployment;
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	public function apply(SS_HTTPRequest $request) {
41 41
 		$this->checkSecurityToken();
42 42
 		$response = $this->checkRequest();
43
-		if ($response instanceof SS_HTTPResponse) {
43
+		if($response instanceof SS_HTTPResponse) {
44 44
 			return $response;
45 45
 		}
46 46
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	public function canApply(SS_HTTPRequest $request) {
55 55
 		$this->checkSecurityToken();
56 56
 		$response = $this->checkRequest();
57
-		if ($response instanceof SS_HTTPResponse) {
57
+		if($response instanceof SS_HTTPResponse) {
58 58
 			return $response;
59 59
 		}
60 60
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 		}
76 76
 
77 77
 		$deployment = $this->getDeployment();
78
-		if (!$deployment) {
78
+		if(!$deployment) {
79 79
 			return new SS_HTTPResponse('Deployment not found', 404);
80 80
 		}
81 81
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
 	protected function getMachine() {
86 86
 		$deployment = $this->getDeployment();
87
-		if (!$deployment) {
87
+		if(!$deployment) {
88 88
 			return null;
89 89
 		}
90 90
 
@@ -96,10 +96,10 @@  discard block
 block discarded – undo
96 96
 			// It gives a chance to perform a dry-run, and reject the transition, for example
97 97
 			// in case the user is unauthorised.
98 98
 			'finite.test_transition',
99
-			function (Finite\Event\TransitionEvent $e) use ($project) {
99
+			function(Finite\Event\TransitionEvent $e) use ($project) {
100 100
 				$code = null;
101 101
 
102
-				switch ($e->getTransition()->getName()) {
102
+				switch($e->getTransition()->getName()) {
103 103
 				case 'approve':
104 104
 					$code = self::ALLOW_DNDEPLOYMENT_APPROVE;
105 105
 					break;
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 					break;
109 109
 				}
110 110
 
111
-				if (!$code || !$project->allowed($code)) {
111
+				if(!$code || !$project->allowed($code)) {
112 112
 					$e->reject();
113 113
 				}
114 114
 			}
Please login to merge, or discard this patch.
code/model/StateMachineFactory.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,17 +58,17 @@
 block discarded – undo
58 58
 
59 59
 	protected function addHandlers($machine) {
60 60
 		$class = get_class($machine->getObject());
61
-		if (empty($this->config()->handlers[$class])) return;
61
+		if(empty($this->config()->handlers[$class])) return;
62 62
 
63 63
 		$transitions = $this->config()->handlers[$class];
64
-		foreach ($transitions as $transName => $handlers) {
65
-			if (!is_array($handlers)) {
64
+		foreach($transitions as $transName => $handlers) {
65
+			if(!is_array($handlers)) {
66 66
 				throw new Exception(sprintf('Transition %s must be configured as an assoc array.', $transName));
67 67
 			}
68 68
 
69
-			foreach ($handlers as $handlerClass => $handlerMethod) {
69
+			foreach($handlers as $handlerClass => $handlerMethod) {
70 70
 				$handlerObj = Injector::inst()->get($handlerClass);
71
-				if (!is_callable([$handlerObj, $handlerMethod])) {
71
+				if(!is_callable([$handlerObj, $handlerMethod])) {
72 72
 					throw new Exception(sprintf('Handler %s is not callable on %s.', $handlerMethod, $handlerClass));
73 73
 				}
74 74
 				$machine->getDispatcher()->addListener(
Please login to merge, or discard this patch.
code/control/DNDeploymentHandlers.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 	}
11 11
 
12 12
 	protected function sendEmailToApprover(DNDeployment $deployment) {
13
-		if (!$deployment->Approver()->exists()) {
13
+		if(!$deployment->Approver()->exists()) {
14 14
 			return false;
15 15
 		}
16 16
 
Please login to merge, or discard this patch.
code/model/jobs/DNDeployment.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
 	}
88 88
 
89 89
 	public function getMachine() {
90
-<<<<<<< Updated upstream
90
+<< << << < Updated upstream
91 91
 		return $this->stateMachineFactory->forDNDeployment($this);
92
-||||||| merged common ancestors
92
+|| || || | merged common ancestors
93 93
 		$loader = new Finite\Loader\ArrayLoader([
94 94
 			'class'   => 'DNDeployment',
95 95
 			'states'  => [
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	public function onAbort() {
159 159
 		// 2 is SIGINT - we can't use SIGINT constant in the mod_apache context.
160 160
 		DeployJob::set_signal($this, 2);
161
-=======
161
+=== === =
162 162
 		$notificationService = Injector::inst()->get('DeploymentNotificationService');
163 163
 
164 164
 		$loader = new Finite\Loader\ArrayLoader([
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	public function onAbort() {
231 231
 		// 2 is SIGINT - we can't use SIGINT constant in the mod_apache context.
232 232
 		DeployJob::set_signal($this, 2);
233
->>>>>>> Stashed changes
233
+>> >> >> > Stashed changes
234 234
 	}
235 235
 
236 236
 	public function Link() {
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
 	}
239 239
 
240 240
 	public function LogLink() {
241
-		return $this->Link() . '/log';
241
+		return $this->Link().'/log';
242 242
 	}
243 243
 
244 244
 	public function canView($member = null) {
@@ -357,12 +357,12 @@  discard block
 block discarded – undo
357 357
 	 */
358 358
 	public function getFullDeployMessages() {
359 359
 		$strategy = $this->getDeploymentStrategy();
360
-		if ($strategy->getActionCode()!=='full') return null;
360
+		if($strategy->getActionCode() !== 'full') return null;
361 361
 
362 362
 		$changes = $strategy->getChangesModificationNeeded();
363 363
 		$messages = [];
364
-		foreach ($changes as $change => $details) {
365
-			if ($change==='Code version') continue;
364
+		foreach($changes as $change => $details) {
365
+			if($change === 'Code version') continue;
366 366
 
367 367
 			$messages[] = [
368 368
 				'Flag' => sprintf(
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
 			];
374 374
 		}
375 375
 
376
-		if (empty($messages)) {
376
+		if(empty($messages)) {
377 377
 			$messages[] = [
378 378
 				'Flag' => '',
379 379
 				'Text' => '<i>Environment changes have been made.</i>'
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
 
423 423
 			// if there is a compare URL, and a description or a change (something actually changed)
424 424
 			// then show the URL. Otherwise don't show anything, as there is no comparison to be made.
425
-			if ($changed || $description) {
425
+			if($changed || $description) {
426 426
 				$compareUrl = isset($change['compareUrl']) ? $change['compareUrl'] : '';
427 427
 			}
428 428
 
Please login to merge, or discard this patch.