Completed
Pull Request — master (#602)
by Sean
09:27 queued 05:11
created

DataTransferJob::perform()   B

Complexity

Conditions 7
Paths 34

Size

Total Lines 66
Code Lines 47

Duplication

Lines 22
Ratio 33.33 %

Importance

Changes 4
Bugs 1 Features 0
Metric Value
c 4
b 1
f 0
dl 22
loc 66
rs 7.0832
cc 7
eloc 47
nc 34
nop 0

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
/**
4
 * Starts a capistrano script for either retrieving data from an environment,
5
 * or pushing data into an environment. Initiated by {@link DNDataTransfer}.
6
 *
7
 * @package deploynaut
8
 * @subpackage jobs
9
 */
10
class DataTransferJob extends DeploynautJob {
11
12
	/**
13
	 * set by a resque worker
14
	 */
15
	public $args = array();
16
17
	public function setUp() {
18
		$this->updateStatus('Started');
19
		chdir(BASE_PATH);
20
	}
21
22
	public function perform() {
23
		echo "[-] DataTransferJob starting" . PHP_EOL;
24
		$log = new DeploynautLogFile($this->args['logfile']);
25
		$dataTransfer = DNDataTransfer::get()->byID($this->args['dataTransferID']);
26
		$environment = $dataTransfer->Environment();
27
		$backupDataTransfer = null;
28
29 View Code Duplication
		if(!empty($this->args['backupBeforePush']) && $dataTransfer->Direction == 'push') {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
30
			$backupDataTransfer = DNDataTransfer::create();
31
			$backupDataTransfer->EnvironmentID = $environment->ID;
32
			$backupDataTransfer->Direction = 'get';
33
			$backupDataTransfer->Mode = $dataTransfer->Mode;
34
			$backupDataTransfer->ResqueToken = $dataTransfer->ResqueToken;
35
			$backupDataTransfer->AuthorID = $dataTransfer->AuthorID;
36
			$backupDataTransfer->write();
37
38
			$dataTransfer->BackupDataTransferID = $backupDataTransfer->ID;
39
			$dataTransfer->write();
40
		}
41
42
		// This is a bit icky, but there is no easy way of capturing a failed run by using the PHP Resque
43
		try {
44
			// Disallow concurrent jobs (don't rely on queuing implementation to restrict this)
45
			// Only consider data transfers started in the last 30 minutes (older jobs probably got stuck)
46
			$runningTransfers = DNDataTransfer::get()
47
				->filter(array(
48
					'EnvironmentID' => $environment->ID,
49
					'Status' => array('Queued', 'Started'),
50
					'Created:GreaterThan' => strtotime('-30 minutes')
51
				))
52
				->exclude('ID', $dataTransfer->ID);
53
54
			if($runningTransfers->count()) {
55
				$runningTransfer = $runningTransfers->first();
56
				$message = sprintf(
57
					'Error: another transfer is in progress (started at %s by %s)',
58
					$runningTransfer->dbObject('Created')->Nice(),
59
					$runningTransfer->Author()->Title
60
				);
61
				$log->write($message);
62
				throw new \RuntimeException($message);
63
			}
64
65 View Code Duplication
			if($backupDataTransfer) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
66
				$log->write('Backing up existing data');
67
				try {
68
					$environment->Backend()->dataTransfer($backupDataTransfer, $log);
69
					$this->updateBackupStatus('Finished');
70
				} catch(Exception $e) {
71
					$this->updateBackupStatus('Failed');
72
					throw $e;
73
				}
74
			}
75
76
			$environment->Backend()->dataTransfer(
77
				$dataTransfer,
78
				$log
79
			);
80
		} catch(RuntimeException $exc) {
81
			echo "[-] DataTransferJob failed" . PHP_EOL;
82
			throw $exc;
83
		}
84
85
		$this->updateStatus('Finished');
86
		echo "[-] DataTransferJob finished" . PHP_EOL;
87
	}
88
89
	/**
90
	 * @param string $status
91
	 * @global array $databaseConfig
92
	 */
93
	protected function updateStatus($status) {
94
		global $databaseConfig;
95
		DB::connect($databaseConfig);
96
		$transfer = DNDataTransfer::get()->byID($this->args['dataTransferID']);
97
		$transfer->Status = $status;
98
		$transfer->write();
99
	}
100
101
	/**
102
	 * @param string $status Status of DNDataTransfer
103
	 * @global array $databaseConfig
104
	 */
105 View Code Duplication
	protected function updateBackupStatus($status) {
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
106
		global $databaseConfig;
107
		DB::connect($databaseConfig);
108
		$deployment = DNDeployment::get()->byID($this->args['deploymentID']);
109
		$backup = $deployment->BackupDataTransfer();
110
		if($backup && $backup->exists()) {
111
			$backup->Status = $status;
112
			$backup->write();
113
		}
114
	}
115
116
	/**
117
	 * @return DNData
118
	 */
119
	protected function DNData() {
120
		return DNData::inst();
121
	}
122
}
123