CreateEnvJob::perform() - Code Metrics - Inspection of "Ensure env create exceptions are logged (#672)" - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 50f7c4...30a49b )

by Stig

created 2016-09-28 21:53 UTC

CreateEnvJob::perform() B

↳ Parent: CreateEnvJob

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	8.9197
c	0
b	0
f	0
cc	4
eloc	14
nc	4
nop	0

<?php
class CreateEnvJob extends DeploynautJob {

	/**
	 *
	 * @var array
	 */
	public $args;

	/**
	 *
	 */
	public function setUp() {
		$this->updateStatus('Started');
		chdir(BASE_PATH);
	}

	/**
	 *
	 */
	public function perform() {
		echo "[-] CreateEnvJob starting" . PHP_EOL;
		$log = new DeploynautLogFile($this->args['logfile']);
		$envCreate = DNCreateEnvironment::get()->byId($this->args['createID']);

		try {
			if(!($envCreate && $envCreate->exists())) {
				throw new RuntimeException(sprintf('Could not find create environment record %s', $args['createID']));
			}

			// This will throw and exception if it fails.
			$envCreate->createEnvironment();

		} catch(Exception $e) {
			$log->write($e->getMessage());
			echo "[-] CreateEnvJob failed" . PHP_EOL;
			throw $e;
		}

		$this->updateStatus('Finished');
		echo "[-] CreateEnvJob finished" . PHP_EOL;
	}

	/**
	 *
	 * @param string $status
	 * @global array $databaseConfig
	 */
	protected function updateStatus($status) {
		global $databaseConfig;
function myFunction($a, $b) {
    // Do something
}
		DB::connect($databaseConfig);

		$record = DNCreateEnvironment::get()->byID($this->args['createID']);
		$record->Status = $status;
		$record->write();
	}

	/**
	 *
	 * @return DNData
	 */
	protected function DNData() {
		return DNData::inst();
	}
}



Push — master ( 50f7c4...30a49b )

CreateEnvJob::perform() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			class CreateEnvJob extends DeploynautJob {
3
4			/**
5			*
6			* @var array
7			*/
8			public $args;
9
10			/**
11			*
12			*/
13			public function setUp() {
14			$this->updateStatus('Started');
15			chdir(BASE_PATH);
16			}
17
18			/**
19			*
20			*/
21			public function perform() {
22			echo "[-] CreateEnvJob starting" . PHP_EOL;
23			$log = new DeploynautLogFile($this->args['logfile']);
24			$envCreate = DNCreateEnvironment::get()->byId($this->args['createID']);
25
26			try {
27			if(!($envCreate && $envCreate->exists())) {
28			throw new RuntimeException(sprintf('Could not find create environment record %s', $args['createID']));
29			}
30
31			// This will throw and exception if it fails.
32			$envCreate->createEnvironment();
33
34			} catch(Exception $e) {
35			$log->write($e->getMessage());
36			echo "[-] CreateEnvJob failed" . PHP_EOL;
37			throw $e;
38			}
39
40			$this->updateStatus('Finished');
41			echo "[-] CreateEnvJob finished" . PHP_EOL;
42			}
43
44			/**
45			*
46			* @param string $status
47			* @global array $databaseConfig
48			*/
49			protected function updateStatus($status) {
50			global $databaseConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
51			DB::connect($databaseConfig);
52
53			$record = DNCreateEnvironment::get()->byID($this->args['createID']);
54			$record->Status = $status;
55			$record->write();
56			}
57
58			/**
59			*
60			* @return DNData
61			*/
62			protected function DNData() {
63			return DNData::inst();
64			}
65			}
66
67

silverstripe / deploynaut

Push — master ( 50f7c4...30a49b )

CreateEnvJob::perform() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like