SS_Datetimezone

Complexity

Total Complexity

9

Size/Duplication

Total Lines	39
Duplicated Lines	7.69 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	Format()	0	11	6
A	getCurrentCachedUser()	3	10	3

<?php
/**
 * Class SS_Datetimezone
 *
 * Adds customisable timezones to the nice method on {@link SS_Datetime}.
 */
class SS_Datetimezone extends SS_Datetime {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

The property $_cache_members is not named in camelCase.

	/**
	 * @var \Member[]
	 */
	protected static $_cache_members = [];

	/**
	* Returns the date in the raw SQL-format specific to a given timezone passed from the Member class, e.g. “2006-01-18 16:32:04”

This line exceeds maximum limit of 120 characters; contains 127 characters

	*/
	public function Format($format) {
		if($this->value){
			$date = new DateTime($this->value);
			//if the current user has set a timezone that is not the default then use that
			$member = $this->getCurrentCachedUser();
			if ($member && $member->exists() && $member->Timezone && $member->Timezone != date_default_timezone_get()) {
				$date->setTimezone(new DateTimeZone($member->Timezone));
			}
			return $date->Format($format);
		}
	}

	/**
	 * Format can be called a lot of time in tight loops, so we cache the current user
	 * per request
	 *
	 * @return \Member|null
	 */
	protected function getCurrentCachedUser() {
		$memberID = \Member::currentUserID();
		if(!$memberID) {
			return null;
		}
		if(!isset(self::$_cache_members[$memberID])) {

This code seems to be duplicated across your project.

			self::$_cache_members[$memberID] = Member::get()->byId($memberID);
		}
		return self::$_cache_members[$memberID];
	}
}