PingJob - Code Metrics - silverstripe/deploynaut - Measure and Improve Code Quality continuously with Scrutinizer

PingJob A
last analyzed 2017-01-17 02:28 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	3
c	0
b	0
f	0
lcom	1
cbo	5
dl	0
loc	36
rs	10

3 Methods

Rating	Name	Size	Complexity
A	setUp()	5	1
A	DNData()	3	1
A	perform()	9	1

<?php

/**
 * Runs a capistrano job that will check the connection and that all folders with
 * permission are setup correctly
 */
class PingJob {

	/**
	 * @var array
	 */
	public $args;

	/**
	 * @global array $databaseConfig
	 */
	public function setUp() {
		global $databaseConfig;
function myFunction($a, $b) {
    // Do something
}
		DB::connect($databaseConfig);
		chdir(BASE_PATH);
	}

	/**
	 * @return DNData
	 */
	public function DNData() {
		return DNData::inst();
	}

	/**
	 * Do the actual job by calling the appropiate backend
	 */
	public function perform() {
		echo "[-] PingJob starting" . PHP_EOL;
		$log = new DeploynautLogFile($this->args['logfile']);

		$ping = DNPing::get()->byID($this->args['pingID']);
		$environment = $ping->Environment();
		$project = $environment->Project();
		$environment->Backend()->ping($environment, $log, $project);
	}
}


PingJob A
last analyzed 2017-01-17 02:28 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3			/**
4			* Runs a capistrano job that will check the connection and that all folders with
5			* permission are setup correctly
6			*/
7			class PingJob {
8
9			/**
10			* @var array
11			*/
12			public $args;
13
14			/**
15			* @global array $databaseConfig
16			*/
17			public function setUp() {
18			global $databaseConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-02-21 21:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
19			DB::connect($databaseConfig);
20			chdir(BASE_PATH);
21			}
22
23			/**
24			* @return DNData
25			*/
26			public function DNData() {
27			return DNData::inst();
28			}
29
30			/**
31			* Do the actual job by calling the appropiate backend
32			*/
33			public function perform() {
34			echo "[-] PingJob starting" . PHP_EOL;
35			$log = new DeploynautLogFile($this->args['logfile']);
36
37			$ping = DNPing::get()->byID($this->args['pingID']);
38			$environment = $ping->Environment();
39			$project = $environment->Project();
40			$environment->Backend()->ping($environment, $log, $project);
41			}
42			}
43

silverstripe / deploynaut

PingJob A last analyzed 2017-01-17 02:28 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like

PingJob A
last analyzed 2017-01-17 02:28 UTC