DNBranchList

Complexity

Total Complexity

15

Size/Duplication

Total Lines	113
Duplicated Lines	10.62 %

Coupling/Cohesion

Components	2
Dependencies	6

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	set_refs_dir()	0	3	1
A	get_refs_dir()	0	3	1
A	__construct()	0	5	1
B	getReferences()	0	26	5
A	byName()	0	11	3
A	getIterator()	12	12	4

<?php

/**
 * Class DNBranchList
 */
class DNBranchList extends ArrayList {

The property $refs_dir is not named in camelCase.

	/**
	 * @var string
	 */
	protected static $refs_dir = '';

	/**
	 * @var bool
	 */
	protected $loaded = false;

	/**
	 * @var array
	 */
	protected $builds = array();

	/**
	 * @var DNProject
	 */
	protected $project;

	/**
	 * @var DNData
	 */
	protected $data;

	public static function set_refs_dir($refsDir) {
		self::$refs_dir = $refsDir;
	}

	public static function get_refs_dir() {
		return self::$refs_dir;
	}

	/**
	 * @param \DNProject $project
	 * @param \DNData $data
	 */
	public function __construct(\DNProject $project, \DNData $data) {
		$this->project = $project;
		$this->data = $data;
		parent::__construct(array());
	}

	/**
	 * @return array
	 */
	protected function getReferences() {
		$branches = array();
		// Placeholder to put master branch first
		$firstBranch = null;

		try {
			$repository = new Gitonomy\Git\Repository($this->project->getLocalCVSPath());
		} catch(Exception $e) {
			return $branches;
		}

		foreach($repository->getReferences()->getBranches() as $branch) {
			/** @var DNBranch $obj */
			$obj = DNBranch::create($branch, $this->project, $this->data);
			if($branch->getName() == 'master') {
				$firstBranch = array($branch->getName() => $obj);
			} else {
				$branches[$branch->getName()] = $obj;
			}
		}
		if($firstBranch) {
			$branches = $firstBranch + $branches;
		}

		return $branches;
	}

	/**
	 * Find a branch in this set by branch name.
	 *
	 * @param $name
	 *
	 * @return string
	 */
	public function byName($name) {
		if($this->loaded === false) {
			$this->getIterator();
		}

		if(isset($this->items[$name])) {
			return $this->items[$name];
		}

		return '';
	}

	/**
	 * Returns an Iterator for this ArrayList.
	 * This function allows you to use ArrayList in foreach loops
	 *
	 * @return ArrayIterator
	 */
	public function getIterator() {

This method seems to be duplicated in your project.

		if($this->loaded === false) {
			$this->items = $this->getReferences();
			$this->loaded = true;
		}
		foreach($this->items as $i => $item) {
			if(is_array($item)) {
				$this->items[$i] = new ArrayData($item);
			}
		}
		return new ArrayIterator($this->items);
	}
}