silverstripe / cwp

src/Model/Quicklink.php

<?php

namespace CWP\CWP\Model;

use CWP\CWP\PageTypes\BaseHomePage;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Forms\CompositeField;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\TreeDropdownField;
use SilverStripe\ORM\DataObject;

/**
 * @method BaseHomePage Parent()
 * @method SiteTree InternalLink()
 */
class Quicklink extends DataObject
{
    private static $db = [

The private property $db is not used, and could be removed.

        'Name' => 'Varchar(255)',
        'ExternalLink' => 'Varchar(255)',
        'SortOrder' => 'Int',
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Parent' => BaseHomePage::class,
        'InternalLink' => SiteTree::class,
    ];

    private static $summary_fields = [

The private property $summary_fields is not used, and could be removed.

        'Name' => 'Name',
        'InternalLink.Title' => 'Internal Link',
        'ExternalLink' => 'External Link',
    ];

    private static $table_name = 'Quicklink';

The private property $table_name is not used, and could be removed.

    public function fieldLabels($includerelations = true)
    {
        $labels = parent::fieldLabels($includerelations);
        $labels['Name'] = _t(__CLASS__ . '.NameLabel', 'Name');
        $labels['ExternalLink'] = _t(__CLASS__ . '.ExternalLinkLabel', 'External Link');
        $labels['SortOrder'] = _t(__CLASS__ . '.SortOrderLabel', 'Sort Order');
        $labels['ParentID'] = _t(__CLASS__ . '.ParentRelationLabel', 'Parent');
        $labels['InternalLinkID'] = _t(__CLASS__ . '.InternalLinkLabel', 'Internal Link');

        return $labels;
    }

    public function getLink()
    {
        if ($this->ExternalLink) {

The property ExternalLink does not exist on CWP\CWP\Model\Quicklink. Since you implemented __get, consider adding a @property annotation.

            $url = parse_url($this->ExternalLink);

            // if no scheme set in the link, default to http
            if (!isset($url['scheme'])) {
                return 'http://' . $this->ExternalLink;
            }

            return $this->ExternalLink;
        }

        if ($this->InternalLinkID) {

The property InternalLinkID does not exist on CWP\CWP\Model\Quicklink. Since you implemented __get, consider adding a @property annotation.

            return $this->InternalLink()->Link();
        }
    }

    public function canCreate($member = null, $context = [])
    {
        // Creating quick links should not be the same permission level as creating parent pages for them, they're
        // essentially content in the context of the page, so use the edit permission instead.
        return $this->canEdit($member);
    }

    public function canEdit($member = null)
    {
        return $this->Parent()->canEdit($member);
    }

    public function canDelete($member = null)
    {
        return $this->Parent()->canDelete($member);
    }

    public function canView($member = null)
    {
        return $this->Parent()->canView($member);
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->removeByName('ParentID');

        $externalLinkField = $fields->fieldByName('Root.Main.ExternalLink');

Are you sure the assignment to $externalLinkField is correct as $fields->fieldByName('Root.Main.ExternalLink') targeting SilverStripe\Forms\FieldList::fieldByName() seems to always return null.

        $fields->removeByName('ExternalLink');
        $fields->removeByName('InternalLinkID');
        $fields->removeByName('SortOrder');
        $externalLinkField->addExtraClass('noBorder');

        $fields->addFieldToTab('Root.Main', CompositeField::create(
            array(
                TreeDropdownField::create(
                    'InternalLinkID',
                    $this->fieldLabel('InternalLinkID'),
                    SiteTree::class
                ),
                $externalLinkField,
                $wrap = CompositeField::create(

The assignment to $wrap is dead and can be removed.

                    $extraLabel = LiteralField::create(
                        'NoteOverride',
                        sprintf('<div class="message good notice">%s</div>', _t(
                            __CLASS__ . '.Note',
                            'Note: If you specify an External Link, the Internal Link will be ignored.'
                        ))
                    )
                )
            )
        ));
        $fields->insertBefore(
            'Name',
            LiteralField::create(
                'Note',
                sprintf('<p>%s</p>', _t(
                    __CLASS__ . '.Note2',
                    'Use this to specify a link to a page either on this site '
                        . '(Internal Link) or another site (External Link).'
                ))
            )
        );

        return $fields;
    }
}