silverstripe / cwp

tests/PageTypes/DatedUpdateHolderControllerTest.php

Indentation +30 added lines, -30 removed lines

@@ -9,44 +9,44 @@
 
 class DatedUpdateHolderControllerTest extends FunctionalTest
 {
-    protected static $fixture_file = 'EventHolderTest.yml';
+	protected static $fixture_file = 'EventHolderTest.yml';
 
-    protected static $use_draft_site = true;
+	protected static $use_draft_site = true;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
+	protected function setUp(): void
+	{
+		parent::setUp();
 
-        // Note: this test requires the starter theme to be installed
-        Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
-        Config::modify()->set(SSViewer::class, 'theme', 'starter');
-    }
+		// Note: this test requires the starter theme to be installed
+		Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
+		Config::modify()->set(SSViewer::class, 'theme', 'starter');
+	}
 
-    public function testSettingDateFiltersInReverseOrderShowsMessage()
-    {
-        /** @var EventHolder $holder */
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+	public function testSettingDateFiltersInReverseOrderShowsMessage()
+	{
+		/** @var EventHolder $holder */
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
 
-        $result = $this->get($holder->Link() . '?from=2018-01-10&to=2018-01-01');
+		$result = $this->get($holder->Link() . '?from=2018-01-10&to=2018-01-01');
 
-        $this->assertStringContainsString('Filter has been applied with the dates reversed', $result->getBody());
-    }
+		$this->assertStringContainsString('Filter has been applied with the dates reversed', $result->getBody());
+	}
 
-    public function testSettingFromButNotToDateShowsMessage()
-    {
-        /** @var EventHolder $holder */
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+	public function testSettingFromButNotToDateShowsMessage()
+	{
+		/** @var EventHolder $holder */
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
 
-        $result = $this->get($holder->Link() . '?from=2018-01-10');
+		$result = $this->get($holder->Link() . '?from=2018-01-10');
 
-        $this->assertStringContainsString('Filtered by a single date', $result->getBody());
-    }
+		$this->assertStringContainsString('Filtered by a single date', $result->getBody());
+	}
 
-    public function testInvalidDateFormat()
-    {
-        /** @var EventHolder $holder */
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
-        $result = $this->get($holder->Link() . '?from=christmas&to=2018-01-10');
-        $this->assertStringContainsString(htmlentities('Dates must be in "y-MM-dd" format.'), $result->getBody());
-    }
+	public function testInvalidDateFormat()
+	{
+		/** @var EventHolder $holder */
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+		$result = $this->get($holder->Link() . '?from=christmas&to=2018-01-10');
+		$this->assertStringContainsString(htmlentities('Dates must be in "y-MM-dd" format.'), $result->getBody());
+	}
 }

tests/PageTypes/SitemapPageTest.php

Indentation +19 added lines, -19 removed lines

@@ -9,27 +9,27 @@
 
 class SitemapPageTest extends FunctionalTest
 {
-    protected static $fixture_file = 'SitemapPageTest.yml';
+	protected static $fixture_file = 'SitemapPageTest.yml';
 
-    protected static $use_draft_site = true;
+	protected static $use_draft_site = true;
 
-    protected function setUp(): void
-    {
-        parent::setUp();
+	protected function setUp(): void
+	{
+		parent::setUp();
 
-        Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
-        Config::modify()->set(SSViewer::class, 'theme', 'starter');
-    }
+		Config::modify()->set(SSViewer::class, 'themes', ['starter', '$default']);
+		Config::modify()->set(SSViewer::class, 'theme', 'starter');
+	}
 
-    /**
-     * Note: this test depends on the "starter" theme being installed and configured as default
-     */
-    public function testSitemapShowsNavigationTitleNotNormalTitle()
-    {
-        $response = $this->get('sitemap');
-        $parser = new CSSContentParser($response->getBody());
-        $elements = $parser->getBySelector('.sitemap li.first .sitemap-link');
-        $this->assertNotEmpty($elements);
-        $this->assertEquals('Top page nav 1', (string) $elements[0]);
-    }
+	/**
+	 * Note: this test depends on the "starter" theme being installed and configured as default
+	 */
+	public function testSitemapShowsNavigationTitleNotNormalTitle()
+	{
+		$response = $this->get('sitemap');
+		$parser = new CSSContentParser($response->getBody());
+		$elements = $parser->getBySelector('.sitemap li.first .sitemap-link');
+		$this->assertNotEmpty($elements);
+		$this->assertEquals('Top page nav 1', (string) $elements[0]);
+	}
 }

tests/Tasks/PopulateThemeSampleDataTaskTest.php

Indentation +46 added lines, -46 removed lines

@@ -10,50 +10,50 @@
 
 class PopulateThemeSampleDataTaskTest extends SapphireTest
 {
-    protected $usesDatabase = true;
-
-    /**
-     * Ensure that the "contact" user form is only created once
-     */
-    public function testOnlyCreateContactFormOnce()
-    {
-        if (!class_exists(UserDefinedForm::class)) {
-            $this->markTestSkipped('This test requires the userforms module to be installed');
-        }
-
-        $createdMessage = 'Created "contact" UserDefinedForm';
-
-        $task = new PopulateThemeSampleDataTask;
-
-        // Run the task
-        $this->assertStringContainsString($createdMessage, $this->bufferedTask($task));
-
-        // Run a second time
-        $this->assertStringNotContainsString($createdMessage, $this->bufferedTask($task));
-
-        // Change the page name
-        $form = UserDefinedForm::get()->filter('URLSegment', 'contact')->first();
-        $form->URLSegment = 'testing';
-        $form->write();
-
-        // Ensure the old version is still detected in draft, so not recreated
-        $this->assertStringNotContainsString($createdMessage, $this->bufferedTask($task));
-
-        // Delete the page, then ensure it's recreated again (DataObject::delete will remove staged versions)
-        $form->delete();
-        $this->assertStringContainsString($createdMessage, $this->bufferedTask($task));
-    }
-
-    /**
-     * Run a BuildTask while buffering its output, and return the result
-     *
-     * @param  BuildTask $task
-     * @return string
-     */
-    protected function bufferedTask(BuildTask $task)
-    {
-        ob_start();
-        $task->run(new HTTPRequest('GET', '/'));
-        return ob_get_clean();
-    }
+	protected $usesDatabase = true;
+
+	/**
+	 * Ensure that the "contact" user form is only created once
+	 */
+	public function testOnlyCreateContactFormOnce()
+	{
+		if (!class_exists(UserDefinedForm::class)) {
+			$this->markTestSkipped('This test requires the userforms module to be installed');
+		}
+
+		$createdMessage = 'Created "contact" UserDefinedForm';
+
+		$task = new PopulateThemeSampleDataTask;
+
+		// Run the task
+		$this->assertStringContainsString($createdMessage, $this->bufferedTask($task));
+
+		// Run a second time
+		$this->assertStringNotContainsString($createdMessage, $this->bufferedTask($task));
+
+		// Change the page name
+		$form = UserDefinedForm::get()->filter('URLSegment', 'contact')->first();
+		$form->URLSegment = 'testing';
+		$form->write();
+
+		// Ensure the old version is still detected in draft, so not recreated
+		$this->assertStringNotContainsString($createdMessage, $this->bufferedTask($task));
+
+		// Delete the page, then ensure it's recreated again (DataObject::delete will remove staged versions)
+		$form->delete();
+		$this->assertStringContainsString($createdMessage, $this->bufferedTask($task));
+	}
+
+	/**
+	 * Run a BuildTask while buffering its output, and return the result
+	 *
+	 * @param  BuildTask $task
+	 * @return string
+	 */
+	protected function bufferedTask(BuildTask $task)
+	{
+		ob_start();
+		$task->run(new HTTPRequest('GET', '/'));
+		return ob_get_clean();
+	}
 }

tests/Report/CwpStatsReportTest.php

Indentation +38 added lines, -38 removed lines

@@ -11,42 +11,42 @@
 
 class CwpStatsReportTest extends SapphireTest
 {
-    protected static $fixture_file = 'CwpStatsReportTest.yml';
-
-    protected function setUp(): void
-    {
-        Config::modify()->set(SiteTree::class, 'create_default_pages', false);
-
-        parent::setUp();
-    }
-
-    public function testCount()
-    {
-        // Publish all pages apart from page3.
-        $this->objFromFixture(Page::class, 'page1')->publishRecursive();
-        $this->objFromFixture(Page::class, 'page2')->publishRecursive();
-        $this->objFromFixture(Page::class, 'page3')->publishRecursive();
-
-        // Add page5s to a subsite, if the module is installed.
-        $page5s = $this->objFromFixture(Page::class, 'page5s');
-        if (class_exists(Subsite::class)) {
-            $subsite = Subsite::create();
-            $subsite->Title = 'subsite';
-            $subsite->write();
-
-            $page5s->SubsiteID = $subsite->ID;
-            $page5s->write();
-        }
-        $page5s->publishRecursive();
-
-        $report = CwpStatsReport::create();
-        $records = $report->sourceRecords([])->toArray();
-        $i = 0;
-        $this->assertEquals(4, $records[$i++]['Count'], 'Four pages in total, across locales, subsites, live only.');
-        if (class_exists(Subsite::class)) {
-            $this->assertEquals(3, $records[$i++]['Count'], 'Three pages in the main site, if subsites installed.');
-            $this->assertEquals(1, $records[$i++]['Count'], 'One page in the subsite, if subsites installed');
-        }
-        $this->assertEquals(1, $records[$i++]['Count'], 'One file in total.');
-    }
+	protected static $fixture_file = 'CwpStatsReportTest.yml';
+
+	protected function setUp(): void
+	{
+		Config::modify()->set(SiteTree::class, 'create_default_pages', false);
+
+		parent::setUp();
+	}
+
+	public function testCount()
+	{
+		// Publish all pages apart from page3.
+		$this->objFromFixture(Page::class, 'page1')->publishRecursive();
+		$this->objFromFixture(Page::class, 'page2')->publishRecursive();
+		$this->objFromFixture(Page::class, 'page3')->publishRecursive();
+
+		// Add page5s to a subsite, if the module is installed.
+		$page5s = $this->objFromFixture(Page::class, 'page5s');
+		if (class_exists(Subsite::class)) {
+			$subsite = Subsite::create();
+			$subsite->Title = 'subsite';
+			$subsite->write();
+
+			$page5s->SubsiteID = $subsite->ID;
+			$page5s->write();
+		}
+		$page5s->publishRecursive();
+
+		$report = CwpStatsReport::create();
+		$records = $report->sourceRecords([])->toArray();
+		$i = 0;
+		$this->assertEquals(4, $records[$i++]['Count'], 'Four pages in total, across locales, subsites, live only.');
+		if (class_exists(Subsite::class)) {
+			$this->assertEquals(3, $records[$i++]['Count'], 'Three pages in the main site, if subsites installed.');
+			$this->assertEquals(1, $records[$i++]['Count'], 'One page in the subsite, if subsites installed');
+		}
+		$this->assertEquals(1, $records[$i++]['Count'], 'One file in total.');
+	}
 }

tests/PageTypes/EventHolderTest.php

Indentation +96 added lines, -96 removed lines

@@ -9,100 +9,100 @@
 
 class EventHolderTest extends SapphireTest
 {
-    protected static $fixture_file = 'EventHolderTest.yml';
-
-    public function testEventTags()
-    {
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
-
-        $tags = $holder->UpdateTags();
-        $this->assertNotNull($tags->find('Name', 'Future'), 'Finds present terms.');
-        $this->assertNull($tags->find('Name', 'Event types', 'Does not find top level taxonomy.'));
-        $this->assertNull($tags->find('Name', 'Carrot'), 'Does not find terms that are not applied.');
-    }
-
-    public function testEventWithParentFilter()
-    {
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder2');
-
-        $items = $holder->Updates();
-
-        $this->assertNotNull($items->find('URLSegment', 'other-holder'), 'Event from the holder is shown.');
-        $this->assertNull($items->find('URLSegment', 'future-event-1'), 'Events from other holders are not shown.');
-    }
-
-    public function testEventsWithTagFilter()
-    {
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
-
-        //Get the "Future" tag.
-        $tag = $this->objFromFixture(TaxonomyTerm::class, 'TaxonomyTerm1');
-
-        $items = $holder->Updates($tag->ID);
-
-        $this->assertNotNull($items->find('URLSegment', 'future-event-1'), 'Finds the tagged page.');
-        $this->assertNull($items->find('URLSegment', 'past-event-1'), 'Does not find pages that are not tagged.');
-    }
-
-    public function testEventsWithMonthFilter()
-    {
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
-
-        $items = $holder->Updates(null, null, null, 2013, 7);
-
-        $this->assertNotNull($items->find('URLSegment', 'future-event-1'), 'Finds the event in 2013-07.');
-        $this->assertNull($items->find('URLSegment', 'past-event-1'), 'Does not find events at other dates.');
-    }
-
-    public function testEventsWithDateRangeFilter()
-    {
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
-
-        $items = $holder->Updates(null, '2013-01-19', null);
-        $this->assertNotNull($items->find('URLSegment', 'past-event-2'), 'Finds the event at the date');
-        $this->assertNull($items->find('URLSegment', 'future-event-1'), 'Does not find the event at another date');
-
-        $items = $holder->Updates(null, '2013-01-01', '2013-01-19');
-        $this->assertNotNull($items->find('URLSegment', 'past-event-2'), 'Finds events in the date range');
-        $this->assertNull($items->find('URLSegment', 'future-event-1'), 'Does not find event out of range');
-    }
-
-    public function testExtractMonths()
-    {
-        // skip test on PGSQL CI, CWP was only designed to work on MySQL
-        // DatedUpdateHolder::ExtractMonths contains date functions e.g. YEAR("Date") which don't work in PGSQL
-        if (strpos(strtolower(get_class(DB::get_connector())), 'mysql') === false) {
-            $this->markTestSkipped('Not running MySQL');
-        }
-
-        $holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
-
-        $months = EventHolder::ExtractMonths(
-            $holder->Updates(),
-            'http://mybase.org/?tag=12&start=10&from=2010-10-10&to=2010-10-11', // Used for link generation
-            2013, // Currently selected
-            1 // Currently selected
-        );
-
-        // Check which years are generated.
-        $this->assertNotNull($months->find('YearName', 2013), 'Generates existing year');
-        $this->assertNull($months->find('YearName', 1990), 'Does not generate non-present year');
-
-        $year = $months->find('YearName', 2013);
-
-        // Check which months come up in 2013
-        $this->assertNotNull($year['Months']->find('MonthNumber', 7), 'Generates existing month');
-        $this->assertNull($year['Months']->find('MonthNumber', 12), 'Does not generate non-present month');
-
-        $month = $year['Months']->find('MonthNumber', 7);
-        $this->assertEquals(
-            $month['MonthLink'],
-            'http://mybase.org/?tag=12&from=2010-10-10&to=2010-10-11&month=7&year=2013',
-            'Selection link is built properly - start is removed, and tag, from and to retained.'
-        );
-
-        // Check if these months are marked properly.
-        $month = $year['Months']->find('MonthNumber', 1);
-        $this->assertEquals($month['Active'], true, 'Correctly marks active link');
-    }
+	protected static $fixture_file = 'EventHolderTest.yml';
+
+	public function testEventTags()
+	{
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+
+		$tags = $holder->UpdateTags();
+		$this->assertNotNull($tags->find('Name', 'Future'), 'Finds present terms.');
+		$this->assertNull($tags->find('Name', 'Event types', 'Does not find top level taxonomy.'));
+		$this->assertNull($tags->find('Name', 'Carrot'), 'Does not find terms that are not applied.');
+	}
+
+	public function testEventWithParentFilter()
+	{
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder2');
+
+		$items = $holder->Updates();
+
+		$this->assertNotNull($items->find('URLSegment', 'other-holder'), 'Event from the holder is shown.');
+		$this->assertNull($items->find('URLSegment', 'future-event-1'), 'Events from other holders are not shown.');
+	}
+
+	public function testEventsWithTagFilter()
+	{
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+
+		//Get the "Future" tag.
+		$tag = $this->objFromFixture(TaxonomyTerm::class, 'TaxonomyTerm1');
+
+		$items = $holder->Updates($tag->ID);
+
+		$this->assertNotNull($items->find('URLSegment', 'future-event-1'), 'Finds the tagged page.');
+		$this->assertNull($items->find('URLSegment', 'past-event-1'), 'Does not find pages that are not tagged.');
+	}
+
+	public function testEventsWithMonthFilter()
+	{
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+
+		$items = $holder->Updates(null, null, null, 2013, 7);
+
+		$this->assertNotNull($items->find('URLSegment', 'future-event-1'), 'Finds the event in 2013-07.');
+		$this->assertNull($items->find('URLSegment', 'past-event-1'), 'Does not find events at other dates.');
+	}
+
+	public function testEventsWithDateRangeFilter()
+	{
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+
+		$items = $holder->Updates(null, '2013-01-19', null);
+		$this->assertNotNull($items->find('URLSegment', 'past-event-2'), 'Finds the event at the date');
+		$this->assertNull($items->find('URLSegment', 'future-event-1'), 'Does not find the event at another date');
+
+		$items = $holder->Updates(null, '2013-01-01', '2013-01-19');
+		$this->assertNotNull($items->find('URLSegment', 'past-event-2'), 'Finds events in the date range');
+		$this->assertNull($items->find('URLSegment', 'future-event-1'), 'Does not find event out of range');
+	}
+
+	public function testExtractMonths()
+	{
+		// skip test on PGSQL CI, CWP was only designed to work on MySQL
+		// DatedUpdateHolder::ExtractMonths contains date functions e.g. YEAR("Date") which don't work in PGSQL
+		if (strpos(strtolower(get_class(DB::get_connector())), 'mysql') === false) {
+			$this->markTestSkipped('Not running MySQL');
+		}
+
+		$holder = $this->objFromFixture(EventHolder::class, 'EventHolder1');
+
+		$months = EventHolder::ExtractMonths(
+			$holder->Updates(),
+			'http://mybase.org/?tag=12&start=10&from=2010-10-10&to=2010-10-11', // Used for link generation
+			2013, // Currently selected
+			1 // Currently selected
+		);
+
+		// Check which years are generated.
+		$this->assertNotNull($months->find('YearName', 2013), 'Generates existing year');
+		$this->assertNull($months->find('YearName', 1990), 'Does not generate non-present year');
+
+		$year = $months->find('YearName', 2013);
+
+		// Check which months come up in 2013
+		$this->assertNotNull($year['Months']->find('MonthNumber', 7), 'Generates existing month');
+		$this->assertNull($year['Months']->find('MonthNumber', 12), 'Does not generate non-present month');
+
+		$month = $year['Months']->find('MonthNumber', 7);
+		$this->assertEquals(
+			$month['MonthLink'],
+			'http://mybase.org/?tag=12&from=2010-10-10&to=2010-10-11&month=7&year=2013',
+			'Selection link is built properly - start is removed, and tag, from and to retained.'
+		);
+
+		// Check if these months are marked properly.
+		$month = $year['Months']->find('MonthNumber', 1);
+		$this->assertEquals($month['Active'], true, 'Correctly marks active link');
+	}
 }