Completed
Pull Request — master (#13)
by Robbie
02:33
created

NewsHolder   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 49
Duplicated Lines 100 %

Importance

Changes 0
Metric Value
dl 49
loc 49
rs 10
c 0
b 0
f 0
wmc 1

1 Method

Rating   Name   Duplication   Size   Complexity  
A AllUpdates() 11 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace CWP\CWP\PageTypes;
4
5
use SilverStripe\ORM\DataList;
6
use SilverStripe\ORM\PaginatedList;
7
8 View Code Duplication
class NewsHolder extends DatedUpdateHolder
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
9
{
10
    private static $description = 'Container page for News Pages, provides news filtering and pagination';
0 ignored issues
show
introduced by
The private property $description is not used, and could be removed.
Loading history...
11
12
    private static $allowed_children = [
0 ignored issues
show
introduced by
The private property $allowed_children is not used, and could be removed.
Loading history...
13
        NewsPage::class,
14
    ];
15
16
    private static $default_child = NewsPage::class;
0 ignored issues
show
introduced by
The private property $default_child is not used, and could be removed.
Loading history...
17
18
    private static $update_name = 'News';
0 ignored issues
show
introduced by
The private property $update_name is not used, and could be removed.
Loading history...
19
20
    private static $update_class = NewsPage::class;
0 ignored issues
show
introduced by
The private property $update_class is not used, and could be removed.
Loading history...
21
22
    private static $icon = 'cwp/images/icons/sitetree_images/news_listing.png';
0 ignored issues
show
introduced by
The private property $icon is not used, and could be removed.
Loading history...
23
24
    public $pageIcon =  'images/icons/sitetree_images/news_listing.png';
25
26
    private static $singular_name = 'News Holder';
0 ignored issues
show
introduced by
The private property $singular_name is not used, and could be removed.
Loading history...
27
28
    private static $plural_name = 'News Holders';
0 ignored issues
show
introduced by
The private property $plural_name is not used, and could be removed.
Loading history...
29
30
    private static $table_name = 'NewsHolder';
0 ignored issues
show
introduced by
The private property $table_name is not used, and could be removed.
Loading history...
31
32
    /**
33
     * Find all site's news items, based on some filters.
34
     * Omitting parameters will prevent relevant filters from being applied. The filters are ANDed together.
35
     *
36
     * @param string $className The name of the class to fetch.
37
     * @param int $parentID The ID of the holder to extract the news items from.
38
     * @param int $tagID The ID of the tag to filter the news items by.
39
     * @param string $dateFrom The beginning of a date filter range.
40
     * @param string $dateTo The end of the date filter range. If empty, only one day will be searched for.
41
     * @param int $year Numeric value of the year to show.
42
     * @param int $monthNumber Numeric value of the month to show.
43
     *
44
     * @returns DataList|PaginatedList
45
     */
46
    public static function AllUpdates(
47
        $className = NewsPage::class,
48
        $parentID = null,
49
        $tagID = null,
50
        $dateFrom = null,
51
        $dateTo = null,
52
        $year = null,
53
        $monthNumber = null
54
    ) {
55
        return parent::AllUpdates($className, $parentID, $tagID, $dateFrom, $dateTo, $year, $monthNumber)
56
            ->Sort('Date', 'DESC');
57
    }
58
}
59