Completed
Pull Request — 2.3 (#263)
by
unknown
08:49
created
src/PageTypes/EventHolder.php 1 patch
Indentation   +53 added lines, -53 removed lines patch added patch discarded remove patch
@@ -7,57 +7,57 @@
 block discarded – undo
7 7
 
8 8
 class EventHolder extends DatedUpdateHolder
9 9
 {
10
-    private static $description = 'Container page for Event Pages, provides event filtering and pagination';
11
-
12
-    private static $allowed_children = [
13
-        EventPage::class,
14
-    ];
15
-
16
-    private static $default_child = EventPage::class;
17
-
18
-    private static $update_name = 'Events';
19
-
20
-    private static $update_class = EventPage::class;
21
-
22
-    private static $icon_class = 'font-icon-p-event-alt';
23
-
24
-    private static $singular_name = 'Event Holder';
25
-
26
-    private static $plural_name = 'Event Holders';
27
-
28
-    private static $table_name = 'EventHolder';
29
-
30
-    /**
31
-     * Find all site's news items, based on some filters.
32
-     * Omitting parameters will prevent relevant filters from being applied. The filters are ANDed together.
33
-     *
34
-     * @param string $className The name of the class to fetch.
35
-     * @param int $parentID The ID of the holder to extract the news items from.
36
-     * @param int $tagID The ID of the tag to filter the news items by.
37
-     * @param string $dateFrom The beginning of a date filter range.
38
-     * @param string $dateTo The end of the date filter range. If empty, only one day will be searched for.
39
-     * @param int $year Numeric value of the year to show.
40
-     * @param int $monthNumber Numeric value of the month to show.
41
-     *
42
-     * @returns DataList|PaginatedList
43
-     */
44
-    public static function AllUpdates(
45
-        $className = 'Events',
46
-        $parentID = null,
47
-        $tagID = null,
48
-        $dateFrom = null,
49
-        $dateTo = null,
50
-        $year = null,
51
-        $monthNumber = null
52
-    ) {
53
-        return parent::AllUpdates(
54
-            $className,
55
-            $parentID,
56
-            $tagID,
57
-            $dateFrom,
58
-            $dateTo,
59
-            $year,
60
-            $monthNumber
61
-        )->Sort('Date', 'ASC');
62
-    }
10
+	private static $description = 'Container page for Event Pages, provides event filtering and pagination';
11
+
12
+	private static $allowed_children = [
13
+		EventPage::class,
14
+	];
15
+
16
+	private static $default_child = EventPage::class;
17
+
18
+	private static $update_name = 'Events';
19
+
20
+	private static $update_class = EventPage::class;
21
+
22
+	private static $icon_class = 'font-icon-p-event-alt';
23
+
24
+	private static $singular_name = 'Event Holder';
25
+
26
+	private static $plural_name = 'Event Holders';
27
+
28
+	private static $table_name = 'EventHolder';
29
+
30
+	/**
31
+	 * Find all site's news items, based on some filters.
32
+	 * Omitting parameters will prevent relevant filters from being applied. The filters are ANDed together.
33
+	 *
34
+	 * @param string $className The name of the class to fetch.
35
+	 * @param int $parentID The ID of the holder to extract the news items from.
36
+	 * @param int $tagID The ID of the tag to filter the news items by.
37
+	 * @param string $dateFrom The beginning of a date filter range.
38
+	 * @param string $dateTo The end of the date filter range. If empty, only one day will be searched for.
39
+	 * @param int $year Numeric value of the year to show.
40
+	 * @param int $monthNumber Numeric value of the month to show.
41
+	 *
42
+	 * @returns DataList|PaginatedList
43
+	 */
44
+	public static function AllUpdates(
45
+		$className = 'Events',
46
+		$parentID = null,
47
+		$tagID = null,
48
+		$dateFrom = null,
49
+		$dateTo = null,
50
+		$year = null,
51
+		$monthNumber = null
52
+	) {
53
+		return parent::AllUpdates(
54
+			$className,
55
+			$parentID,
56
+			$tagID,
57
+			$dateFrom,
58
+			$dateTo,
59
+			$year,
60
+			$monthNumber
61
+		)->Sort('Date', 'ASC');
62
+	}
63 63
 }
Please login to merge, or discard this patch.
src/PageTypes/NewsPage.php 1 patch
Indentation   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -9,59 +9,59 @@
 block discarded – undo
9 9
 
10 10
 class NewsPage extends DatedUpdatePage
11 11
 {
12
-    private static $description = 'Describes an item of news';
12
+	private static $description = 'Describes an item of news';
13 13
 
14
-    private static $default_parent = 'NewsHolderPage';
14
+	private static $default_parent = 'NewsHolderPage';
15 15
 
16
-    private static $can_be_root = false;
16
+	private static $can_be_root = false;
17 17
 
18
-    private static $icon_class = 'font-icon-p-news-item';
18
+	private static $icon_class = 'font-icon-p-news-item';
19 19
 
20
-    private static $singular_name = 'News Page';
20
+	private static $singular_name = 'News Page';
21 21
 
22
-    private static $plural_name = 'News Pages';
22
+	private static $plural_name = 'News Pages';
23 23
 
24
-    private static $db = [
25
-        'Author' => 'Varchar(255)',
26
-    ];
24
+	private static $db = [
25
+		'Author' => 'Varchar(255)',
26
+	];
27 27
 
28
-    private static $has_one = [
29
-        'FeaturedImage' => Image::class,
30
-    ];
28
+	private static $has_one = [
29
+		'FeaturedImage' => Image::class,
30
+	];
31 31
 
32
-    private static $owns = [
33
-        'FeaturedImage',
34
-    ];
32
+	private static $owns = [
33
+		'FeaturedImage',
34
+	];
35 35
 
36
-    private static $table_name = 'NewsPage';
36
+	private static $table_name = 'NewsPage';
37 37
 
38
-    public function fieldLabels($includerelations = true)
39
-    {
40
-        $labels = parent::fieldLabels($includerelations);
41
-        $labels['Author'] = _t('CWP\\CWP\\PageTypes\\DateUpdatePage.AuthorFieldLabel', 'Author');
42
-        $labels['FeaturedImageID'] = _t(
43
-            'CWP\\CWP\\PageTypes\\DateUpdatePage.FeaturedImageFieldLabel',
44
-            'Featured Image'
45
-        );
38
+	public function fieldLabels($includerelations = true)
39
+	{
40
+		$labels = parent::fieldLabels($includerelations);
41
+		$labels['Author'] = _t('CWP\\CWP\\PageTypes\\DateUpdatePage.AuthorFieldLabel', 'Author');
42
+		$labels['FeaturedImageID'] = _t(
43
+			'CWP\\CWP\\PageTypes\\DateUpdatePage.FeaturedImageFieldLabel',
44
+			'Featured Image'
45
+		);
46 46
 
47
-        return $labels;
48
-    }
47
+		return $labels;
48
+	}
49 49
 
50
-    public function getCMSFields()
51
-    {
52
-        $this->beforeUpdateCMSFields(function (FieldList $fields) {
53
-            $fields->addFieldToTab(
54
-                'Root.Main',
55
-                TextField::create('Author', $this->fieldLabel('Author')),
56
-                'Abstract'
57
-            );
50
+	public function getCMSFields()
51
+	{
52
+		$this->beforeUpdateCMSFields(function (FieldList $fields) {
53
+			$fields->addFieldToTab(
54
+				'Root.Main',
55
+				TextField::create('Author', $this->fieldLabel('Author')),
56
+				'Abstract'
57
+			);
58 58
 
59
-            $fields->addFieldToTab(
60
-                'Root.Main',
61
-                UploadField::create('FeaturedImage', $this->fieldLabel('FeaturedImageID')),
62
-                'Abstract'
63
-            );
64
-        });
65
-        return parent::getCMSFields();
66
-    }
59
+			$fields->addFieldToTab(
60
+				'Root.Main',
61
+				UploadField::create('FeaturedImage', $this->fieldLabel('FeaturedImageID')),
62
+				'Abstract'
63
+			);
64
+		});
65
+		return parent::getCMSFields();
66
+	}
67 67
 }
Please login to merge, or discard this patch.
src/PageTypes/BasePage.php 1 patch
Indentation   +141 added lines, -141 removed lines patch added patch discarded remove patch
@@ -31,145 +31,145 @@
 block discarded – undo
31 31
 
32 32
 class BasePage extends SiteTree
33 33
 {
34
-    /**
35
-     * Hide this page type from the CMS. hide_ancestor is slightly misnamed, should really be just "hide"
36
-     *
37
-     * {@inheritDoc}
38
-     */
39
-    private static $hide_ancestor = BasePage::class;
40
-
41
-    private static $api_access = [
42
-        'view' => [
43
-            'Locale', 'URLSegment', 'Title', 'MenuTitle', 'Content', 'MetaDescription',
44
-            'ExtraMenu', 'Sort', 'Version', 'ParentID', 'ID'
45
-        ],
46
-        'edit' => [
47
-            'Locale', 'URLSegment', 'Title', 'MenuTitle', 'Content', 'MetaDescription',
48
-            'ExtraMenu', 'Sort', 'Version', 'ParentID', 'ID'
49
-        ],
50
-    ];
51
-
52
-    private static $table_name = 'BasePage';
53
-
54
-    /**
55
-     * @config
56
-     * @var string
57
-     */
58
-    private static $related_pages_title = 'Related pages';
59
-
60
-    private static $many_many = [
61
-        'Terms' => TaxonomyTerm::class,
62
-        'RelatedPagesThrough' => [
63
-            'through' => RelatedPageLink::class,
64
-            'from' => 'BasePage',
65
-            'to' => 'Child',
66
-        ]
67
-    ];
68
-
69
-    private static $owns = [
70
-        'RelatedPagesThrough',
71
-    ];
72
-
73
-    private static $belongs_many_many = [
74
-        'SimilarPages' => BasePage::class
75
-    ];
76
-
77
-    /**
78
-     * @var array
79
-     * @config
80
-     */
81
-    private static $many_many_extraFields = [
82
-        'RelatedPages' => [
83
-            'SortOrder' => 'Int',
84
-        ],
85
-    ];
86
-
87
-    private static $plural_name = 'Base Pages';
88
-
89
-    /**
90
-     * Get the footer holder.
91
-     */
92
-    public function getFooter()
93
-    {
94
-        return FooterHolder::get_one(FooterHolder::class);
95
-    }
96
-
97
-    /**
98
-     * @deprecated 2.2.0:3.0.0 Please use RelatedPagesThrough() instead
99
-     */
100
-    public function RelatedPages()
101
-    {
102
-        return $this->getManyManyComponents('RelatedPagesThrough');
103
-    }
104
-
105
-    public function RelatedPagesTitle()
106
-    {
107
-        return $this->config()->get('related_pages_title');
108
-    }
109
-
110
-    public function getCMSFields()
111
-    {
112
-        $this->beforeUpdateCMSFields(function (FieldList $fields) {
113
-            // Related Pages
114
-            $components = GridFieldConfig_RelationEditor::create();
115
-            $components->removeComponentsByType(GridFieldAddNewButton::class);
116
-            $components->removeComponentsByType(GridFieldEditButton::class);
117
-            $components->removeComponentsByType(GridFieldFilterHeader::class);
118
-            $components->addComponent(new GridFieldOrderableRows('SortOrder'));
119
-
120
-            /** @var GridFieldDataColumns $dataColumns */
121
-            $dataColumns = $components->getComponentByType(GridFieldDataColumns::class);
122
-            $dataColumns->setDisplayFields([
123
-                'Title' => _t(__CLASS__ . '.ColumnTitle', 'Title'),
124
-                'ClassName' => _t(__CLASS__ . '.ColumnPageType', 'Page Type')
125
-            ]);
126
-
127
-            $fields->findOrMakeTab(
128
-                'Root.RelatedPages',
129
-                _t(__CLASS__ . '.RelatedPages', 'Related pages')
130
-            );
131
-            $fields->addFieldToTab(
132
-                'Root.RelatedPages',
133
-                GridField::create(
134
-                    'RelatedPages',
135
-                    _t(__CLASS__ . '.RelatedPages', 'Related pages'),
136
-                    $this->RelatedPagesThrough(),
137
-                    $components
138
-                )
139
-            );
140
-
141
-            // Taxonomies - Unless they have their own 'Tags' field (such as in Blog, etc)
142
-            $hasMany = $this->hasMany();
143
-            $manyMany = $this->manyMany();
144
-            if (!isset($hasMany['Tags']) && !isset($manyMany['Tags'])) {
145
-                $fields->findOrMakeTab('Root.Tags', _t(__CLASS__ . '.TagsTabTitle', 'Tags'));
146
-                $fields->addFieldToTab(
147
-                    'Root.Tags',
148
-                    TreeMultiselectField::create(
149
-                        'Terms',
150
-                        _t(__CLASS__ . '.Terms', 'Terms'),
151
-                        TaxonomyTerm::class
152
-                    )->setDescription(_t(__CLASS__ . '.TermsDescription', 'Click to search for additional terms'))
153
-                );
154
-            }
155
-        });
156
-        return parent::getCMSFields();
157
-    }
158
-
159
-    /**
160
-     * Returns the native language name for the selected locale/language, empty string if Fluent is not available
161
-     *
162
-     * @return string
163
-     */
164
-    public function getSelectedLanguage()
165
-    {
166
-        if (!class_exists(Locale::class) || !$this->hasMethod('Locales')) {
167
-            return '';
168
-        }
169
-
170
-        /** @var ArrayData $information */
171
-        $information = $this->LocaleInformation(FluentState::singleton()->getLocale());
172
-
173
-        return $information->LanguageNative;
174
-    }
34
+	/**
35
+	 * Hide this page type from the CMS. hide_ancestor is slightly misnamed, should really be just "hide"
36
+	 *
37
+	 * {@inheritDoc}
38
+	 */
39
+	private static $hide_ancestor = BasePage::class;
40
+
41
+	private static $api_access = [
42
+		'view' => [
43
+			'Locale', 'URLSegment', 'Title', 'MenuTitle', 'Content', 'MetaDescription',
44
+			'ExtraMenu', 'Sort', 'Version', 'ParentID', 'ID'
45
+		],
46
+		'edit' => [
47
+			'Locale', 'URLSegment', 'Title', 'MenuTitle', 'Content', 'MetaDescription',
48
+			'ExtraMenu', 'Sort', 'Version', 'ParentID', 'ID'
49
+		],
50
+	];
51
+
52
+	private static $table_name = 'BasePage';
53
+
54
+	/**
55
+	 * @config
56
+	 * @var string
57
+	 */
58
+	private static $related_pages_title = 'Related pages';
59
+
60
+	private static $many_many = [
61
+		'Terms' => TaxonomyTerm::class,
62
+		'RelatedPagesThrough' => [
63
+			'through' => RelatedPageLink::class,
64
+			'from' => 'BasePage',
65
+			'to' => 'Child',
66
+		]
67
+	];
68
+
69
+	private static $owns = [
70
+		'RelatedPagesThrough',
71
+	];
72
+
73
+	private static $belongs_many_many = [
74
+		'SimilarPages' => BasePage::class
75
+	];
76
+
77
+	/**
78
+	 * @var array
79
+	 * @config
80
+	 */
81
+	private static $many_many_extraFields = [
82
+		'RelatedPages' => [
83
+			'SortOrder' => 'Int',
84
+		],
85
+	];
86
+
87
+	private static $plural_name = 'Base Pages';
88
+
89
+	/**
90
+	 * Get the footer holder.
91
+	 */
92
+	public function getFooter()
93
+	{
94
+		return FooterHolder::get_one(FooterHolder::class);
95
+	}
96
+
97
+	/**
98
+	 * @deprecated 2.2.0:3.0.0 Please use RelatedPagesThrough() instead
99
+	 */
100
+	public function RelatedPages()
101
+	{
102
+		return $this->getManyManyComponents('RelatedPagesThrough');
103
+	}
104
+
105
+	public function RelatedPagesTitle()
106
+	{
107
+		return $this->config()->get('related_pages_title');
108
+	}
109
+
110
+	public function getCMSFields()
111
+	{
112
+		$this->beforeUpdateCMSFields(function (FieldList $fields) {
113
+			// Related Pages
114
+			$components = GridFieldConfig_RelationEditor::create();
115
+			$components->removeComponentsByType(GridFieldAddNewButton::class);
116
+			$components->removeComponentsByType(GridFieldEditButton::class);
117
+			$components->removeComponentsByType(GridFieldFilterHeader::class);
118
+			$components->addComponent(new GridFieldOrderableRows('SortOrder'));
119
+
120
+			/** @var GridFieldDataColumns $dataColumns */
121
+			$dataColumns = $components->getComponentByType(GridFieldDataColumns::class);
122
+			$dataColumns->setDisplayFields([
123
+				'Title' => _t(__CLASS__ . '.ColumnTitle', 'Title'),
124
+				'ClassName' => _t(__CLASS__ . '.ColumnPageType', 'Page Type')
125
+			]);
126
+
127
+			$fields->findOrMakeTab(
128
+				'Root.RelatedPages',
129
+				_t(__CLASS__ . '.RelatedPages', 'Related pages')
130
+			);
131
+			$fields->addFieldToTab(
132
+				'Root.RelatedPages',
133
+				GridField::create(
134
+					'RelatedPages',
135
+					_t(__CLASS__ . '.RelatedPages', 'Related pages'),
136
+					$this->RelatedPagesThrough(),
137
+					$components
138
+				)
139
+			);
140
+
141
+			// Taxonomies - Unless they have their own 'Tags' field (such as in Blog, etc)
142
+			$hasMany = $this->hasMany();
143
+			$manyMany = $this->manyMany();
144
+			if (!isset($hasMany['Tags']) && !isset($manyMany['Tags'])) {
145
+				$fields->findOrMakeTab('Root.Tags', _t(__CLASS__ . '.TagsTabTitle', 'Tags'));
146
+				$fields->addFieldToTab(
147
+					'Root.Tags',
148
+					TreeMultiselectField::create(
149
+						'Terms',
150
+						_t(__CLASS__ . '.Terms', 'Terms'),
151
+						TaxonomyTerm::class
152
+					)->setDescription(_t(__CLASS__ . '.TermsDescription', 'Click to search for additional terms'))
153
+				);
154
+			}
155
+		});
156
+		return parent::getCMSFields();
157
+	}
158
+
159
+	/**
160
+	 * Returns the native language name for the selected locale/language, empty string if Fluent is not available
161
+	 *
162
+	 * @return string
163
+	 */
164
+	public function getSelectedLanguage()
165
+	{
166
+		if (!class_exists(Locale::class) || !$this->hasMethod('Locales')) {
167
+			return '';
168
+		}
169
+
170
+		/** @var ArrayData $information */
171
+		$information = $this->LocaleInformation(FluentState::singleton()->getLocale());
172
+
173
+		return $information->LanguageNative;
174
+	}
175 175
 }
Please login to merge, or discard this patch.
src/Model/Quicklink.php 1 patch
Indentation   +117 added lines, -117 removed lines patch added patch discarded remove patch
@@ -15,121 +15,121 @@
 block discarded – undo
15 15
  */
16 16
 class Quicklink extends DataObject
17 17
 {
18
-    private static $db = [
19
-        'Name' => 'Varchar(255)',
20
-        'ExternalLink' => 'Varchar(255)',
21
-        'SortOrder' => 'Int',
22
-    ];
23
-
24
-    private static $has_one = [
25
-        'Parent' => BaseHomePage::class,
26
-        'InternalLink' => SiteTree::class,
27
-    ];
28
-
29
-    private static $summary_fields = [
30
-        'Name' => 'Name',
31
-        'InternalLink.Title' => 'Internal Link',
32
-        'ExternalLink' => 'External Link',
33
-    ];
34
-
35
-    private static $table_name = 'Quicklink';
36
-
37
-    public function fieldLabels($includerelations = true)
38
-    {
39
-        $labels = parent::fieldLabels($includerelations);
40
-        $labels['Name'] = _t(__CLASS__ . '.NameLabel', 'Name');
41
-        $labels['ExternalLink'] = _t(__CLASS__ . '.ExternalLinkLabel', 'External Link');
42
-        $labels['SortOrder'] = _t(__CLASS__ . '.SortOrderLabel', 'Sort Order');
43
-        $labels['ParentID'] = _t(__CLASS__ . '.ParentRelationLabel', 'Parent');
44
-        $labels['InternalLinkID'] = _t(__CLASS__ . '.InternalLinkLabel', 'Internal Link');
45
-
46
-        return $labels;
47
-    }
48
-
49
-    public function getLink()
50
-    {
51
-        if ($this->ExternalLink) {
52
-            $url = parse_url($this->ExternalLink);
53
-
54
-            // if no scheme set in the link, default to http
55
-            if (!isset($url['scheme'])) {
56
-                return 'http://' . $this->ExternalLink;
57
-            }
58
-
59
-            return $this->ExternalLink;
60
-        }
61
-
62
-        if ($this->InternalLinkID) {
63
-            return $this->InternalLink()->Link();
64
-        }
65
-    }
66
-
67
-    public function canCreate($member = null, $context = [])
68
-    {
69
-        // Creating quick links should not be the same permission level as creating parent pages for them, they're
70
-        // essentially content in the context of the page, so use the edit permission instead.
71
-        return $this->canEdit($member);
72
-    }
73
-
74
-    public function canEdit($member = null)
75
-    {
76
-        return $this->Parent()->canEdit($member);
77
-    }
78
-
79
-    public function canDelete($member = null)
80
-    {
81
-        return $this->Parent()->canDelete($member);
82
-    }
83
-
84
-    public function canView($member = null)
85
-    {
86
-        return $this->Parent()->canView($member);
87
-    }
88
-
89
-    public function getCMSFields()
90
-    {
91
-        $fields = parent::getCMSFields();
92
-
93
-        $fields->removeByName('ParentID');
94
-
95
-        $externalLinkField = $fields->fieldByName('Root.Main.ExternalLink');
96
-
97
-        $fields->removeByName('ExternalLink');
98
-        $fields->removeByName('InternalLinkID');
99
-        $fields->removeByName('SortOrder');
100
-        $externalLinkField->addExtraClass('noBorder');
101
-
102
-        $fields->addFieldToTab('Root.Main', CompositeField::create(
103
-            array(
104
-                TreeDropdownField::create(
105
-                    'InternalLinkID',
106
-                    $this->fieldLabel('InternalLinkID'),
107
-                    SiteTree::class
108
-                ),
109
-                $externalLinkField,
110
-                $wrap = CompositeField::create(
111
-                    $extraLabel = LiteralField::create(
112
-                        'NoteOverride',
113
-                        sprintf('<div class="message good notice">%s</div>', _t(
114
-                            __CLASS__ . '.Note',
115
-                            'Note: If you specify an External Link, the Internal Link will be ignored.'
116
-                        ))
117
-                    )
118
-                )
119
-            )
120
-        ));
121
-        $fields->insertBefore(
122
-            'Name',
123
-            LiteralField::create(
124
-                'Note',
125
-                sprintf('<p>%s</p>', _t(
126
-                    __CLASS__ . '.Note2',
127
-                    'Use this to specify a link to a page either on this site '
128
-                        . '(Internal Link) or another site (External Link).'
129
-                ))
130
-            )
131
-        );
132
-
133
-        return $fields;
134
-    }
18
+	private static $db = [
19
+		'Name' => 'Varchar(255)',
20
+		'ExternalLink' => 'Varchar(255)',
21
+		'SortOrder' => 'Int',
22
+	];
23
+
24
+	private static $has_one = [
25
+		'Parent' => BaseHomePage::class,
26
+		'InternalLink' => SiteTree::class,
27
+	];
28
+
29
+	private static $summary_fields = [
30
+		'Name' => 'Name',
31
+		'InternalLink.Title' => 'Internal Link',
32
+		'ExternalLink' => 'External Link',
33
+	];
34
+
35
+	private static $table_name = 'Quicklink';
36
+
37
+	public function fieldLabels($includerelations = true)
38
+	{
39
+		$labels = parent::fieldLabels($includerelations);
40
+		$labels['Name'] = _t(__CLASS__ . '.NameLabel', 'Name');
41
+		$labels['ExternalLink'] = _t(__CLASS__ . '.ExternalLinkLabel', 'External Link');
42
+		$labels['SortOrder'] = _t(__CLASS__ . '.SortOrderLabel', 'Sort Order');
43
+		$labels['ParentID'] = _t(__CLASS__ . '.ParentRelationLabel', 'Parent');
44
+		$labels['InternalLinkID'] = _t(__CLASS__ . '.InternalLinkLabel', 'Internal Link');
45
+
46
+		return $labels;
47
+	}
48
+
49
+	public function getLink()
50
+	{
51
+		if ($this->ExternalLink) {
52
+			$url = parse_url($this->ExternalLink);
53
+
54
+			// if no scheme set in the link, default to http
55
+			if (!isset($url['scheme'])) {
56
+				return 'http://' . $this->ExternalLink;
57
+			}
58
+
59
+			return $this->ExternalLink;
60
+		}
61
+
62
+		if ($this->InternalLinkID) {
63
+			return $this->InternalLink()->Link();
64
+		}
65
+	}
66
+
67
+	public function canCreate($member = null, $context = [])
68
+	{
69
+		// Creating quick links should not be the same permission level as creating parent pages for them, they're
70
+		// essentially content in the context of the page, so use the edit permission instead.
71
+		return $this->canEdit($member);
72
+	}
73
+
74
+	public function canEdit($member = null)
75
+	{
76
+		return $this->Parent()->canEdit($member);
77
+	}
78
+
79
+	public function canDelete($member = null)
80
+	{
81
+		return $this->Parent()->canDelete($member);
82
+	}
83
+
84
+	public function canView($member = null)
85
+	{
86
+		return $this->Parent()->canView($member);
87
+	}
88
+
89
+	public function getCMSFields()
90
+	{
91
+		$fields = parent::getCMSFields();
92
+
93
+		$fields->removeByName('ParentID');
94
+
95
+		$externalLinkField = $fields->fieldByName('Root.Main.ExternalLink');
96
+
97
+		$fields->removeByName('ExternalLink');
98
+		$fields->removeByName('InternalLinkID');
99
+		$fields->removeByName('SortOrder');
100
+		$externalLinkField->addExtraClass('noBorder');
101
+
102
+		$fields->addFieldToTab('Root.Main', CompositeField::create(
103
+			array(
104
+				TreeDropdownField::create(
105
+					'InternalLinkID',
106
+					$this->fieldLabel('InternalLinkID'),
107
+					SiteTree::class
108
+				),
109
+				$externalLinkField,
110
+				$wrap = CompositeField::create(
111
+					$extraLabel = LiteralField::create(
112
+						'NoteOverride',
113
+						sprintf('<div class="message good notice">%s</div>', _t(
114
+							__CLASS__ . '.Note',
115
+							'Note: If you specify an External Link, the Internal Link will be ignored.'
116
+						))
117
+					)
118
+				)
119
+			)
120
+		));
121
+		$fields->insertBefore(
122
+			'Name',
123
+			LiteralField::create(
124
+				'Note',
125
+				sprintf('<p>%s</p>', _t(
126
+					__CLASS__ . '.Note2',
127
+					'Use this to specify a link to a page either on this site '
128
+						. '(Internal Link) or another site (External Link).'
129
+				))
130
+			)
131
+		);
132
+
133
+		return $fields;
134
+	}
135 135
 }
Please login to merge, or discard this patch.