SynonymsSiteConfig::updateCMSFields() - Code Metrics - Inspection of "Add minimum stability dev for CWP 2.x" - silverstripe/cwp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d7fd6a...9124ff )

by Robbie

created 2017-12-15 04:17 UTC

SynonymsSiteConfig::updateCMSFields() A

↳ Parent: SynonymsSiteConfig

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	2
eloc	10
nc	2
nop	1

<?php

/**
 * Allows siteconfig to configure synonyms for fulltext search
 * Requires silverstripe/fulltextsearch 1.1.1 or above
 */
class SynonymsSiteConfig extends DataExtension {
	
	private static $db = array(

		'SearchSynonyms' => 'Text', // fulltextsearch synonyms.txt content
	);
	
	public function updateCMSFields(FieldList $fields) {
		// Don't show this field if you're not an admin
		if(!Permission::check('ADMIN')) {
			return;
		}
		
		// Search synonyms
		$fields->addFieldToTab(
			'Root.FulltextSearch',
			TextareaField::create('SearchSynonyms', _t('CwpConfig.SearchSynonyms', 'Search Synonyms'))
				->setDescription(_t(
					'CwpConfig.SearchSynonyms_Description',
					'Enter as many comma separated synonyms as you wish, where '.
					'each line represents a group of synonyms.<br /> ' .
					'You will need to run <a rel="external" target="_blank" href="dev/tasks/Solr_Configure">Solr_Configure</a> if you make any changes'
				))
		);
	}

	/**
	 * @inheritdoc
	 *
	 * @param ValidationResult $validationResult
	 */
	public function validate(ValidationResult $validationResult) {
		$validator = new SynonymValidator(array(
			'SearchSynonyms',
		));

		$validator->php(array(
			'SearchSynonyms' => $this->owner->SearchSynonyms
		));

		$errors = $validator->getErrors();

		if (is_array($errors) || $errors instanceof Traversable) {
			foreach ($errors as $error) {
				$validationResult->error($error['message']);
			}
		}
	}
}


1			<?php
2
3			/**
4			* Allows siteconfig to configure synonyms for fulltext search
5			* Requires silverstripe/fulltextsearch 1.1.1 or above
6			*/
7			class SynonymsSiteConfig extends DataExtension {
8
9			private static $db = array(
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
10			'SearchSynonyms' => 'Text', // fulltextsearch synonyms.txt content
11			);
12
13			public function updateCMSFields(FieldList $fields) {
14			// Don't show this field if you're not an admin
15			if(!Permission::check('ADMIN')) {
16			return;
17			}
18
19			// Search synonyms
20			$fields->addFieldToTab(
21			'Root.FulltextSearch',
22			TextareaField::create('SearchSynonyms', _t('CwpConfig.SearchSynonyms', 'Search Synonyms'))
23			->setDescription(_t(
24			'CwpConfig.SearchSynonyms_Description',
25			'Enter as many comma separated synonyms as you wish, where '.
26			'each line represents a group of synonyms.<br /> ' .
27			'You will need to run <a rel="external" target="_blank" href="dev/tasks/Solr_Configure">Solr_Configure</a> if you make any changes'
28			))
29			);
30			}
31
32			/**
33			* @inheritdoc
34			*
35			* @param ValidationResult $validationResult
36			*/
37			public function validate(ValidationResult $validationResult) {
38			$validator = new SynonymValidator(array(
39			'SearchSynonyms',
40			));
41
42			$validator->php(array(
43			'SearchSynonyms' => $this->owner->SearchSynonyms
44			));
45
46			$errors = $validator->getErrors();
47
48			if (is_array($errors) \|\| $errors instanceof Traversable) {
49			foreach ($errors as $error) {
50			$validationResult->error($error['message']);
51			}
52			}
53			}
54			}
55

silverstripe / cwp

Push — master ( d7fd6a...9124ff )

SynonymsSiteConfig::updateCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like