NewsPage::fieldLabels() - Code Metrics - Inspection of "Add minimum stability dev for CWP 2.x" - silverstripe/cwp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d7fd6a...9124ff )

by Robbie

created 2017-12-15 04:17 UTC

NewsPage::fieldLabels() A

↳ Parent: NewsPage

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php

class NewsPage extends DatedUpdatePage {

	private static $description = 'Describes an item of news';


	private static $default_parent = 'NewsHolderPage';


	private static $can_be_root = false;


	private static $icon = 'cwp/images/icons/sitetree_images/news.png';


	private static $singular_name = 'News Page';


	private static $plural_name = 'News Pages';


	private static $db = array(

		'Author' => 'Varchar(255)'
	);

	private static $has_one = array(

		'FeaturedImage' => 'Image'
	);

	public $pageIcon =  'images/icons/sitetree_images/news.png';

	public function fieldLabels($includerelations = true) {
		$labels = parent::fieldLabels($includerelations);
		$labels['Author'] = _t('DateUpdatePage.AuthorFieldLabel', 'Author');
		$labels['FeaturedImageID'] = _t('DateUpdatePage.FeaturedImageFieldLabel', 'Featured Image');

		return $labels;
	}

	public function getCMSFields() {
		$this->beforeUpdateCMSFields(function (FieldList $fields) {
			$fields->addFieldToTab(
				'Root.Main',
				TextField::create('Author', $this->fieldLabel('Author')),
				'Abstract'
			);

			$fields->addFieldToTab(
				'Root.Main',
				UploadField::create('FeaturedImage', $this->fieldLabel('FeaturedImageID')),
				'Abstract'
			);
		});
		return parent::getCMSFields();
	}
}

class NewsPage_Controller extends DatedUpdatePage_Controller {

}


1			<?php
2
3			class NewsPage extends DatedUpdatePage {
4
5			private static $description = 'Describes an item of news';
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$description` is not used, and could be removed. Loading history...
6
7			private static $default_parent = 'NewsHolderPage';
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$default_parent` is not used, and could be removed. Loading history...
8
9			private static $can_be_root = false;
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$can_be_root` is not used, and could be removed. Loading history...
10
11			private static $icon = 'cwp/images/icons/sitetree_images/news.png';
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$icon` is not used, and could be removed. Loading history...
12
13			private static $singular_name = 'News Page';
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$singular_name` is not used, and could be removed. Loading history...
14
15			private static $plural_name = 'News Pages';
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$plural_name` is not used, and could be removed. Loading history...
16
17			private static $db = array(
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$db` is not used, and could be removed. Loading history...
18			'Author' => 'Varchar(255)'
19			);
20
21			private static $has_one = array(
			0 ignored issues – show introduced 2017-12-14 22:02 UTC by Report Bug Copy Issue Report The private property `$has_one` is not used, and could be removed. Loading history...
22			'FeaturedImage' => 'Image'
23			);
24
25			public $pageIcon = 'images/icons/sitetree_images/news.png';
26
27			public function fieldLabels($includerelations = true) {
28			$labels = parent::fieldLabels($includerelations);
29			$labels['Author'] = _t('DateUpdatePage.AuthorFieldLabel', 'Author');
30			$labels['FeaturedImageID'] = _t('DateUpdatePage.FeaturedImageFieldLabel', 'Featured Image');
31
32			return $labels;
33			}
34
35			public function getCMSFields() {
36			$this->beforeUpdateCMSFields(function (FieldList $fields) {
37			$fields->addFieldToTab(
38			'Root.Main',
39			TextField::create('Author', $this->fieldLabel('Author')),
40			'Abstract'
41			);
42
43			$fields->addFieldToTab(
44			'Root.Main',
45			UploadField::create('FeaturedImage', $this->fieldLabel('FeaturedImageID')),
46			'Abstract'
47			);
48			});
49			return parent::getCMSFields();
50			}
51			}
52
53			class NewsPage_Controller extends DatedUpdatePage_Controller {
54
55			}
56

silverstripe / cwp

Push — master ( d7fd6a...9124ff )

NewsPage::fieldLabels() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like