NewsHolder

Complexity

Total Complexity

1

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	AllUpdates()	4	4	1

<?php

class NewsHolder extends DatedUpdateHolder {

This class seems to be duplicated in your project.

	private static $description = 'Container page for News Pages, provides news filtering and pagination';

The private property $description is not used, and could be removed.

	private static $allowed_children = array('NewsPage');

The private property $allowed_children is not used, and could be removed.

	private static $default_child = 'NewsPage';

The private property $default_child is not used, and could be removed.

	private static $update_name = 'News';

The private property $update_name is not used, and could be removed.

	private static $update_class = 'NewsPage';

The private property $update_class is not used, and could be removed.

	private static $icon = 'cwp/images/icons/sitetree_images/news_listing.png';

The private property $icon is not used, and could be removed.

	public $pageIcon =  'images/icons/sitetree_images/news_listing.png';

	private static $singular_name = 'News Holder';

The private property $singular_name is not used, and could be removed.

	private static $plural_name = 'News Holders';

The private property $plural_name is not used, and could be removed.

	/**
	 * Find all site's news items, based on some filters.
	 * Omitting parameters will prevent relevant filters from being applied. The filters are ANDed together.

The type The was not found. Maybe you did not declare it correctly or list all dependencies?

	 *
	 * @param $className The name of the class to fetch.
	 * @param $parentID The ID of the holder to extract the news items from.
	 * @param $tagID The ID of the tag to filter the news items by.
	 * @param $dateFrom The beginning of a date filter range.
	 * @param $dateTo The end of the date filter range. If empty, only one day will be searched for.
	 * @param $year Numeric value of the year to show.
	 * @param $monthNumber Numeric value of the month to show.
	 *
	 * @returns DataList | PaginatedList
	 */
	public static function AllUpdates($className = 'NewsPage', $parentID = null, $tagID = null, $dateFrom = null,
			$dateTo = null, $year = null, $monthNumber = null) {

		return parent::AllUpdates($className, $parentID, $tagID, $dateFrom, $dateTo, $year, $monthNumber)->Sort('Date', 'DESC');
	}
}

class NewsHolder_Controller extends DatedUpdateHolder_Controller {
	private static $allowed_actions = array(

The private property $allowed_actions is not used, and could be removed.

		'rss',
		'atom'
	);

	public function rss() {

This method seems to be duplicated in your project.

		$rss = new RSSFeed(
			$this->Updates()->sort('Created DESC')->limit(20),
			$this->Link('rss'),
			$this->getSubscriptionTitle()
		);
		$rss->setTemplate('NewsHolder_rss');
		return $rss->outputToBrowser();
	}

	public function atom() {

This method seems to be duplicated in your project.

		$atom = new CwpAtomFeed(
			$this->Updates()->sort('Created DESC')->limit(20),
			$this->Link('atom'),
			$this->getSubscriptionTitle()
		);
		$atom->setTemplate('NewsHolder_atom');
		return $atom->outputToBrowser();
	}
}