EventPage

Complexity

Total Complexity

10

Size/Duplication

Total Lines	79
Duplicated Lines	3.8 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	NiceLocation()	0	2	1
A	fieldLabels()	0	7	1
B	populateDefaults()	3	14	7
B	getCMSFields()	0	25	1

<?php

class EventPage extends DatedUpdatePage {

	private static $description = 'Describes an event occurring on a specific date.';

The private property $description is not used, and could be removed.

	static $default_parent = 'EventHolder';

	static $can_be_root = false;

	static $icon = 'cwp/images/icons/sitetree_images/event_page.png';

	public $pageIcon =  'images/icons/sitetree_images/event_page.png';

	private static $singular_name = 'Event Page';

The private property $singular_name is not used, and could be removed.

	private static $plural_name = 'Event Pages';

The private property $plural_name is not used, and could be removed.

	static $db = array(
		'StartTime' => 'Time',
		'EndTime' => 'Time',
		'Location' => 'Text'
	);

	public function fieldLabels($includerelations = true) {
		$labels = parent::fieldLabels($includerelations);
		$labels['StartTime'] = _t('DateUpdatePage.StartTimeFieldLabel', 'Start Time');
		$labels['EndTime'] = _t('DateUpdatePage.EndTimeFieldLabel', 'End Time');
		$labels['Location'] = _t('DateUpdatePage.LocationFieldLabel', 'Location');

		return $labels;
	}

	/**
	 * Add the default for the Date being the current day.
	 */
	public function populateDefaults() {
		if(!isset($this->Date) || $this->Date === null) {

This code seems to be duplicated across your project.

			$this->Date = SS_Datetime::now()->Format('Y-m-d');

The property Date does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		}

		if(!isset($this->StartTime) || $this->StartTime === null) {
			$this->StartTime = '09:00:00';

The property StartTime does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		}

		if(!isset($this->EndTime) || $this->EndTime === null) {
			$this->EndTime = '17:00:00';

The property EndTime does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		}

		parent::populateDefaults();
	}

	public function getCMSFields() {
		$this->beforeUpdateCMSFields(function (FieldList $fields) {
			$fields->removeByName('Date');

			$dateTimeFields = array();

			$dateTimeFields[] = $dateField = DateField::create('Date', 'Date');
			$dateField->setConfig('showcalendar', true);
			$dateField->setConfig('dateformat', Member::currentUser()->getDateFormat());

			$dateTimeFields[] = $startTimeField = TimeField::create('StartTime', '  ' . $this->fieldLabel('StartTime'));
			$dateTimeFields[] = $endTimeField = TimeField::create('EndTime', $this->fieldLabel('EndTime'));
			// Would like to do this, but the width of the form field doesn't scale based on the time
			// format. OS ticket raised: http://open.silverstripe.org/ticket/8260
			//$startTimeField->setConfig('timeformat', Member::currentUser()->getTimeFormat());
			//$endTimeField->setConfig('timeformat', Member::currentUser()->getTimeFormat());
			$startTimeField->setConfig('timeformat', 'h:ma');
			$endTimeField->setConfig('timeformat', 'h:ma');

			$fields->addfieldToTab('Root.Main', $dateTimeField = new FieldGroup('Date and time', $dateTimeFields), 'Abstract');

			$fields->addfieldToTab('Root.Main', $locationField = TextareaField::create('Location', $this->fieldLabel('Location')), 'Abstract');
			$locationField->setRows(4);
		});
		return parent::getCMSFields();
	}

	public function NiceLocation() {
		return (nl2br(Convert::raw2xml($this->Location), true));

It seems like Convert::raw2xml($this->Location) can also be of type array; however, parameter $string of nl2br() does only seem to accept string, maybe add an additional type check?

	}
}

class EventPage_Controller extends Page_Controller {

The type Page_Controller was not found. Maybe you did not declare it correctly or list all dependencies?

}