Conditions | 1 |
Paths | 1 |
Total Lines | 96 |
Code Lines | 71 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
65 | public function getCMSFields() |
||
66 | { |
||
67 | $this->beforeUpdateCMSFields(function (FieldList $fields) { |
||
68 | // Main Content tab |
||
69 | $fields->addFieldToTab( |
||
70 | 'Root.Main', |
||
71 | TreeDropdownField::create( |
||
72 | 'LearnMorePageID', |
||
73 | _t(__CLASS__ . '.LearnMoreLink', 'Page to link the "Learn More" button to:'), |
||
74 | SiteTree::class |
||
75 | ), |
||
76 | 'Metadata' |
||
77 | ); |
||
78 | |||
79 | $gridField = GridField::create( |
||
80 | 'Quicklinks', |
||
81 | 'Quicklinks', |
||
82 | $this->Quicklinks(), |
||
83 | GridFieldConfig_RelationEditor::create() |
||
84 | ); |
||
85 | $gridConfig = $gridField->getConfig(); |
||
86 | $gridConfig->getComponentByType(GridFieldAddNewButton::class)->setButtonName( |
||
87 | _t(__CLASS__ . '.AddNewButton', 'Add new') |
||
88 | ); |
||
89 | |||
90 | $injector = Injector::inst(); |
||
91 | |||
92 | $gridConfig->removeComponentsByType(GridFieldAddExistingAutocompleter::class); |
||
93 | $gridConfig->removeComponentsByType(GridFieldDeleteAction::class); |
||
94 | $gridConfig->addComponent($injector->create(GridFieldDeleteAction::class)); |
||
95 | $gridConfig->addComponent($injector->create(GridFieldOrderableRows::class, 'SortOrder')); |
||
96 | $gridField->setModelClass(Quicklink::class); |
||
97 | |||
98 | $fields->addFieldToTab('Root.Quicklinks', $gridField); |
||
99 | |||
100 | $fields->removeByName('Import'); |
||
101 | |||
102 | $fields->addFieldToTab( |
||
103 | 'Root.Features', |
||
104 | ToggleCompositeField::create( |
||
105 | 'FeatureOne', |
||
106 | _t(__CLASS__ . '.FeatureOne', 'Feature One'), |
||
107 | array( |
||
108 | TextField::create('FeatureOneTitle', _t(__CLASS__ . '.Title', 'Title')), |
||
109 | $dropdownField = DropdownField::create( |
||
110 | 'FeatureOneCategory', |
||
111 | _t(__CLASS__ . '.FeatureCategoryDropdown', 'Category icon'), |
||
112 | singleton(BaseHomePage::class)->dbObject('FeatureOneCategory')->enumValues() |
||
113 | ), |
||
114 | HTMLEditorField::create( |
||
115 | 'FeatureOneContent', |
||
116 | _t(__CLASS__ . '.FeatureContentFieldLabel', 'Content') |
||
117 | ), |
||
118 | TextField::create( |
||
119 | 'FeatureOneButtonText', |
||
120 | _t(__CLASS__ . '.FeatureButtonText', 'Button text') |
||
121 | ), |
||
122 | TreeDropdownField::create( |
||
123 | 'FeatureOneLinkID', |
||
124 | _t(__CLASS__ . '.FeatureLink', 'Page to link to'), |
||
125 | SiteTree::class |
||
126 | )->setDescription(_t(__CLASS__ . '.ButtonTextRequired', 'Button text must be filled in')) |
||
127 | ) |
||
128 | )->setHeadingLevel(3) |
||
129 | ); |
||
130 | $dropdownField->setEmptyString('none'); |
||
131 | |||
132 | $fields->addFieldToTab('Root.Features', ToggleCompositeField::create( |
||
133 | 'FeatureTwo', |
||
134 | _t(__CLASS__ . '.FeatureTwo', 'Feature Two'), |
||
135 | array( |
||
136 | TextField::create('FeatureTwoTitle', _t(__CLASS__ . '.Title', 'Title')), |
||
137 | $dropdownField = DropdownField::create( |
||
138 | 'FeatureTwoCategory', |
||
139 | _t(__CLASS__ . '.FeatureCategoryDropdown', 'Category icon'), |
||
140 | singleton(BaseHomePage::class)->dbObject('FeatureTwoCategory')->enumValues() |
||
141 | ), |
||
142 | HTMLEditorField::create( |
||
143 | 'FeatureTwoContent', |
||
144 | _t(__CLASS__ . '.FeatureContentFieldLabel', 'Content') |
||
145 | ), |
||
146 | TextField::create( |
||
147 | 'FeatureTwoButtonText', |
||
148 | _t(__CLASS__ . '.FeatureButtonText', 'Button text') |
||
149 | ), |
||
150 | TreeDropdownField::create( |
||
151 | 'FeatureTwoLinkID', |
||
152 | _t(__CLASS__ . '.FeatureLink', 'Page to link to'), |
||
153 | SiteTree::class |
||
154 | )->setDescription(_t(__CLASS__ . '.ButtonTextRequired', 'Button text must be filled in')) |
||
155 | ) |
||
156 | )->setHeadingLevel(3)); |
||
157 | $dropdownField->setEmptyString('none'); |
||
158 | }); |
||
159 | |||
160 | return parent::getCMSFields(); |
||
161 | } |
||
163 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths