CWP\CWP\PageTypes\EventPage

Complexity

Total Complexity

10

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	NiceLocation()	0	3	1
B	populateDefaults()	0	15	7
A	getCMSFields()	0	21	1
A	fieldLabels()	0	8	1

<?php

namespace CWP\CWP\PageTypes;

use SilverStripe\Core\Convert;
use SilverStripe\Forms\DateField;
use SilverStripe\Forms\FieldGroup;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\TextareaField;
use SilverStripe\Forms\TimeField;
use SilverStripe\ORM\FieldType\DBDatetime;

class EventPage extends DatedUpdatePage
{
    private static $description = 'Describes an event occurring on a specific date.';

The private property $description is not used, and could be removed.

    private static $default_parent = EventHolder::class;

The private property $default_parent is not used, and could be removed.

    private static $can_be_root = false;

The private property $can_be_root is not used, and could be removed.

    private static $icon_class = 'font-icon-p-event';

The private property $icon_class is not used, and could be removed.

    private static $singular_name = 'Event Page';

The private property $singular_name is not used, and could be removed.

    private static $plural_name = 'Event Pages';

The private property $plural_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'StartTime' => 'Time',
        'EndTime' => 'Time',
        'Location' => 'Text',
    ];

    private static $table_name = 'EventPage';

The private property $table_name is not used, and could be removed.

    public function fieldLabels($includerelations = true)
    {
        $labels = parent::fieldLabels($includerelations);
        $labels['StartTime'] = _t('CWP\\CWP\\PageTypes\\DateUpdatePage.StartTimeFieldLabel', 'Start Time');
        $labels['EndTime'] = _t('CWP\\CWP\\PageTypes\\DateUpdatePage.EndTimeFieldLabel', 'End Time');
        $labels['Location'] = _t('CWP\\CWP\\PageTypes\\DateUpdatePage.LocationFieldLabel', 'Location');

        return $labels;
    }

    /**
     * Add the default for the Date being the current day.
     */
    public function populateDefaults()
    {
        if (!isset($this->Date) || $this->Date === null) {
            $this->Date = DBDatetime::now()->Format('y-MM-dd');

The property Date does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        if (!isset($this->StartTime) || $this->StartTime === null) {
            $this->StartTime = '09:00:00';

The property StartTime does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        if (!isset($this->EndTime) || $this->EndTime === null) {
            $this->EndTime = '17:00:00';

The property EndTime does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        parent::populateDefaults();
    }

    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->removeByName('Date');

            $dateTimeFields = array();

            $dateTimeFields[] = $dateField = DateField::create('Date', 'Date');

The assignment to $dateField is dead and can be removed.

            $dateTimeFields[] = $startTimeField = TimeField::create(

The assignment to $startTimeField is dead and can be removed.

                'StartTime',
                $this->fieldLabel('StartTime')
            );
            $dateTimeFields[] = $endTimeField = TimeField::create('EndTime', $this->fieldLabel('EndTime'));

The assignment to $endTimeField is dead and can be removed.

            $fields->addFieldsToTab('Root.Main', [
                $dateTimeField = FieldGroup::create('Date and time', $dateTimeFields),

The assignment to $dateTimeField is dead and can be removed.

                $locationField = TextareaField::create('Location', $this->fieldLabel('Location'))
            ], 'Abstract');
            $locationField->setRows(4);
        });
        return parent::getCMSFields();
    }

    public function NiceLocation()
    {
        return nl2br(Convert::raw2xml($this->Location), true);

It seems like SilverStripe\Core\Convert::raw2xml($this->Location) can also be of type array and array; however, parameter $string of nl2br() does only seem to accept string, maybe add an additional type check?

    }
}