Completed
Pull Request — master (#7)
by Robbie
04:56 queued 30s
created
tests/Control/InitialisationMiddlewareTest.php 2 patches
Indentation   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -10,91 +10,91 @@
 block discarded – undo
10 10
 
11 11
 class InitialisationMiddlewareTest extends SapphireTest
12 12
 {
13
-    /**
14
-     * @var HTTPRequest
15
-     */
16
-    protected $request;
17
-
18
-    /**
19
-     * @var InitialisationMiddleware
20
-     */
21
-    protected $middleware;
22
-
23
-    protected function setUp()
24
-    {
25
-        parent::setUp();
26
-
27
-        $this->request = new HTTPRequest('GET', '/');
28
-        $this->middleware = new InitialisationMiddleware();
29
-
30
-        Environment::setEnv('SS_OUTBOUND_PROXY', '');
31
-        Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '');
32
-        Environment::setEnv('NO_PROXY', '');
33
-    }
34
-
35
-    public function testDoNotConfigureProxyIfNoEnvironmentVarsAreSet()
36
-    {
37
-        $this->runMiddleware();
38
-
39
-        $this->assertEmpty(
40
-            Environment::getEnv('http_proxy'),
41
-            'Proxy information is not set if no outbound proxy is configured'
42
-        );
43
-    }
44
-
45
-    public function testConfigureEgressProxyWhenVarsAreSet()
46
-    {
47
-        Environment::setEnv('SS_OUTBOUND_PROXY', 'http://example.com');
48
-        Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '8024');
49
-
50
-        $this->runMiddleware();
51
-
52
-        $this->assertEquals(
53
-            'http://example.com:8024',
54
-            Environment::getEnv('http_proxy'),
55
-            'Proxy is configured with proxy and port'
56
-        );
57
-    }
58
-
59
-    public function testDoNotConfigureProxyDomainExclusionsWhenNoneAreDefined()
60
-    {
61
-        Config::modify()->remove(InitialisationMiddleware::class, 'egress_proxy_exclude_domains');
62
-
63
-        $this->runMiddleware();
64
-
65
-        $this->assertSame(
66
-            '',
67
-            Environment::getEnv('NO_PROXY'),
68
-            'No domain exclusions are set when none are defined'
69
-        );
70
-    }
71
-
72
-    public function testConfigureEgressProxyDomainExclusions()
73
-    {
74
-        Config::modify()->set(
75
-            InitialisationMiddleware::class,
76
-            'egress_proxy_exclude_domains',
77
-            'example.com'
78
-        );
79
-
80
-        Environment::setEnv('NO_PROXY', 'foo.com,bar.com');
81
-
82
-        $this->runMiddleware();
83
-
84
-        $this->assertSame(
85
-            'foo.com,bar.com,example.com',
86
-            Environment::getEnv('NO_PROXY'),
87
-            'Domain exclusions are combined with existing values and configuration settings'
88
-        );
89
-    }
90
-
91
-    /**
92
-     * Runs the middleware with a stubbed delegate
93
-     */
94
-    protected function runMiddleware()
95
-    {
96
-        $this->middleware->process($this->request, function () {
97
-            // no op
98
-        });
99
-    }
13
+	/**
14
+	 * @var HTTPRequest
15
+	 */
16
+	protected $request;
17
+
18
+	/**
19
+	 * @var InitialisationMiddleware
20
+	 */
21
+	protected $middleware;
22
+
23
+	protected function setUp()
24
+	{
25
+		parent::setUp();
26
+
27
+		$this->request = new HTTPRequest('GET', '/');
28
+		$this->middleware = new InitialisationMiddleware();
29
+
30
+		Environment::setEnv('SS_OUTBOUND_PROXY', '');
31
+		Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '');
32
+		Environment::setEnv('NO_PROXY', '');
33
+	}
34
+
35
+	public function testDoNotConfigureProxyIfNoEnvironmentVarsAreSet()
36
+	{
37
+		$this->runMiddleware();
38
+
39
+		$this->assertEmpty(
40
+			Environment::getEnv('http_proxy'),
41
+			'Proxy information is not set if no outbound proxy is configured'
42
+		);
43
+	}
44
+
45
+	public function testConfigureEgressProxyWhenVarsAreSet()
46
+	{
47
+		Environment::setEnv('SS_OUTBOUND_PROXY', 'http://example.com');
48
+		Environment::setEnv('SS_OUTBOUND_PROXY_PORT', '8024');
49
+
50
+		$this->runMiddleware();
51
+
52
+		$this->assertEquals(
53
+			'http://example.com:8024',
54
+			Environment::getEnv('http_proxy'),
55
+			'Proxy is configured with proxy and port'
56
+		);
57
+	}
58
+
59
+	public function testDoNotConfigureProxyDomainExclusionsWhenNoneAreDefined()
60
+	{
61
+		Config::modify()->remove(InitialisationMiddleware::class, 'egress_proxy_exclude_domains');
62
+
63
+		$this->runMiddleware();
64
+
65
+		$this->assertSame(
66
+			'',
67
+			Environment::getEnv('NO_PROXY'),
68
+			'No domain exclusions are set when none are defined'
69
+		);
70
+	}
71
+
72
+	public function testConfigureEgressProxyDomainExclusions()
73
+	{
74
+		Config::modify()->set(
75
+			InitialisationMiddleware::class,
76
+			'egress_proxy_exclude_domains',
77
+			'example.com'
78
+		);
79
+
80
+		Environment::setEnv('NO_PROXY', 'foo.com,bar.com');
81
+
82
+		$this->runMiddleware();
83
+
84
+		$this->assertSame(
85
+			'foo.com,bar.com,example.com',
86
+			Environment::getEnv('NO_PROXY'),
87
+			'Domain exclusions are combined with existing values and configuration settings'
88
+		);
89
+	}
90
+
91
+	/**
92
+	 * Runs the middleware with a stubbed delegate
93
+	 */
94
+	protected function runMiddleware()
95
+	{
96
+		$this->middleware->process($this->request, function () {
97
+			// no op
98
+		});
99
+	}
100 100
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@
 block discarded – undo
93 93
      */
94 94
     protected function runMiddleware()
95 95
     {
96
-        $this->middleware->process($this->request, function () {
96
+        $this->middleware->process($this->request, function() {
97 97
             // no op
98 98
         });
99 99
     }
Please login to merge, or discard this patch.