CwpControllerExtensionTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	132
Duplicated Lines	32.58 %

Importance

Changes	3
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testRequiresLoginForNonTest()	16	16	1
A	testRequiresLoginForTest()	22	22	2
B	testRedirectsSSLToDomain()	0	26	1
A	testRedirectsSSLToCurrentDomain()	0	23	1
B	testRequiresLoginForLiveWhenEnabled()	0	32	2

<?php

class CwpControllerExtensionTest extends SapphireTest {

	function testRedirectsSSLToDomain() {

It is generally recommended to explicitly declare the visibility for methods.

		Session::set("loggedInAs", null);

		$ctrl = new Controller();
		$req = new SS_HTTPRequest('GET', '/');
		$dataModel = new DataModel();

		Config::inst()->nest();

		$directorClass = $this->getMockClass('Director', array('forceSSL', 'is_https'));
		Injector::inst()->registerNamedService('Director', new $directorClass);

The function Injector::registerNamedService() has been deprecated: since 4.0

		// Expecting this to call forceSSL to forcedomain.org.
		$directorClass::staticExpects($this->any())
			->method('is_https')
			->will($this->returnValue(false));
		$directorClass::staticExpects($this->once())
			->method('forceSSL')
			->with($this->anything(), $this->equalTo('forcedomain.org'));

		Config::inst()->update('CwpControllerExtension', 'ssl_redirection_enabled', true);
		Config::inst()->update('CwpControllerExtension', 'ssl_redirection_force_domain', 'forcedomain.org');
		$response = $ctrl->handleRequest($req, $dataModel);

The assignment to $response is dead and can be removed.

		Injector::inst()->unregisterAllObjects();
		Config::inst()->unnest();
	}

	function testRedirectsSSLToCurrentDomain() {

It is generally recommended to explicitly declare the visibility for methods.

		Session::set("loggedInAs", null);

		$ctrl = new Controller();
		$req = new SS_HTTPRequest('GET', '/');
		$dataModel = new DataModel();

		$directorClass = $this->getMockClass('Director', array('forceSSL', 'is_https'));
		Injector::inst()->registerNamedService('Director', new $directorClass);

The function Injector::registerNamedService() has been deprecated: since 4.0

		// Expecting this to call forceSSL to current domain.
		$directorClass::staticExpects($this->any())
			->method('is_https')
			->will($this->returnValue(false));
		$directorClass::staticExpects($this->once())
			->method('forceSSL')
			->with($this->anything());

		Config::inst()->update('CwpControllerExtension', 'ssl_redirection_enabled', true);
		Config::inst()->update('CwpControllerExtension', 'ssl_redirection_force_domain', false);
		$response = $ctrl->handleRequest($req, $dataModel);

The assignment to $response is dead and can be removed.

		Injector::inst()->unregisterAllObjects();
	}

	function testRequiresLoginForTest() {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

		Session::set("loggedInAs", null);

		$ctrl = new Controller();
		$req = new SS_HTTPRequest('GET', '/');
		$dataModel = new DataModel();

		$directorClass = $this->getMockClass('Director', array('isTest'));
		Injector::inst()->registerNamedService('Director', new $directorClass);

The function Injector::registerNamedService() has been deprecated: since 4.0

		$directorClass::staticExpects($this->any())
			->method('isTest')
			->will($this->returnValue(true));

		try {
			$response = $ctrl->handleRequest($req, $dataModel);

The assignment to $response is dead and can be removed.

		} catch (Exception $e) {
			$this->assertEquals($e->getResponse()->getStatusCode(), '401', 'Forces BasicAuth on test');

The method getResponse() does not exist on Exception. It seems like you code against a sub-type of Exception such as SS_HTTPResponse_Exception or Zend_Exception.

			// We need to pop manually, since throwing an SS_HTTPResponse_Exception in onBeforeInit hijacks
			// the normal Controller control flow and confuses TestRunner (as they share global controller stack).
			$ctrl->popCurrent();
		}

	}

	function testRequiresLoginForNonTest() {

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

		Session::set("loggedInAs", null);

		$ctrl = new Controller();
		$req = new SS_HTTPRequest('GET', '/');
		$dataModel = new DataModel();

		$directorClass = $this->getMockClass('Director', array('isTest'));
		Injector::inst()->registerNamedService('Director', new $directorClass);

The function Injector::registerNamedService() has been deprecated: since 4.0

		$directorClass::staticExpects($this->any())
			->method('isTest')
			->will($this->returnValue(false));

		$response = $ctrl->handleRequest($req, $dataModel);
		$this->assertEquals($response->getStatusCode(), '200', 'Does not force BasicAuth on live');

	}

	function testRequiresLoginForLiveWhenEnabled() {

It is generally recommended to explicitly declare the visibility for methods.

		Session::set("loggedInAs", null);

		$ctrl = new Controller();
		$req = new SS_HTTPRequest('GET', '/');
		$dataModel = new DataModel();

		Config::inst()->nest();

		Config::inst()->update('CwpControllerExtension', 'live_basicauth_enabled', true);
		$directorClass = $this->getMockClass('Director', array('isTest', 'isLive'));
		Injector::inst()->registerNamedService('Director', new $directorClass);

The function Injector::registerNamedService() has been deprecated: since 4.0

		$directorClass::staticExpects($this->any())
			->method('isTest')
			->will($this->returnValue(false));

		$directorClass::staticExpects($this->any())
			->method('isLive')
			->will($this->returnValue(true));

		try {
			$response = $ctrl->handleRequest($req, $dataModel);

The assignment to $response is dead and can be removed.

		} catch (Exception $e) {
			$this->assertEquals($e->getResponse()->getStatusCode(), '401', 'Forces BasicAuth on live (optionally)');

			// We need to pop manually, since throwing an SS_HTTPResponse_Exception in onBeforeInit hijacks
			// the normal Controller control flow and confuses TestRunner (as they share global controller stack).
			$ctrl->popCurrent();
		}

		Config::inst()->unnest();
	}

}