RichLinksExtension::RichLinks() - Code Metrics - silverstripe/cwp-core - Measure and Improve Code Quality continuously with Scrutinizer

RichLinksExtension::RichLinks() A
last analyzed 2020-03-03 04:28 UTC

↳ Parent: RichLinksExtension

Complexity

Conditions	3
Paths	3

Size

Total Lines	34
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	17
c	1
b	0
f	0
nc	3
nop	0
dl	0
loc	34
rs	9.7

<?php

namespace CWP\Core\Extension;

use SilverStripe\Core\Extension;
use SilverStripe\ORM\DataObject;
use SilverStripe\Assets\File;

/**
 * Adds capability to augment links with extra attributes and meta information.
 *
 * Usage in the templates:
 *      $Content.RichLinks
 *
 * Note: will only work with content produced by HtmlEditorField.
 */
class RichLinksExtension extends Extension
{

    /**
     * @var array
     */
    private static $casting = [

        'RichLinks' => 'HTMLText'
    ];

    /**
     * @return string
     */
    public function RichLinks()
    {
        // Note:
        // Assume we can use Regexes because the link will always be formatted
        // in the same way coming from the CMS.

        $content = $this->owner->value;

        // Find all file links for processing.
        preg_match_all('/<a.*href="\[file_link,id=([0-9]+)\].*".*>.*<\/a>/U', $content, $matches);

        // Attach the file type and size to each of the links.
        for ($i = 0; $i < count($matches[0]); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $file = DataObject::get_by_id(File::class, $matches[1][$i]);
            if ($file) {
                $size = $file->getSize();
                $ext = strtoupper($file->getExtension());
                // Replace the closing </a> tag with the size span (and reattach the closing tag).
                $newLink = substr($matches[0][$i], 0, strlen($matches[0][$i]) - 4)
                    . "<span class='fileExt'> [$ext, $size]</span></a>";
                $content = str_replace($matches[0][$i], $newLink, $content);
            }
        }

        // Inject extra attributes into the external links.
        $pattern = '/(<a.*)(href=\"https?:\/\/[^\"]*\"[^>]*>.*)(<\/a>)/iU';
        $replacement = sprintf(
            '$1class="external" rel="external" title="%s" $2<span class="nonvisual-indicator">(%s)</span>$3',
            _t(__CLASS__ . '.OpenLinkTitle', 'Open external link'),
            _t(__CLASS__ . '.ExternalLink', 'external link')
        );
        $content = preg_replace($pattern, $replacement, $content, -1);

        return $content;
    }
}


1			<?php
2
3			namespace CWP\Core\Extension;
4
5			use SilverStripe\Core\Extension;
6			use SilverStripe\ORM\DataObject;
7			use SilverStripe\Assets\File;
8
9			/**
10			* Adds capability to augment links with extra attributes and meta information.
11			*
12			* Usage in the templates:
13			* $Content.RichLinks
14			*
15			* Note: will only work with content produced by HtmlEditorField.
16			*/
17			class RichLinksExtension extends Extension
18			{
19
20			/**
21			* @var array
22			*/
23			private static $casting = [
			0 ignored issues – show introduced 2017-12-20 00:24 UTC by Report Bug Copy Issue Report The private property `$casting` is not used, and could be removed. Loading history...
24			'RichLinks' => 'HTMLText'
25			];
26
27			/**
28			* @return string
29			*/
30			public function RichLinks()
31			{
32			// Note:
33			// Assume we can use Regexes because the link will always be formatted
34			// in the same way coming from the CMS.
35
36			$content = $this->owner->value;
37
38			// Find all file links for processing.
39			preg_match_all('/<a.href="\[file_link,id=([0-9]+)\].".>.<\/a>/U', $content, $matches);
40
41			// Attach the file type and size to each of the links.
42			for ($i = 0; $i < count($matches[0]); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2017-12-14 22:01 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
43			$file = DataObject::get_by_id(File::class, $matches[1][$i]);
44			if ($file) {
45			$size = $file->getSize();
46			$ext = strtoupper($file->getExtension());
47			// Replace the closing </a> tag with the size span (and reattach the closing tag).
48			$newLink = substr($matches[0][$i], 0, strlen($matches[0][$i]) - 4)
49			. "<span class='fileExt'> [$ext, $size]</span></a>";
50			$content = str_replace($matches[0][$i], $newLink, $content);
51			}
52			}
53
54			// Inject extra attributes into the external links.
55			$pattern = '/(<a.)(href=\"https?:\/\/[^\"]\"[^>]>.)(<\/a>)/iU';
56			$replacement = sprintf(
57			'$1class="external" rel="external" title="%s" $2<span class="nonvisual-indicator">(%s)</span>$3',
58			_t(__CLASS__ . '.OpenLinkTitle', 'Open external link'),
59			_t(__CLASS__ . '.ExternalLink', 'external link')
60			);
61			$content = preg_replace($pattern, $replacement, $content, -1);
62
63			return $content;
64			}
65			}
66

silverstripe / cwp-core

RichLinksExtension::RichLinks() A last analyzed 2020-03-03 04:28 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RichLinksExtension::RichLinks() A
last analyzed 2020-03-03 04:28 UTC