silverstripe / comment-notifications

tests/Model/CommentNotifiableTestDataObject.php

<?php

namespace SilverStripe\CommentNotifications\Tests\Model;

use SilverStripe\ORM\DataObject;
use SilverStripe\Dev\TestOnly;
use SilverStripe\Control\Controller;
use SilverStripe\Control\Director;
use SilverStripe\CommentNotifications\Extensions\CommentNotifiable;
use SilverStripe\Comments\Extensions\CommentsExtension;

class CommentNotifiableTestDataObject extends DataObject implements TestOnly
{
    private static $db = [

The private property $db is not used, and could be removed.

        "Title" => "Varchar(255)",
        "URLSegment" => "Varchar(255)",
    ];

    private static $has_one = [

The private property $has_one is not used, and could be removed.

        'Author' => 'SilverStripe\Security\Member'
    ];

    private static $extensions = [

The private property $extensions is not used, and could be removed.

        CommentNotifiable::class,
        CommentsExtension::class
    ];

    private static $table_name = 'CommentNotifiableTestDataObject';

The private property $table_name is not used, and could be removed.

    public function updateNotificationRecipients(&$list, $comment)

The parameter $comment is not used and could be removed.

    {
        $author = $this->Author();

The method Author() does not exist on SilverStripe\CommentNotifications\Tests\Model\CommentNotifiableTestDataObject. Since you implemented __call, consider adding a @method annotation.

        if ($author && $author->exists()) {
            $list[] = $author->Email;
        }
    }

    public function Link($action = false)

The parameter $action is not used and could be removed.

    {
        return Controller::join_links(
            Director::baseURL(),
            $this->URLSegment

The property URLSegment does not exist on SilverStripe\CommentNotifications\Tests\Model\CommentNotifiableTestDataObject. Since you implemented __get, consider adding a @property annotation.

        );
    }
}