AddonsController

Complexity

Total Complexity

30

Size/Duplication

Total Lines	207
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	25

Importance

Changes	2
Bugs	1	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	3	1
A	setElasticaService()	0	3	1
A	addon()	0	11	2
A	vendor()	0	10	2
A	Title()	0	3	1
A	Link()	0	7	2
A	ListView()	0	8	2
F	Addons()	0	75	17
B	AddonsSearchForm()	0	37	1
A	rss()	0	15	1

<?php

use Elastica\Query;
use Elastica\Query\Match;
use SilverStripe\Elastica\ElasticaService;
use SilverStripe\Elastica\ResultList;

/**
 * Lists and searches add-ons.
 */
class AddonsController extends SiteController {

	public static $url_handlers = array(
		'rss' => 'rss',
		'$Vendor!/$Name!' => 'addon',
		'$Vendor!' => 'vendor',
	);

	public static $allowed_actions = array(
		'index',
		'addon',
		'vendor',
		'rss',
	);

	public static $dependencies = array(
		'ElasticaService' => '%$ElasticaService'
	);

	/**
	 * @var \SilverStripe\Elastica\ElasticaService
	 */
	private $elastica;

	public function index() {
		return $this->renderWith(array('Addons', 'Page'));
	}

	public function setElasticaService(ElasticaService $elastica) {
		$this->elastica = $elastica;
	}

	public function addon($request) {
		$vendor = $request->param('Vendor');
		$name = $request->param('Name');
		$addon = Addon::get()->filter('Name', "$vendor/$name")->first();

		if (!$addon) {
			$this->httpError(404);
		}

		return new AddonController($this, $addon);
	}

	public function vendor($request) {
		$name = $request->param('Vendor');
		$vendor = AddonVendor::get()->filter('Name', $name)->first();

		if (!$vendor) {
			$this->httpError(404);
		}

		return new VendorController($this, $vendor);
	}

	public function Title() {
		return 'Add-ons';
	}

	public function Link($slug = null) {
		if($slug){
			return Controller::join_links(Director::baseURL(), 'add-ons', $slug);
		} else {
			return Controller::join_links(Director::baseURL(), 'add-ons');
		}
	}

	public function ListView() {
		$view = $this->request->getVar('view');
		if($view) {
			return $view;
		} else {
			return 'list';
		}
	}

	public function Addons() {
		$list = Addon::get();

		$search = $this->request->getVar('search');
		$type = $this->request->getVar('type');
		$compat = $this->request->getVar('compatibility');
		$tags = $this->request->getVar('tags');
		$sort = $this->request->getVar('sort');
		$view = $this->request->getVar('view');

		if (!$view) {
			$view = 'list';

$view is not used, you could remove the assignment.

		}

		if (!in_array($sort, array('name', 'downloads', 'newest'))) {
			$sort = null;
		}

		// Proxy out a search to elastic if any parameters are set.
		if ($search || $type || $compat || $tags) {

			$bool = new Query\BoolQuery();

			$query = new Query();
			$query->setQuery($bool);
			$query->setSize(count($list));


			if ($search) {
				$match = new Match();
				$match->setField('_all', $search);

				$bool->addMust($match);
			}

			if ($type) {
				$bool->addMust(new Query\Term(array('type' => $type)));
			}

			if ($compat) {
				$bool->addMust(new Query\Terms('compatibility', (array) $compat));
			}

			if ($tags) {
				$bool->addMust(new Query\Terms('tag', (array) $tags));
			}

			$list = new ResultList($this->elastica->getIndex(), $query);

			if ($sort) {
				$ids = $list->column('ID');

				if ($ids) {

The expression $ids of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

					$list = Addon::get()->byIDs($ids);
				} else {
					$list = new ArrayList();
				}
			} else {
				$list = $list->toArrayList();
			}
		} else {
			if (!$sort) $sort = 'downloads';
		}

		switch ($sort) {
			case 'name': $list = $list->sort('Name'); break;
			case 'newest': $list = $list->sort('Released', 'DESC'); break;
			case 'downloads': $list = $list->sort('Downloads', 'DESC'); break;
		}

		$list = new PaginatedList($list, $this->request);

$this->request is of type object<SS_HTTPRequest>, but the function expects a array.

		$list->setPageLength(16);

		return $list;
	}

	public function AddonsSearchForm() {
		$form = new Form(
			$this,
			'AddonsSearchForm',
			new FieldList(array(
				TextField::create('search', 'Search for')
					->setValue($this->request->getVar('search'))
					->addExtraClass('input-block-level'),
				DropdownField::create('sort', 'Sort by')
					->setSource(array(
						'name' => 'Name',
						'downloads' => 'Most downloaded',
						'newest' => 'Newest'
					))
					->setEmptyString('Best match')
					->setValue($this->request->getVar('sort'))
					->addExtraClass('input-block-level'),
				DropdownField::create('type', 'Add-on type')
					->setSource(array(
						'module' => 'Modules',
						'theme' => 'Themes'
					))
					->setEmptyString('Modules and themes')
					->setValue($this->request->getVar('type'))
					->addExtraClass('input-block-level'),
				CheckboxSetField::create('compatibility', 'Compatible SilverStripe versions')
					->setSource(SilverStripeVersion::get()->map('Name', 'Name'))

\SilverStripeVersion::get()->map('Name', 'Name') is of type object<SS_Map>, but the function expects a array.

					->setValue($this->request->getVar('compatibility'))
					->setTemplate('AddonsSearchCheckboxSetField')
			)),
			new FieldList()
		);

		return $form
			->setFormMethod('GET')
			->setFormAction($this->Link());
	}

	public function rss($request, $limit = 10) {

The parameter $request is not used and could be removed.

		$addons = Addon::get()
			->sort('Released', 'DESC')
			->limit($limit);

		$rss = new RSSFeed(
			$addons, 
			$this->Link(), 
			"Newest addons on addons.silverstripe.org",
			null,
			'RSSTitle'
		);

    	return $rss->outputToBrowser();
	}

}