BuildAddonJob::process() - Code Metrics - Inspection of "FIX: Stupid bug." - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v3-ssp ( a53c64...2f0a72 )

by Sam

created 2017-11-15 09:07 UTC

BuildAddonJob::process() A

↳ Parent: BuildAddonJob

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	0

<?php
/**
 * A background job which builds a single add-on.
 */
class BuildAddonJob extends AbstractQueuedJob
{
    private $packageID;

    /**
     * @var array params
     * @throws Exception
     */
    public function __construct($params = array())
    {
        if (!empty($params['package'])) {
            $this->PackageID = $params['package'];

        }

        $this->currentStep = 0;
        $this->totalSteps = 1;
    }

    protected function getPackage()
    {
        return Addon::get()->byID($this->PackageID);

    }

    public function process()
    {
        $package = $this->getPackage();
        if (!$package->ID) {
            throw new Exception('Package not specified');
        }

        $builder = Injector::inst()->get('AddonBuilder');

        $builder->build($package);

        $package->BuildQueued = false;
        $package->write();

        $this->isComplete = true;
        $this->currentStep = 1;
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return 'Build Addon: ' . $this->getPackge()->Name;

    }
    /**
     * Return a signature for this queued job
     *
     * @return string
     */
    public function getSignature()
    {
        return md5(get_class($this) . $this->PackageID);

    }

}


1			<?php
2			/**
3			* A background job which builds a single add-on.
4			*/
5			class BuildAddonJob extends AbstractQueuedJob
6			{
7			private $packageID;
8
9			/**
10			* @var array params
11			* @throws Exception
12			*/
13			public function __construct($params = array())
14			{
15			if (!empty($params['package'])) {
16			$this->PackageID = $params['package'];
			0 ignored issues – show Bug introduced 2017-11-15 09:08 UTC by Report Bug Copy Issue Report The property `PackageID` does not seem to exist. Did you mean `packageID`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
17			}
18
19			$this->currentStep = 0;
20			$this->totalSteps = 1;
21			}
22
23			protected function getPackage()
24			{
25			return Addon::get()->byID($this->PackageID);
			0 ignored issues – show Bug introduced 2017-11-15 09:08 UTC by Report Bug Copy Issue Report The property `PackageID` does not seem to exist. Did you mean `packageID`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
26			}
27
28			public function process()
29			{
30			$package = $this->getPackage();
31			if (!$package->ID) {
32			throw new Exception('Package not specified');
33			}
34
35			$builder = Injector::inst()->get('AddonBuilder');
36
37			$builder->build($package);
38
39			$package->BuildQueued = false;
40			$package->write();
41
42			$this->isComplete = true;
43			$this->currentStep = 1;
44			}
45
46			/**
47			* @return string
48			*/
49			public function getTitle()
50			{
51			return 'Build Addon: ' . $this->getPackge()->Name;
			0 ignored issues – show Bug introduced 2017-11-15 09:08 UTC by Report Bug Copy Issue Report The method `getPackge()` does not exist on `BuildAddonJob`. Did you maybe mean `getPackage()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
52			}
53			/**
54			* Return a signature for this queued job
55			*
56			* @return string
57			*/
58			public function getSignature()
59			{
60			return md5(get_class($this) . $this->PackageID);
			0 ignored issues – show Bug introduced 2017-11-15 09:08 UTC by Report Bug Copy Issue Report The property `PackageID` does not seem to exist. Did you mean `packageID`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
61			}
62
63			}
64

silverstripe / addons.silverstripe.org

Push — v3-ssp ( a53c64...2f0a72 )

BuildAddonJob::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like