BuildAddonJob::getTitle() - Code Metrics - Inspection of "FIX: Simplify BuildAddonJob" - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v3-ssp ( ea3cd1...6c82e4 )

by Sam

created 2017-11-10 07:39 UTC

BuildAddonJob::getTitle() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * A background job which builds a single add-on.
 */
class BuildAddonJob extends AbstractQueuedJob
{
    private $packageID;

    /**
     * @var array params
     * @throws Exception
     */
    public function __construct($params = array())
    {
        if (!empty($params['package'])) {
            $this->PackageID = $params['package'];
        }

        $this->currentStep = 0;
        $this->totalSteps = 1;
    }

    protected function getPackage()
    {
        return Addon::get()->byID($this->PackageID);
    }

    public function process(context)

    {
        $package = $this->getPackage();
        if (!$package->ID) {
            throw new Exception('Package not specified');
        }

        $builder = Injector::inst()->get('AddonBuilder');

        $builder->build($package);

        $package->BuildQueued = false;
        $package->write();

        $this->isComplete = true;
        $this->currentStep = 1;
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return 'Build Addon: ' . $this->getPackge()->Name;
    }
    /**
     * Return a signature for this queued job
     *
     * @return string
     */
    public function getSignature()
    {
        return md5(get_class($this) . $this->PackageID);
    }

}


1			<?php
2			/**
3			* A background job which builds a single add-on.
4			*/
5			class BuildAddonJob extends AbstractQueuedJob
6			{
7			private $packageID;
8
9			/**
10			* @var array params
11			* @throws Exception
12			*/
13			public function __construct($params = array())
14			{
15			if (!empty($params['package'])) {
16			$this->PackageID = $params['package'];
17			}
18
19			$this->currentStep = 0;
20			$this->totalSteps = 1;
21			}
22
23			protected function getPackage()
24			{
25			return Addon::get()->byID($this->PackageID);
26			}
27
28			public function process(context)
			0 ignored issues – show Bug introduced 2017-11-10 07:41 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ')', expecting T_VARIABLE Loading history...
29			{
30			$package = $this->getPackage();
31			if (!$package->ID) {
32			throw new Exception('Package not specified');
33			}
34
35			$builder = Injector::inst()->get('AddonBuilder');
36
37			$builder->build($package);
38
39			$package->BuildQueued = false;
40			$package->write();
41
42			$this->isComplete = true;
43			$this->currentStep = 1;
44			}
45
46			/**
47			* @return string
48			*/
49			public function getTitle()
50			{
51			return 'Build Addon: ' . $this->getPackge()->Name;
52			}
53			/**
54			* Return a signature for this queued job
55			*
56			* @return string
57			*/
58			public function getSignature()
59			{
60			return md5(get_class($this) . $this->PackageID);
61			}
62
63			}
64

silverstripe / addons.silverstripe.org

Push — v3-ssp ( ea3cd1...6c82e4 )

BuildAddonJob::getTitle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like