StitchDataSenderTest::testAddonToJson() - Code Metrics - Inspection of "NEW: Add StitchData integration for SSLtd data war..." - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#202)

by Sam

created 2018-07-06 04:32 UTC

StitchDataSenderTest::testAddonToJson() A

↳ Parent: StitchDataSenderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	9.536
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php


use SilverStripe\Elastica\Searchable;

/**
 * Tests for StitchDataSender
 */
class StitchDataSenderTest extends SapphireTest
{

    protected static $fixture_file = 'mysite/tests/services/testAddon.yml';

    public function setUp()
    {
        Injector::inst()->registerService(new Searchable(null), Searchable::class);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        parent::setUp();
    }

    public function testAddonToJson()
    {
        $s = new StitchDataSender();
        $result = ($s->addonToJson($this->objFromFixture('Addon', 'addon_a')));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);


        $this->assertEquals('sminnee/test-package', $result['Name']);

        $this->assertInstanceof('Datetime', $result['Released']);

        $this->assertEquals([ 'Name' => 'good_code_coverage', 'Value' => 0 ], $result['RatingDetails'][0]);

        $this->assertEquals(2, sizeof($result['Versions']));

        $this->assertEquals('1.4.2.0', $result['Versions'][0]['Version']);

        $this->assertEquals(

            [[ 'Version' => '3.6', 'Major' => 3, 'Minor' => 6 ]],
            $result['Versions'][0]['CompatibleVersions']
        );
        $this->assertEquals(

            [[
                'Name' => 'Uncle Cheese',
                'Email' => '[email protected]',
                'Homepage' => 'http://leftandmain.com',
            ]],
            $result['Versions'][0]['Authors']
        );
    }
}


1			<?php
2
3
4			use SilverStripe\Elastica\Searchable;
5
6			/**
7			* Tests for StitchDataSender
8			*/
9			class StitchDataSenderTest extends SapphireTest
10			{
11
12			protected static $fixture_file = 'mysite/tests/services/testAddon.yml';
13
14			public function setUp()
15			{
16			Injector::inst()->registerService(new Searchable(null), Searchable::class);
			0 ignored issues – show Documentation introduced 2018-07-06 04:35 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object<SilverStripe\Elastica\ElasticaService>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-07-06 04:35 UTC by Report Bug Copy Issue Report `new \SilverStripe\Elastica\Searchable(null)` is of type `object<SilverStripe\Elastica\Searchable>`, but the function expects a `object<stdClass>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
17			parent::setUp();
18			}
19
20			public function testAddonToJson()
21			{
22			$s = new StitchDataSender();
23			$result = ($s->addonToJson($this->objFromFixture('Addon', 'addon_a')));
			0 ignored issues – show Documentation introduced 2018-07-06 04:35 UTC by Report Bug Copy Issue Report `$this->objFromFixture('Addon', 'addon_a')` is of type `object<DataObject>\|null`, but the function expects a `object<Addon>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24
25
26			$this->assertEquals('sminnee/test-package', $result['Name']);
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
27			$this->assertInstanceof('Datetime', $result['Released']);
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertInstanceof()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
28			$this->assertEquals([ 'Name' => 'good_code_coverage', 'Value' => 0 ], $result['RatingDetails'][0]);
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29			$this->assertEquals(2, sizeof($result['Versions']));
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
30			$this->assertEquals('1.4.2.0', $result['Versions'][0]['Version']);
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			$this->assertEquals(
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32			[[ 'Version' => '3.6', 'Major' => 3, 'Minor' => 6 ]],
33			$result['Versions'][0]['CompatibleVersions']
34			);
35			$this->assertEquals(
			0 ignored issues – show Bug introduced 2018-07-06 04:37 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<StitchDataSenderTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36			[[
37			'Name' => 'Uncle Cheese',
38			'Email' => '[email protected]',
39			'Homepage' => 'http://leftandmain.com',
40			]],
41			$result['Versions'][0]['Authors']
42			);
43			}
44			}
45

silverstripe / addons.silverstripe.org

Pull Request — master (#202)

StitchDataSenderTest::testAddonToJson() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like