AddonsApiController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	8

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	index()	0	49	3

<?php

class AddonsApiController extends ApiController
{
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

        'index',
    ];

    /**
     * Set the default cache lifetime in seconds. Only used outside of "dev" environments.
     *
     * Set to 1 week
     *
     * @config
     * @var int
     */
    private static $cache_age = 86400;

Consider using a different property name as you override a private property of the parent class.

    public function index(SS_HTTPRequest $request)
    {

        $after = (int)$request->getVar('after');
        $limit = 50;

        // Sort by ID. This will keep pagination consisent even if new records are added
        // Pagination is based on records greater than a given ID to ensure this is true
        // if records are deleted
        $addons = Addon::get()->sort('ID');
        $pageAddons = $addons->filter('ID:greaterthan', $after)->limit($limit)->toArray();

        if ($pageAddons) {

The expression $pageAddons of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $converter = Injector::inst()->get('AddonToArray');
            $apiAddons = array_map(
                function ($addon) use ($converter) {
                    return $converter->convert($addon);
                },
                $pageAddons
            );

            $maxID = max(array_map(
                function ($addon) {
                    return $addon->ID;
                },
                $pageAddons
            ));

            $result = [
                'success' => true,
                'addons' => $apiAddons
            ];

            if ($addons->filter('ID:greaterthan', $maxID)->count() > 0) {
                $result['next'] = Director::absoluteURL(HTTP::setGetVar('after', $maxID));
            }

        } else {
            $result = [
                'success' => false,
                'message' => 'No addons found',
            ];
        }



        return $this->formatResponse($result);
    }
}