SilverStripeVersion - Code Metrics - Inspection of "first pass at ss4" - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/ss4-upgrade ( f41a3f )

unknown

created 2017-01-23 23:56 UTC

SilverStripeVersion A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	3
dl	0
loc	28
c	0
b	0
f	0
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	getConstraint()	0	9	1

<?php
namespace SilverStripe\Addons\Model;

use SilverStripe\ORM\DataObject;
use Composer\Semver\Constraint\MultiConstraint;
use Composer\Semver\Constraint\Constraint;

/**
 * A SilverStripe version which an add-on can be compatible with.
 */
class SilverStripeVersion extends DataObject 
{

	private static $db = [

		'Name' => 'Varchar(10)',
		'Major' => 'Int',
		'Minor' => 'Int'
	];

	private static $default_sort = [

		'Major' => 'DESC',
		'Minor' => 'DESC'
	];

	/**
	 * @return Composer\Package\LinkConstraint\LinkConstraintInterface
	 */
	public function getConstraint() 
	{
		$next = $this->Major . '.' . ($this->Minor + 1);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

		return new MultiConstraint(array(
			new Constraint('>=', "$this->Major.$this->Minor.*"),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			new Constraint('<', "$next.*")
		));
	}

}


1			<?php
2			namespace SilverStripe\Addons\Model;
3
4			use SilverStripe\ORM\DataObject;
5			use Composer\Semver\Constraint\MultiConstraint;
6			use Composer\Semver\Constraint\Constraint;
7
8			/**
9			* A SilverStripe version which an add-on can be compatible with.
10			*/
11			class SilverStripeVersion extends DataObject
12			{
13
14			private static $db = [
			0 ignored issues – show Comprehensibility introduced 2017-01-24 00:06 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
15			'Name' => 'Varchar(10)',
16			'Major' => 'Int',
17			'Minor' => 'Int'
18			];
19
20			private static $default_sort = [
			0 ignored issues – show Comprehensibility introduced 2017-01-24 00:06 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
21			'Major' => 'DESC',
22			'Minor' => 'DESC'
23			];
24
25			/**
26			* @return Composer\Package\LinkConstraint\LinkConstraintInterface
27			*/
28			public function getConstraint()
29			{
30			$next = $this->Major . '.' . ($this->Minor + 1);
			0 ignored issues – show Documentation introduced 2017-01-24 00:06 UTC by Report Bug Copy Issue Report The property `Major` does not exist on `object<SilverStripe\Addo...el\SilverStripeVersion>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-24 00:06 UTC by Report Bug Copy Issue Report The property `Minor` does not exist on `object<SilverStripe\Addo...el\SilverStripeVersion>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31
32			return new MultiConstraint(array(
33			new Constraint('>=', "$this->Major.$this->Minor.*"),
			0 ignored issues – show Documentation introduced 2017-01-24 00:06 UTC by Report Bug Copy Issue Report The property `Major` does not exist on `object<SilverStripe\Addo...el\SilverStripeVersion>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-24 00:06 UTC by Report Bug Copy Issue Report The property `Minor` does not exist on `object<SilverStripe\Addo...el\SilverStripeVersion>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			new Constraint('<', "$next.*")
35			));
36			}
37
38			}
39

silverstripe / addons.silverstripe.org

Push — feature/ss4-upgrade ( f41a3f )

SilverStripeVersion A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like