SilverStripe\Addons\Model\AddonKeyword

Complexity

Total Complexity

2

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	get_by_name()	0	13	2

<?php

namespace SilverStripe\Addons\Model;

use SilverStripe\ORM\DataObject;

/**
 * A keyword which is attached to add-ons and versions.
 */
class AddonKeyword extends DataObject 
{

	private static $db = [

Consider using a different property name as you override a private property of the parent class.

		'Name' => 'Varchar(255)'
	];

	private static $belongs_many_many = [

Consider using a different property name as you override a private property of the parent class.

		'Addons' => 'SilverStripe\Addons\Model\Addon',
		'Versions' => 'SilverStripe\Addons\Model\AddonVersion'
	];

	/**
	 * Gets a keyword object by name, creating one if it does not exist.
	 *
	 * @param string $name
	 * @return AddonKeyword
	 */
	public static function get_by_name($name) 
	{
		$name = strtolower($name);
		$kw = AddonKeyword::get()->filter('Name', $name)->first();

		if (!$kw) {
			$kw = new AddonKeyword();
			$kw->Name = $name;

The property Name does not exist on object<SilverStripe\Addons\Model\AddonKeyword>. Since you implemented __set, maybe consider adding a @property annotation.

			$kw->write();
		}

		return $kw;
	}

}