SetSupportedAddonsTaskTest

Complexity

Total Complexity

13

Size/Duplication

Total Lines	108
Duplicated Lines	18.52 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	testHelpIsShownWithNoArguments()	0	6	1
A	testAddonsAreMarkedAsSupported()	0	8	1
A	testAddonsAreNotReplaced()	0	8	1
A	testMultipleAddonsCanBeMarkedAsSupported()	0	8	1
A	testReplaceFlagWillReplaceSupportedAddons()	0	10	1
A	testReplaceFlagWithNoAddonsWillNotDeleteEverything()	0	9	1
A	testReplaceFlagWithNoAddonsWillDeleteEverything()	0	8	1
A	assertAddonsAreSupported()	10	10	2
A	assertAddonsAreNotSupported()	10	10	2
A	runTask()	0	17	2

<?php

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class SetSupportedAddonsTaskTest extends FunctionalTest
{
    protected static $fixture_file = 'SetSupportedAddonsTaskTest.yml';

    public function testHelpIsShownWithNoArguments()
    {
        $output = $this->runTask();

        $this->assertContains('Usage:', $output);
    }

    public function testAddonsAreMarkedAsSupported()
    {
        $this->assertAddonsAreNotSupported('foo/unsupported-bar-a');

        $this->runTask('foo/unsupported-bar-a');

        $this->assertAddonsAreSupported('foo/unsupported-bar-a');
    }

    public function testAddonsAreNotReplaced()
    {
        $this->assertAddonsAreSupported('foo/supported-bar-a');

        $this->runTask('foo/unsupported-bar-a');

        $this->assertAddonsAreSupported('foo/supported-bar-a');
    }

    public function testMultipleAddonsCanBeMarkedAsSupported()
    {
        $this->assertAddonsAreNotSupported(['foo/unsupported-bar-a', 'foo/unsupported-bar-b']);

        $this->runTask('foo/unsupported-bar-a,foo/unsupported-bar-b');

        $this->assertAddonsAreSupported(['foo/unsupported-bar-a', 'foo/unsupported-bar-b']);
    }

    public function testReplaceFlagWillReplaceSupportedAddons()
    {
        $this->assertAddonsAreSupported('foo/supported-bar-a');
        $this->assertAddonsAreNotSupported('foo/unsupported-bar-a');

        $this->runTask('foo/unsupported-bar-a', ['-r']);

        $this->assertAddonsAreSupported('foo/unsupported-bar-a');
        $this->assertAddonsAreNotSupported('foo/supported-bar-a');
    }

    public function testReplaceFlagWithNoAddonsWillNotDeleteEverything()
    {
        $this->assertAddonsAreSupported('foo/supported-bar-a');

        $response = $this->runTask(null, ['-r']);

        $this->assertAddonsAreSupported('foo/supported-bar-a');
        $this->assertContains('Use -f to force', $response);
    }

    public function testReplaceFlagWithNoAddonsWillDeleteEverything()
    {
        $this->assertAddonsAreSupported('foo/supported-bar-a');

        $this->runTask(null, ['-rf']);

        $this->assertAddonsAreNotSupported('foo/supported-bar-a');
    }

    protected function assertAddonsAreSupported($addons)

This method seems to be duplicated in your project.

    {
        $addons = (array) $addons;

        $supportedAddons = Addon::get()->filter('Supported', true)->column('Name');

        foreach ($addons as $addon) {
            $this->assertContains($addon, $supportedAddons, $addon . ' is not supported');
        }
    }

    protected function assertAddonsAreNotSupported($addons)

This method seems to be duplicated in your project.

    {
        $addons = (array) $addons;

        $unsupportedAddons = Addon::get()->filter('Supported', false)->column('Name');

        foreach ($addons as $addon) {
            $this->assertContains($addon, $unsupportedAddons, $addon . ' is supported');
        }
    }

    protected function runTask($addons = null, array $args = [])
    {
        $vars = $addons ? ['addons' => $addons] : [];

        $request = $this->getMockBuilder(SS_HTTPRequest::class)

The method getMockBuilder() does not seem to exist on object<SetSupportedAddonsTaskTest>.

            ->setConstructorArgs(array('GET', 'test', $vars))
            ->getMock();

        $request->method('getVars')->willReturn($vars);
        $request->method('getVar')->will($this->onConsecutiveCalls($args, $addons));

The method onConsecutiveCalls() does not seem to exist on object<SetSupportedAddonsTaskTest>.

        $task = new SetSupportedAddonsTask();

        ob_start();
        $task->run($request);
        return ob_get_clean();
    }
}