SilverStripeVersionTest::constraintProvider() - Code Metrics - Inspection of "FIX Ensure module versions are correctly compared..." - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#153)

by Robbie

created 2017-01-25 07:47 UTC

SilverStripeVersionTest::constraintProvider() A

↳ Parent: SilverStripeVersionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	16
nc	1
nop	0

<?php
/**
 * Tests for the SilverStripeVersion model
 *
 * @package mysite
 */
class SilverStripeVersionTest extends SapphireTest
{
    /**
     * @var SilverStripeVersion
     */
    protected $version;

    /**
     * Create a test version
     *
     * {@inheritDoc}
     */
    public function setUp()
    {
        parent::setUp();
        $this->version = new SilverStripeVersion(
            [
                'Major' => 4,
                'Minor' => 1
            ]
        );
    }

    /**
     * Ensure that a simple string is returned for the version, which can be used for comparing composer
     * constraints against for validity
     */
    public function testGetConstraint()
    {
        $this->assertSame('4.1.0', (string) $this->version);

    }

    /**
     * Test various composer constraints against the version to see if this SilverStripe version would apply to
     * the module
     *
     * @dataProvider constraintProvider
     * @param string $constraint
     * @param bool   $expected
     */
    public function testGetConstraintValidity($constraint, $expected)
    {
        $this->assertSame($expected, $this->version->getConstraintValidity($constraint));

    }

    /**
     * @return array[]
     */
    public function constraintProvider()
    {
        return [
            ['1.0.0', false],
            ['~3.2', false],
            ['^3.2', false],
            ['>=3.2', true], // warning!!
            ['>=3.2,<4', false],
            ['4.0.0', false],
            ['~4.0.0', false],
            ['^4.0', true],
            ['>=4.0.0', true],
            ['~4.2.3', false],
            ['<5.0.0', true],
            ['^5.0.0', false],
            ['^3.5|^4.0', true],
            ['^3.5|^5.0', false]
        ];
    }
}


1			<?php
2			/**
3			* Tests for the SilverStripeVersion model
4			*
5			* @package mysite
6			*/
7			class SilverStripeVersionTest extends SapphireTest
8			{
9			/**
10			* @var SilverStripeVersion
11			*/
12			protected $version;
13
14			/**
15			* Create a test version
16			*
17			* {@inheritDoc}
18			*/
19			public function setUp()
20			{
21			parent::setUp();
22			$this->version = new SilverStripeVersion(
23			[
24			'Major' => 4,
25			'Minor' => 1
26			]
27			);
28			}
29
30			/**
31			* Ensure that a simple string is returned for the version, which can be used for comparing composer
32			* constraints against for validity
33			*/
34			public function testGetConstraint()
35			{
36			$this->assertSame('4.1.0', (string) $this->version);
			0 ignored issues – show Bug introduced 2017-01-25 07:49 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<SilverStripeVersionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
37			}
38
39			/**
40			* Test various composer constraints against the version to see if this SilverStripe version would apply to
41			* the module
42			*
43			* @dataProvider constraintProvider
44			* @param string $constraint
45			* @param bool $expected
46			*/
47			public function testGetConstraintValidity($constraint, $expected)
48			{
49			$this->assertSame($expected, $this->version->getConstraintValidity($constraint));
			0 ignored issues – show Bug introduced 2017-01-25 07:49 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<SilverStripeVersionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50			}
51
52			/**
53			* @return array[]
54			*/
55			public function constraintProvider()
56			{
57			return [
58			['1.0.0', false],
59			['~3.2', false],
60			['^3.2', false],
61			['>=3.2', true], // warning!!
62			['>=3.2,<4', false],
63			['4.0.0', false],
64			['~4.0.0', false],
65			['^4.0', true],
66			['>=4.0.0', true],
67			['~4.2.3', false],
68			['<5.0.0', true],
69			['^5.0.0', false],
70			['^3.5\|^4.0', true],
71			['^3.5\|^5.0', false]
72			];
73			}
74			}
75

silverstripe / addons.silverstripe.org

Pull Request — master (#153)

SilverStripeVersionTest::constraintProvider() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like