VendorsController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	87.5 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	4	4	1
A	Title()	4	4	1
A	Link()	4	4	1
A	Vendors()	20	25	2

<?php
/**
 * Handles listing package vendors.
 */
class VendorsController extends SiteController

This class seems to be duplicated in your project.

{

    public static $allowed_actions = array(
        'index'
    );

    public function index()
    {
        return $this->renderWith(array('Vendors', 'Page'));
    }

    public function Title()
    {
        return 'Vendors';
    }

    public function Link()
    {
        return Controller::join_links(Director::baseURL(), 'vendors');
    }

    public function Vendors()
    {
        $query = new SQLQuery();

The class SQLQuery has been deprecated with message: since version 4.0

        $result = new ArrayList();

        $query
            ->setSelect('"AddonVendor"."Name"')
            ->selectField('COUNT("Addon"."ID")'. 'Count')
            ->setFrom('"AddonVendor"')
            ->addLeftJoin('Addon', '"Addon"."VendorID" = "AddonVendor"."ID"')
            ->setGroupBy('"AddonVendor"."ID"')
            ->setOrderBy(array('"Count"' => 'DESC', '"Name"' => 'ASC'));

        foreach ($query->execute() as $row) {
            $link = Controller::join_links(
                Director::baseURL(),
                'add-ons',
                $row['Name']
            );

            $result->push(new ArrayData($row + array('Link' => $link)));
        }

        return $result;
    }
}