RatingApiControllerTest::testErrorWhenMissingParams() - Code Metrics - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

testErrorWhenMissingParams() A
last analyzed 2018-09-14 15:07 UTC

↳ Parent: RatingApiControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/**
 * @mixin PHPUnit_Framework_TestCase
 */
class RatingApiControllerTest extends FunctionalTest
{
    protected static $fixture_file = 'RatingApiControllerTest.yml';

    public function testErrorWhenMissingParams()
    {
        $response = $this->get('api/rating');

        $this->assertJson($response->getBody());


        $result = json_decode($response->getBody());
        $this->assertFalse($result->success);

        $this->assertContains('Missing', $result->message);
    }

    public function testErrorWhenModuleNotFound()
    {
        $response = $this->get('api/rating/bar/baz');

        $this->assertJson($response->getBody());


        $result = json_decode($response->getBody());
        $this->assertFalse($result->success);

        $this->assertContains('not be found', $result->message);
    }

    public function testResponseIncludesRating()

    {
        $response = $this->get('api/rating/foo/bar');

        $this->assertJson($response->getBody());


        $result = json_decode($response->getBody());
        $this->assertTrue($result->success);

        $this->assertSame(53, $result->rating);

    }

    public function testDetailedResponse()

    {
        $response = $this->get('api/rating/foo/bar?detailed');

        $this->assertJson($response->getBody());


        $result = json_decode($response->getBody());
        $this->assertTrue($result->success);

        $this->assertSame(3, $result->metrics->coverage);

    }
}


1		<?php
2
3		/**
4		* @mixin PHPUnit_Framework_TestCase
5		*/
6		class RatingApiControllerTest extends FunctionalTest
7		{
8		protected static $fixture_file = 'RatingApiControllerTest.yml';
9
10		public function testErrorWhenMissingParams()
11		{
12		$response = $this->get('api/rating');
13
14		$this->assertJson($response->getBody());
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertJson()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
15
16		$result = json_decode($response->getBody());
17		$this->assertFalse($result->success);
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
18		$this->assertContains('Missing', $result->message);
19		}
20
21		public function testErrorWhenModuleNotFound()
22		{
23		$response = $this->get('api/rating/bar/baz');
24
25		$this->assertJson($response->getBody());
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertJson()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
26
27		$result = json_decode($response->getBody());
28		$this->assertFalse($result->success);
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertFalse()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29		$this->assertContains('not be found', $result->message);
30		}
31
32	View Code Duplication	public function testResponseIncludesRating()
		0 ignored issues – show Duplication introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$response = $this->get('api/rating/foo/bar');
35
36		$this->assertJson($response->getBody());
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertJson()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
37
38		$result = json_decode($response->getBody());
39		$this->assertTrue($result->success);
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
40		$this->assertSame(53, $result->rating);
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41		}
42
43	View Code Duplication	public function testDetailedResponse()
		0 ignored issues – show Duplication introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$response = $this->get('api/rating/foo/bar?detailed');
46
47		$this->assertJson($response->getBody());
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertJson()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48
49		$result = json_decode($response->getBody());
50		$this->assertTrue($result->success);
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertTrue()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
51		$this->assertSame(3, $result->metrics->coverage);
		0 ignored issues – show Bug introduced 2018-05-16 00:20 UTC by Report Bug Copy Issue Report The method `assertSame()` does not seem to exist on `object<RatingApiControllerTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52		}
53		}
54

silverstripe / addons.silverstripe.org

testErrorWhenMissingParams() A last analyzed 2018-09-14 15:07 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

testErrorWhenMissingParams() A
last analyzed 2018-09-14 15:07 UTC