VendorController - Code Metrics - silverstripe/addons.silverstripe.org - Measure and Improve Code Quality continuously with Scrutinizer

VendorController A
last analyzed 2017-11-15 00:10 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	2
dl	0
loc	41
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	7	1
A	index()	4	1
A	Title()	4	1
A	Vendor()	4	1
A	Addons()	7	1

<?php
/**
 * Displays the packages and associated authors for a vendor.
 */
class VendorController extends SiteController
{

    public static $allowed_actions = array(
        'index'
    );

    protected $parent;
    protected $vendor;

    public function __construct(Controller $parent, AddonVendor $vendor)
    {
        $this->parent = $parent;
        $this->vendor = $vendor;

        parent::__construct();
    }

    public function index()
    {
        return $this->renderWith(array('Vendor', 'Page'));
    }

    public function Title()
    {
        return $this->vendor->Name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function Vendor()
    {
        return $this->vendor;
    }

    public function Addons()
    {
        $list = new PaginatedList($this->vendor->Addons(), $this->request);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $list->setPageLength(15);

        return $list;
    }
}


1			<?php
2			/**
3			* Displays the packages and associated authors for a vendor.
4			*/
5			class VendorController extends SiteController
6			{
7
8			public static $allowed_actions = array(
9			'index'
10			);
11
12			protected $parent;
13			protected $vendor;
14
15			public function __construct(Controller $parent, AddonVendor $vendor)
16			{
17			$this->parent = $parent;
18			$this->vendor = $vendor;
19
20			parent::__construct();
21			}
22
23			public function index()
24			{
25			return $this->renderWith(array('Vendor', 'Page'));
26			}
27
28			public function Title()
29			{
30			return $this->vendor->Name;
			0 ignored issues – show Documentation introduced 2015-11-21 22:01 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `object<AddonVendor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31			}
32
33			public function Vendor()
34			{
35			return $this->vendor;
36			}
37
38			public function Addons()
39			{
40			$list = new PaginatedList($this->vendor->Addons(), $this->request);
			0 ignored issues – show Documentation Bug introduced 2015-11-21 22:01 UTC by Report Bug Copy Issue Report The method `Addons` does not exist on `object<AddonVendor>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history... Documentation introduced 2015-11-21 22:01 UTC by Report Bug Copy Issue Report `$this->request` is of type `object<SS_HTTPRequest>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			$list->setPageLength(15);
42
43			return $list;
44			}
45			}
46

silverstripe / addons.silverstripe.org

VendorController A last analyzed 2017-11-15 00:10 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

VendorController A
last analyzed 2017-11-15 00:10 UTC