silverstripe /
addons.silverstripe.org
| Conditions | 5 |
| Paths | 5 |
| Total Lines | 51 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 20 | public function Menu() |
||
| 21 | { |
||
| 22 | $menu = new ArrayList(); |
||
| 23 | |||
| 24 | $menuEntries = array( |
||
| 25 | //array('controller' => 'HomeController'), |
||
| 26 | array('controller' => 'AddonsController'), |
||
| 27 | array( |
||
| 28 | 'link' => Controller::join_links( |
||
| 29 | singleton('AddonsController')->Link(), |
||
| 30 | '?type=theme&view=expanded' |
||
| 31 | ), |
||
| 32 | 'title' => 'Themes', |
||
| 33 | ), |
||
| 34 | array('controller' => 'VendorsController'), |
||
| 35 | array('controller' => 'AuthorsController'), |
||
| 36 | array('controller' => 'TagsController'), |
||
| 37 | array('controller' => 'SubmitAddonController'), |
||
| 38 | ); |
||
| 39 | |||
| 40 | foreach ($menuEntries as $menuEntry) { |
||
| 41 | if (isset($menuEntry['controller'])) { |
||
| 42 | $inst = singleton($menuEntry['controller']); |
||
| 43 | $active = false; |
||
| 44 | |||
| 45 | foreach (self::$controller_stack as $candidate) { |
||
| 46 | $active = ( |
||
| 47 | $candidate instanceof $menuEntry['controller'] |
||
| 48 | && $this->request->getVar('type') != 'theme' |
||
| 49 | ); |
||
| 50 | } |
||
| 51 | |||
| 52 | $menu->push(new ArrayData(array( |
||
| 53 | 'Title' => $inst->Title(), |
||
| 54 | 'Link' => $inst->Link(), |
||
| 55 | 'Active' => $active, |
||
| 56 | 'MenuItemType' => $inst->MenuItemType() |
||
| 57 | ))); |
||
| 58 | } else { |
||
| 59 | $active = ($this->request->getVar('type') == 'theme'); |
||
| 60 | $menu->push(new ArrayData(array( |
||
| 61 | 'Title' => $menuEntry['title'], |
||
| 62 | 'Link' => $menuEntry['link'], |
||
| 63 | 'Active' => $active, |
||
| 64 | 'MenuItemType' => 'link', |
||
| 65 | ))); |
||
| 66 | } |
||
| 67 | } |
||
| 68 | |||
| 69 | return $menu; |
||
| 70 | } |
||
| 71 | |||
| 94 |
Loading history...
This method has been deprecated. The supplier of the class has supplied an explanatory message.
The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead.