TestQJService::testInit() - Code Metrics - Inspection of "Merge pull request #125 from brettt89/compat-4.0" - silverstripe-australia/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ddd761...82d0cd )

by Marcus

created 2017-05-02 01:30 UTC

TestQJService::testInit() A

↳ Parent: TestQJService

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

namespace SilverStripe\QueuedJobs\Tests\QueuedJobsTest;

use SilverStripe\QueuedJobs\Services\QueuedJobService;
use SilverStripe\Dev\TestOnly;

// stub class to be able to call init from an external context
class TestQJService extends QueuedJobService implements TestOnly
{
    /**
     * Not inherited from QueuedJobService unfortunately...
     * @var array
     */
    private $logger;

    private static $dependencies = [

        'queueHandler' => '%$QueueHandler'
    ];

    public function testInit($descriptor)
    {
        return $this->initialiseJob($descriptor);
    }

    public function getLogger() 
    {
        return isset($this->logger) ? $this->logger : $this->logger = new QueuedJobsTest_RecordingLogger();

    }
}


1			<?php
2
3			namespace SilverStripe\QueuedJobs\Tests\QueuedJobsTest;
4
5			use SilverStripe\QueuedJobs\Services\QueuedJobService;
6			use SilverStripe\Dev\TestOnly;
7
8			// stub class to be able to call init from an external context
9			class TestQJService extends QueuedJobService implements TestOnly
10			{
11			/**
12			* Not inherited from QueuedJobService unfortunately...
13			* @var array
14			*/
15			private $logger;
16
17			private static $dependencies = [
			0 ignored issues – show Unused Code introduced 2016-12-21 23:52 UTC by Report Bug Copy Issue Report The property `$dependencies` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18			'queueHandler' => '%$QueueHandler'
19			];
20
21			public function testInit($descriptor)
22			{
23			return $this->initialiseJob($descriptor);
24			}
25
26			public function getLogger()
27			{
28			return isset($this->logger) ? $this->logger : $this->logger = new QueuedJobsTest_RecordingLogger();
			0 ignored issues – show Documentation Bug introduced 2017-04-24 04:01 UTC by Report Bug Copy Issue Report It seems like `new \SilverStripe\Queued...sTest_RecordingLogger()` of type `object<SilverStripe\Queu...bsTest_RecordingLogger>` is incompatible with the declared type `array` of property `$logger`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history... Bug Compatibility introduced 2017-04-24 04:01 UTC by Report Bug Copy Issue Report The expression `isset($this->logger) ? $...est_RecordingLogger());` of type `array\|SilverStripe\Queue...obsTest_RecordingLogger` adds the type `array` to the return on line 28 which is incompatible with the return type of the parent method `SilverStripe\QueuedJobs\...edJobService::getLogger` of type `Psr\Log\LoggerInterface`. Loading history...
29			}
30			}
31

silverstripe-australia / silverstripe-queuedjobs

Push — master ( ddd761...82d0cd )

TestQJService::testInit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like