ProcessJobQueueChildTask - Code Metrics - Inspection of "SilverStripe 4 compatibility" - silverstripe-australia/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#109)

by Robbie

created 2016-12-22 01:02 UTC

ProcessJobQueueChildTask A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	1
dl	0
loc	35
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	13	3
A	getService()	0	4	1

<?php

namespace SilverStripe\QueuedJobs\Tasks;

use AsyncPHP\Doorman\Handler;
use AsyncPHP\Doorman\Task;
use SilverStripe\Dev\BuildTask;

class ProcessJobQueueChildTask extends BuildTask
{
    /**
     * {@inheritDoc}
     * @var string
     */
    private static $segment = 'ProcessJobQueueChildTask';


    /**
     * @param HTTPRequest $request
     */
    public function run($request)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_SERVER['argv'][2])) {
            print "No task data provided.\n";
            return;
        }

        $task = @unserialize(@base64_decode($_SERVER['argv'][2]));

        if ($task) {
            $this->getService()->runJob($task->getDescriptor()->ID);
        }
    }

    /**
     * Returns an instance of the QueuedJobService.
     *
     * @return QueuedJobService
     */
    protected function getService()
    {
        return singleton('SilverStripe\\QueuedJobs\\Services\\QueuedJobService');
    }
}


1			<?php
2
3			namespace SilverStripe\QueuedJobs\Tasks;
4
5			use AsyncPHP\Doorman\Handler;
6			use AsyncPHP\Doorman\Task;
7			use SilverStripe\Dev\BuildTask;
8
9			class ProcessJobQueueChildTask extends BuildTask
10			{
11			/**
12			* {@inheritDoc}
13			* @var string
14			*/
15			private static $segment = 'ProcessJobQueueChildTask';
			0 ignored issues – show Comprehensibility introduced 2016-12-21 23:52 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-12-21 23:52 UTC by Report Bug Copy Issue Report The property `$segment` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16
17			/**
18			* @param HTTPRequest $request
19			*/
20			public function run($request)
			0 ignored issues – show Coding Style introduced 2016-12-21 23:52 UTC by Report Bug Copy Issue Report `run` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
21			{
22			if (!isset($_SERVER['argv'][2])) {
23			print "No task data provided.\n";
24			return;
25			}
26
27			$task = @unserialize(@base64_decode($_SERVER['argv'][2]));
28
29			if ($task) {
30			$this->getService()->runJob($task->getDescriptor()->ID);
31			}
32			}
33
34			/**
35			* Returns an instance of the QueuedJobService.
36			*
37			* @return QueuedJobService
38			*/
39			protected function getService()
40			{
41			return singleton('SilverStripe\\QueuedJobs\\Services\\QueuedJobService');
42			}
43			}
44

silverstripe-australia / silverstripe-queuedjobs

Pull Request — master (#109)

ProcessJobQueueChildTask A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like