QueuedJobsTest_RecordingLogger::countMessages() - Code Metrics - Inspection of "SilverStripe 4.0 Compatability" - silverstripe-australia/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#125)

unknown

created 2017-04-24 03:59 UTC

QueuedJobsTest_RecordingLogger::countMessages() A

↳ Parent: QueuedJobsTest_RecordingLogger

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1

<?php

namespace SilverStripe\QueuedJobs\Tests\QueuedJobsTest;

use Monolog\Logger;
use SilverStripe\Dev\TestOnly;

/**
 * Test logger for recording messages
 */
class QueuedJobsTest_RecordingLogger extends Logger implements TestOnly
{
    /**
     * @var QueuedJobsTest_Handler
     */
    protected $testHandler = null;

    public function __construct($name = 'testlogger', array $handlers = array(), array $processors = array())
    {
        parent::__construct($name, $handlers, $processors);

        $this->testHandler = new QueuedJobsTest_Handler();
        $this->pushHandler($this->testHandler);
    }

    /**
     * @return array
     */
    public function getMessages()
    {
        return $this->testHandler->getMessages();
    }

    /**
     * Clear all messages
     */
    public function clear()
    {
        $this->testHandler->clear();
    }

    /**
     * Get messages with the given filter
     *
     * @param string $containing
     * @return array Filtered array
     */
    public function filterMessages($containing)
    {
        return array_values(array_filter(
            $this->getMessages(),
            function ($content) use ($containing) {
                return stripos($content, $containing) !== false;
            }
        ));
    }

    /**
     * Count all messages containing the given substring
     *
     * @param string $containing Message to filter by
     * @return int
     */
    public function countMessages($containing = null)
    {
        if ($containing) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $messages = $this->filterMessages($containing);
        } else {
            $messages = $this->getMessages();
        }
        return count($messages);
    }
}


1			<?php
2
3			namespace SilverStripe\QueuedJobs\Tests\QueuedJobsTest;
4
5			use Monolog\Logger;
6			use SilverStripe\Dev\TestOnly;
7
8			/**
9			* Test logger for recording messages
10			*/
11			class QueuedJobsTest_RecordingLogger extends Logger implements TestOnly
12			{
13			/**
14			* @var QueuedJobsTest_Handler
15			*/
16			protected $testHandler = null;
17
18			public function __construct($name = 'testlogger', array $handlers = array(), array $processors = array())
19			{
20			parent::__construct($name, $handlers, $processors);
21
22			$this->testHandler = new QueuedJobsTest_Handler();
23			$this->pushHandler($this->testHandler);
24			}
25
26			/**
27			* @return array
28			*/
29			public function getMessages()
30			{
31			return $this->testHandler->getMessages();
32			}
33
34			/**
35			* Clear all messages
36			*/
37			public function clear()
38			{
39			$this->testHandler->clear();
40			}
41
42			/**
43			* Get messages with the given filter
44			*
45			* @param string $containing
46			* @return array Filtered array
47			*/
48			public function filterMessages($containing)
49			{
50			return array_values(array_filter(
51			$this->getMessages(),
52			function ($content) use ($containing) {
53			return stripos($content, $containing) !== false;
54			}
55			));
56			}
57
58			/**
59			* Count all messages containing the given substring
60			*
61			* @param string $containing Message to filter by
62			* @return int
63			*/
64			public function countMessages($containing = null)
65			{
66			if ($containing) {
			0 ignored issues – show Bug Best Practice introduced 2017-04-24 04:01 UTC by Report Bug Copy Issue Report The expression `$containing` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
67			$messages = $this->filterMessages($containing);
68			} else {
69			$messages = $this->getMessages();
70			}
71			return count($messages);
72			}
73			}
74

silverstripe-australia / silverstripe-queuedjobs

Pull Request — master (#125)

QueuedJobsTest_RecordingLogger::countMessages() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like