TestScheduledDataObject - Code Metrics - Inspection of "SilverStripe 4.0 Compatability" - silverstripe-australia/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#125)

unknown

created 2017-04-24 03:59 UTC

TestScheduledDataObject A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	1
lcom	0
cbo	1
dl	0
loc	19
rs	10
c	1
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	onScheduledExecution()	0	5	1

<?php

namespace SilverStripe\QueuedJobs\Tests\ScheduledExecutionTest;

use SilverStripe\ORM\DataObject;
use SilverStripe\Dev\TestOnly;
use SilverStripe\QueuedJobs\Extensions\ScheduledExecutionExtension;

class TestScheduledDataObject extends DataObject implements TestOnly
{
    private static $table_name = 'TestScheduledDataObject';


    private static $db = array(

        'Title' => 'Varchar',
        'Message' => 'Varchar',
    );

    private static $extensions = array(

        ScheduledExecutionExtension::class
    );

    public function onScheduledExecution()
    {
        $this->Message = 'EXECUTED';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->write();
    }
}


1			<?php
2
3			namespace SilverStripe\QueuedJobs\Tests\ScheduledExecutionTest;
4
5			use SilverStripe\ORM\DataObject;
6			use SilverStripe\Dev\TestOnly;
7			use SilverStripe\QueuedJobs\Extensions\ScheduledExecutionExtension;
8
9			class TestScheduledDataObject extends DataObject implements TestOnly
10			{
11			private static $table_name = 'TestScheduledDataObject';
			0 ignored issues – show Comprehensibility introduced 2017-04-21 15:29 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-04-21 15:29 UTC by Report Bug Copy Issue Report The property `$table_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12
13			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-04-21 15:29 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-04-21 15:29 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14			'Title' => 'Varchar',
15			'Message' => 'Varchar',
16			);
17
18			private static $extensions = array(
			0 ignored issues – show Comprehensibility introduced 2015-11-20 23:52 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-20 23:52 UTC by Report Bug Copy Issue Report The property `$extensions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19			ScheduledExecutionExtension::class
20			);
21
22			public function onScheduledExecution()
23			{
24			$this->Message = 'EXECUTED';
			0 ignored issues – show Documentation introduced 2017-04-24 01:00 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `object<SilverStripe\Queu...estScheduledDataObject>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			$this->write();
26			}
27			}
28

silverstripe-australia / silverstripe-queuedjobs

Pull Request — master (#125)

TestScheduledDataObject A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like