SilverStripe\QueuedJobs\Tests\QueuedJobsTest\TestQJService

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testInit()	0	4	1
A	getLogger()	0	4	2

<?php

namespace SilverStripe\QueuedJobs\Tests\QueuedJobsTest;

use SilverStripe\QueuedJobs\Services\QueuedJobService;
use SilverStripe\Dev\TestOnly;

// stub class to be able to call init from an external context
class TestQJService extends QueuedJobService implements TestOnly
{
    /**
     * Not inherited from QueuedJobService unfortunately...
     * @var array
     */
    private $logger;

    private static $dependencies = [

The property $dependencies is not used and could be removed.

        'queueHandler' => '%$QueueHandler'
    ];

    public function testInit($descriptor)
    {
        return $this->initialiseJob($descriptor);
    }

    public function getLogger() 
    {
        return isset($this->logger) ? $this->logger : $this->logger = new QueuedJobsTest_RecordingLogger();

It seems like new \SilverStripe\QueuedJobs\Tests\QueuedJobsTest\QueuedJobsTest_RecordingLogger() of type object<SilverStripe\QueuedJobs\Tests\QueuedJobsTest\QueuedJobsTest_RecordingLogger> is incompatible with the declared type array of property $logger.

The expression isset($this->logger) ? $this->logger : ($this->logger = new \SilverStripe\QueuedJobs\Tests\QueuedJobsTest\QueuedJobsTest_RecordingLogger()); of type array|SilverStripe\QueuedJobs\Tests\QueuedJobsTest\QueuedJobsTest_RecordingLogger adds the type array to the return on line 28 which is incompatible with the return type of the parent method SilverStripe\QueuedJobs\Services\QueuedJobService::getLogger of type Psr\Log\LoggerInterface.

    }
}