NotifyUsersWorkflowAction - Code Metrics - Inspection of "changing classname due to some weird logic or old..." - silverstripe-australia/advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#157)

by John

created 2016-03-23 08:30 UTC

NotifyUsersWorkflowAction A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	191
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	23
c	1
b	0
f	0
lcom	1
cbo	15
dl	0
loc	191
rs	9.1666

6 Methods

Rating	Name	Size	Complexity
A	getCMSFields()	18	1
A	fieldLabels()	11	1
C	execute()	64	9
B	getContextFields()	19	5
B	getMemberFields()	16	6
B	getFormattingHelp()	26	1

<?php
/**
 * A workflow action that notifies users attached to the workflow path that they have a task awaiting them.
 *
 * @license    BSD License (http://silverstripe.org/bsd-license/)
 * @package    advancedworkflow
 * @subpackage actions
 */
class NotifyUsersWorkflowAction extends WorkflowAction {
namespace YourVendor;

class YourClass { }

	/**
	 * @var bool Should templates be constrained to just known-safe variables.
	 */
	private static $whitelist_template_variables = false;


	private static $db = array(

		'EmailSubject'			=> 'Varchar(100)',
		'EmailFrom'				=> 'Varchar(50)',
		'EmailTemplate'			=> 'Text'
	);

	public static $icon = 'advancedworkflow/images/notify.png';

	public function getCMSFields() {
		$fields = parent::getCMSFields();

		$fields->addFieldsToTab('Root.Main', array(
			new HeaderField('NotificationEmail', $this->fieldLabel('NotificationEmail')),
			new LiteralField('NotificationNote', '<p>' . $this->fieldLabel('NotificationNote') . '</p>'),
			new TextField('EmailSubject', $this->fieldLabel('EmailSubject')),
			new TextField('EmailFrom', $this->fieldLabel('EmailFrom')),

			new TextareaField('EmailTemplate', $this->fieldLabel('EmailTemplate')),
			new ToggleCompositeField('FormattingHelpContainer',
				$this->fieldLabel('FormattingHelp'), new LiteralField('FormattingHelp', $this->getFormattingHelp()))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		));

		$this->extend('updateNotifyUsersCMSFields', $fields);

		return $fields;
	}

	public function fieldLabels($relations = true) {
		return array_merge(parent::fieldLabels($relations), array(
			'NotificationEmail' => _t('NotifyUsersWorkflowAction.NOTIFICATIONEMAIL', 'Notification Email'),
			'NotificationNote'  => _t('NotifyUsersWorkflowAction.NOTIFICATIONNOTE',
				'All users attached to the workflow will be sent an email when this action is run.'),
			'EmailSubject'      => _t('NotifyUsersWorkflowAction.EMAILSUBJECT', 'Email subject'),
			'EmailFrom'         => _t('NotifyUsersWorkflowAction.EMAILFROM', 'Email from'),
			'EmailTemplate'     => _t('NotifyUsersWorkflowAction.EMAILTEMPLATE', 'Email template'),
			'FormattingHelp'    => _t('NotifyUsersWorkflowAction.FORMATTINGHELP', 'Formatting Help')
		));
	}

	public function execute(WorkflowInstance $workflow) {
		$members = $workflow->getAssignedMembers();

		if(!$members || !count($members)) {
			return true;
		}

		$member = Member::currentUser();
		$initiator = $workflow->Initiator();

		$contextFields   = $this->getContextFields($workflow->getTarget());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		$memberFields    = $this->getMemberFields($member);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		$initiatorFields = $this->getMemberFields($initiator);

		$variables = array();
		
		foreach($contextFields as $field => $val) $variables["\$Context.$field"] = $val;
		foreach($memberFields as $field => $val)  $variables["\$Member.$field"] = $val;
		foreach($initiatorFields as $field => $val)  $variables["\$Initiator.$field"] = $val;

		$pastActions = $workflow->Actions()->sort('Created DESC');

		$variables["\$CommentHistory"] = $this->customise(array(
			'PastActions'=>$pastActions,
			'Now'=>SS_Datetime::now()
		))->renderWith('CommentHistory');

		$from = str_replace(array_keys($variables), array_values($variables), $this->EmailFrom);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$subject = str_replace(array_keys($variables), array_values($variables), $this->EmailSubject);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

		if ($this->config()->whitelist_template_variables) {
			$item = new ArrayData(array(
				'Initiator' => new ArrayData($initiatorFields),
				'Member' => new ArrayData($memberFields),
				'Context' => new ArrayData($contextFields),
				'CommentHistory' => $variables["\$CommentHistory"]
			));
		}
		else {
			$item = $workflow->customise(array(
				'Items' => $workflow->Actions(),

				'Member' => $member,
				'Context' => new ArrayData($contextFields),
				'CommentHistory' => $variables["\$CommentHistory"]
			));
		}

		
		$view = SSViewer::fromString($this->EmailTemplate);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		
		$body = $view->process($item);

		foreach($members as $member) {
			if($member->Email) {
				$email = new Email;
				$email->setTo($member->Email);
				$email->setSubject($subject);
				$email->setFrom($from);
				$email->setBody($body);
				$email->send();
			}
		}

		return true;
	}

	/**
	 * @param  DataObject $target
	 * @return array
	 */
	public function getContextFields(DataObject $target) {
		$result = array();
		if (!$target) {
			return $result;
		}
		$fields = $target->inheritedDatabaseFields();

		foreach($fields as $field => $fieldDesc) {
			$result[$field] = $target->$field;
		}

		if($target instanceof CMSPreviewable) {
			$result['CMSLink'] = $target->CMSEditLink();
		} else if ($target->hasMethod('WorkflowLink')) {
			$result['CMSLink'] = $target->WorkflowLink();
		}

		return $result;
	}

	/**
	 * Builds an array with the member information
	 * @param Member $member An optional member to use. If null, will use the current logged in member
	 * @return array
	 */
	public function getMemberFields(Member $member = null) {
		if (!$member){
			$member = Member::currentUser();
		}
		$result = array();

		if($member) foreach($member->summaryFields() as $field => $title) {
			$result[$field] = $member->$field;
		}

		if($member && !array_key_exists('Name', $result)) {
			$result['Name'] = $member->getName();
		}

		return $result;
	}
	

	/**
	 * Returns a basic set of instructions on how email templates are populated with variables.
	 *
	 * @return string
	 */
	public function getFormattingHelp() {
		$note = _t('NotifyUsersWorkflowAction.FORMATTINGNOTE',
			'Notification emails can contain HTML formatting. The following special variables are replaced with their
			respective values in the email subject, email from and template/body.');
		$member = _t('NotifyUsersWorkflowAction.MEMBERNOTE',
			'These fields will be populated from the member that initiates the notification action. For example,
			{$Member.FirstName}.');
		$initiator = _t('NotifyUsersWorkflowAction.INITIATORNOTE',
			'These fields will be populated from the member that initiates the workflow request. For example,
			{$Initiator.Email}.');
		$context = _t('NotifyUsersWorkflowAction.CONTEXTNOTE',
			'Any summary fields from the workflow target will be available. For example, {$Context.Title}.
			Additionally, the {$Context.AbsoluteEditLink} variable will contain a link to edit the workflow target in
			the CMS (if it is a Page), and the {$Context.LinkToPendingItems} variable will generate a link to the CMS\' workflow admin,
			useful for allowing users to enact workflow transitions, directly from emails.');
		$fieldName = _t('NotifyUsersWorkflowAction.FIELDNAME', 'Field name');
		$commentHistory = _t('NotifyUsersWorkflowAction.COMMENTHISTORY', 'Comment history up to this notification.');

		$memberFields = implode(', ', array_keys($this->getMemberFields()));

		return "<p>$note</p>
			<p><strong>{\$Member.($memberFields)}</strong><br>$member</p>
			<p><strong>{\$Initiator.($memberFields)}</strong><br>$initiator</p>
			<p><strong>{\$Context.($fieldName)}</strong><br>$context</p>
			<p><strong>{\$CommentHistory}</strong><br>$commentHistory</p>";
	}

}


1			<?php
2			/**
3			* A workflow action that notifies users attached to the workflow path that they have a task awaiting them.
4			*
5			* @license BSD License (http://silverstripe.org/bsd-license/)
6			* @package advancedworkflow
7			* @subpackage actions
8			*/
9			class NotifyUsersWorkflowAction extends WorkflowAction {
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10
11			/**
12			* @var bool Should templates be constrained to just known-safe variables.
13			*/
14			private static $whitelist_template_variables = false;
			0 ignored issues – show Unused Code introduced 2015-11-24 22:55 UTC by Report Bug Copy Issue Report The property `$whitelist_template_variables` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17			'EmailSubject' => 'Varchar(100)',
18			'EmailFrom' => 'Varchar(50)',
19			'EmailTemplate' => 'Text'
20			);
21
22			public static $icon = 'advancedworkflow/images/notify.png';
23
24			public function getCMSFields() {
25			$fields = parent::getCMSFields();
26
27			$fields->addFieldsToTab('Root.Main', array(
28			new HeaderField('NotificationEmail', $this->fieldLabel('NotificationEmail')),
29			new LiteralField('NotificationNote', '<p>' . $this->fieldLabel('NotificationNote') . '</p>'),
30			new TextField('EmailSubject', $this->fieldLabel('EmailSubject')),
31			new TextField('EmailFrom', $this->fieldLabel('EmailFrom')),
32
33			new TextareaField('EmailTemplate', $this->fieldLabel('EmailTemplate')),
34			new ToggleCompositeField('FormattingHelpContainer',
35			$this->fieldLabel('FormattingHelp'), new LiteralField('FormattingHelp', $this->getFormattingHelp()))
			0 ignored issues – show Documentation introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report `new \LiteralField('Forma...s->getFormattingHelp())` is of type `object<LiteralField>`, but the function expects a `array\|object<FieldList>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			));
37
38			$this->extend('updateNotifyUsersCMSFields', $fields);
39
40			return $fields;
41			}
42
43			public function fieldLabels($relations = true) {
44			return array_merge(parent::fieldLabels($relations), array(
45			'NotificationEmail' => _t('NotifyUsersWorkflowAction.NOTIFICATIONEMAIL', 'Notification Email'),
46			'NotificationNote' => _t('NotifyUsersWorkflowAction.NOTIFICATIONNOTE',
47			'All users attached to the workflow will be sent an email when this action is run.'),
48			'EmailSubject' => _t('NotifyUsersWorkflowAction.EMAILSUBJECT', 'Email subject'),
49			'EmailFrom' => _t('NotifyUsersWorkflowAction.EMAILFROM', 'Email from'),
50			'EmailTemplate' => _t('NotifyUsersWorkflowAction.EMAILTEMPLATE', 'Email template'),
51			'FormattingHelp' => _t('NotifyUsersWorkflowAction.FORMATTINGHELP', 'Formatting Help')
52			));
53			}
54
55			public function execute(WorkflowInstance $workflow) {
56			$members = $workflow->getAssignedMembers();
57
58			if(!$members \|\| !count($members)) {
59			return true;
60			}
61
62			$member = Member::currentUser();
63			$initiator = $workflow->Initiator();
64
65			$contextFields = $this->getContextFields($workflow->getTarget());
			0 ignored issues – show Bug introduced 2015-11-22 20:12 UTC by Report Bug Copy Issue Report It seems like `$workflow->getTarget()` can be `null`; however, `getContextFields()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
66			$memberFields = $this->getMemberFields($member);
			0 ignored issues – show Bug introduced 2016-02-25 04:28 UTC by Report Bug Copy Issue Report It seems like `$member` defined by `\Member::currentUser()` on line `62` can also be of type `object<DataObject>`; however, `NotifyUsersWorkflowAction::getMemberFields()` does only seem to accept `null\|object<Member>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
67			$initiatorFields = $this->getMemberFields($initiator);
68
69			$variables = array();
70
71			foreach($contextFields as $field => $val) $variables["\$Context.$field"] = $val;
72			foreach($memberFields as $field => $val) $variables["\$Member.$field"] = $val;
73			foreach($initiatorFields as $field => $val) $variables["\$Initiator.$field"] = $val;
74
75			$pastActions = $workflow->Actions()->sort('Created DESC');
			0 ignored issues – show Bug introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report The method `Actions()` does not exist on `WorkflowInstance`. Did you maybe mean `getFrontEndWorkflowActions()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
76			$variables["\$CommentHistory"] = $this->customise(array(
77			'PastActions'=>$pastActions,
78			'Now'=>SS_Datetime::now()
79			))->renderWith('CommentHistory');
80
81			$from = str_replace(array_keys($variables), array_values($variables), $this->EmailFrom);
			0 ignored issues – show Documentation introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report The property `EmailFrom` does not exist on `object<NotifyUsersWorkflowAction>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
82			$subject = str_replace(array_keys($variables), array_values($variables), $this->EmailSubject);
			0 ignored issues – show Documentation introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report The property `EmailSubject` does not exist on `object<NotifyUsersWorkflowAction>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
83
84			if ($this->config()->whitelist_template_variables) {
85			$item = new ArrayData(array(
86			'Initiator' => new ArrayData($initiatorFields),
87			'Member' => new ArrayData($memberFields),
88			'Context' => new ArrayData($contextFields),
89			'CommentHistory' => $variables["\$CommentHistory"]
90			));
91			}
92			else {
93			$item = $workflow->customise(array(
94			'Items' => $workflow->Actions(),
			0 ignored issues – show Bug introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report The method `Actions()` does not exist on `WorkflowInstance`. Did you maybe mean `getFrontEndWorkflowActions()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
95			'Member' => $member,
96			'Context' => new ArrayData($contextFields),
97			'CommentHistory' => $variables["\$CommentHistory"]
98			));
99			}
100
101
102			$view = SSViewer::fromString($this->EmailTemplate);
			0 ignored issues – show Documentation introduced 2015-11-20 23:47 UTC by Report Bug Copy Issue Report The property `EmailTemplate` does not exist on `object<NotifyUsersWorkflowAction>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
103
104			$body = $view->process($item);
105
106			foreach($members as $member) {
107			if($member->Email) {
108			$email = new Email;
109			$email->setTo($member->Email);
110			$email->setSubject($subject);
111			$email->setFrom($from);
112			$email->setBody($body);
113			$email->send();
114			}
115			}
116
117			return true;
118			}
119
120			/**
121			* @param DataObject $target
122			* @return array
123			*/
124			public function getContextFields(DataObject $target) {
125			$result = array();
126			if (!$target) {
127			return $result;
128			}
129			$fields = $target->inheritedDatabaseFields();
130
131			foreach($fields as $field => $fieldDesc) {
132			$result[$field] = $target->$field;
133			}
134
135			if($target instanceof CMSPreviewable) {
136			$result['CMSLink'] = $target->CMSEditLink();
137			} else if ($target->hasMethod('WorkflowLink')) {
138			$result['CMSLink'] = $target->WorkflowLink();
139			}
140
141			return $result;
142			}
143
144			/**
145			* Builds an array with the member information
146			* @param Member $member An optional member to use. If null, will use the current logged in member
147			* @return array
148			*/
149			public function getMemberFields(Member $member = null) {
150			if (!$member){
151			$member = Member::currentUser();
152			}
153			$result = array();
154
155			if($member) foreach($member->summaryFields() as $field => $title) {
156			$result[$field] = $member->$field;
157			}
158
159			if($member && !array_key_exists('Name', $result)) {
160			$result['Name'] = $member->getName();
161			}
162
163			return $result;
164			}
165
166
167			/**
168			* Returns a basic set of instructions on how email templates are populated with variables.
169			*
170			* @return string
171			*/
172			public function getFormattingHelp() {
173			$note = _t('NotifyUsersWorkflowAction.FORMATTINGNOTE',
174			'Notification emails can contain HTML formatting. The following special variables are replaced with their
175			respective values in the email subject, email from and template/body.');
176			$member = _t('NotifyUsersWorkflowAction.MEMBERNOTE',
177			'These fields will be populated from the member that initiates the notification action. For example,
178			{$Member.FirstName}.');
179			$initiator = _t('NotifyUsersWorkflowAction.INITIATORNOTE',
180			'These fields will be populated from the member that initiates the workflow request. For example,
181			{$Initiator.Email}.');
182			$context = _t('NotifyUsersWorkflowAction.CONTEXTNOTE',
183			'Any summary fields from the workflow target will be available. For example, {$Context.Title}.
184			Additionally, the {$Context.AbsoluteEditLink} variable will contain a link to edit the workflow target in
185			the CMS (if it is a Page), and the {$Context.LinkToPendingItems} variable will generate a link to the CMS\' workflow admin,
186			useful for allowing users to enact workflow transitions, directly from emails.');
187			$fieldName = _t('NotifyUsersWorkflowAction.FIELDNAME', 'Field name');
188			$commentHistory = _t('NotifyUsersWorkflowAction.COMMENTHISTORY', 'Comment history up to this notification.');
189
190			$memberFields = implode(', ', array_keys($this->getMemberFields()));
191
192			return "<p>$note</p>
193			<p><strong>{\$Member.($memberFields)}</strong><br>$member</p>
194			<p><strong>{\$Initiator.($memberFields)}</strong><br>$initiator</p>
195			<p><strong>{\$Context.($fieldName)}</strong><br>$context</p>
196			<p><strong>{\$CommentHistory}</strong><br>$commentHistory</p>";
197			}
198
199			}
200

silverstripe-australia / advancedworkflow

Pull Request — master (#157)

NotifyUsersWorkflowAction A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like