WorkflowEngineTest::testPublishAction() - Code Metrics - Inspection of "Converted to PSR-2" - silverstripe-australia/advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#230)

by Helpful

created 2015-12-17 06:52 UTC

WorkflowEngineTest::testPublishAction() A

↳ Parent: WorkflowEngineTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	21
rs	9.3143
cc	1
eloc	13
nc	1
nop	0

<?php
/**
 * Tests for the workflow engine.
 *
 * @author     [email protected]
 * @license    BSD License (http://silverstripe.org/bsd-license/)
 * @package    advancedworkflow
 * @subpackage tests
 */
class WorkflowEngineTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{

    public static $fixture_file = 'advancedworkflow/tests/workflowinstancetargets.yml';

    public function testCreateWorkflowInstance()
    {
        $definition = new WorkflowDefinition();
        $definition->Title = "Create Workflow Instance";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();

        $stepOne = new WorkflowAction();
        $stepOne->Title = "Step One";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->write();

        $stepTwo = new WorkflowAction();
        $stepTwo->Title = "Step Two";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->write();

        $transitionOne = new WorkflowTransition();
        $transitionOne->Title = 'Step One T1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->ActionID = $stepOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->NextActionID = $stepTwo->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->write();

        $instance = new WorkflowInstance();
        $instance->write();

        $instance->beginWorkflow($definition);

        $actions = $definition->Actions();

        $this->assertEquals(2, $actions->Count());


        $transitions = $actions->find('Title', 'Step One')->Transitions();
        $this->assertEquals(1, $transitions->Count());

    }

    public function testExecuteImmediateWorkflow()
    {
        $def = $this->createDefinition();

        $actions = $def->Actions();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $firstAction = $def->getInitialAction();
        $this->assertEquals('Step One', $firstAction->Title);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $instance = new WorkflowInstance();
        $instance->beginWorkflow($def);
        $this->assertTrue($instance->CurrentActionID > 0);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $instance->execute();

        // the instance should be complete, and have two finished workflow action
        // instances.
        $actions = $instance->Actions();

        $this->assertEquals(2, $actions->Count());


        foreach ($actions as $action) {
            $this->assertTrue((bool) $action->Finished);

        }
    }

    /**
     * Ensure WorkflowInstance returns expected values for a Published target object.
     */
    public function testInstanceGetTargetPublished()

    {
        $def = $this->createDefinition();
        $target = $this->objFromFixture('SiteTree', 'published-object');
        $target->doPublish();

        $instance = $this->objFromFixture('WorkflowInstance', 'target-is-published');
        $instance->beginWorkflow($def);
        $instance->execute();

        $this->assertTrue($target->isPublished());

        $this->assertEquals($target->ID, $instance->getTarget()->ID);

        $this->assertEquals($target->Title, $instance->getTarget()->Title);

    }

    /**
     * Ensure WorkflowInstance returns expected values for a Draft target object.
     */
    public function testInstanceGetTargetDraft()

    {
        $def = $this->createDefinition();
        $target = $this->objFromFixture('SiteTree', 'draft-object');

        $instance = $this->objFromFixture('WorkflowInstance', 'target-is-draft');
        $instance->beginWorkflow($def);
        $instance->execute();

        $this->assertFalse($target->isPublished());

        $this->assertEquals($target->ID, $instance->getTarget()->ID);

        $this->assertEquals($target->Title, $instance->getTarget()->Title);

    }
    
    public function testPublishAction()
    {
        $this->logInWithPermission();
        
        $action = new PublishItemWorkflowAction;
        $instance = new WorkflowInstance();

        $page = new Page();
        $page->Title = 'stuff';
        $page->write();

        $instance->TargetClass = 'Page';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $instance->TargetID = $page->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->assertFalse($page->isPublished());


        $action->execute($instance);

        $page = DataObject::get_by_id('Page', $page->ID);
        $this->assertTrue($page->isPublished());

    }

    public function testCreateDefinitionWithEmptyTitle()
    {
        $definition = new WorkflowDefinition();
        $definition->Title = "";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();
        $this->assertContains('My Workflow', $definition->Title, 'Workflow created without title is assigned a default title.');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function createDefinition()

    {
        $definition = new WorkflowDefinition();
        $definition->Title = "Dummy Workflow Definition";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();

        $stepOne = new WorkflowAction();
        $stepOne->Title = "Step One";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->write();

        $stepTwo = new WorkflowAction();
        $stepTwo->Title = "Step Two";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->write();

        $transitionOne = new WorkflowTransition();
        $transitionOne->Title = 'Step One T1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->ActionID = $stepOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->NextActionID = $stepTwo->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->write();

        return $definition;
    }
    
    
    public function testCreateFromTemplate()
    {
        $structure = array(
            'First step'    => array(
                'type'        => 'AssignUsersToWorkflowAction',
                'transitions'    => array(
                    'second'    => 'Second step'
                )
            ),
            'Second step'    => array(
                'type'        => 'NotifyUsersWorkflowAction',
                'transitions'    => array(
                    'Approve'    => 'Third step'
                )
            ),
        );
        
        $template = new WorkflowTemplate('Test');
        
        $template->setStructure($structure);
        
        $actions = $template->createRelations();
        
        $this->assertEquals(2, count($actions));

        $this->assertTrue(isset($actions['First step']));

        $this->assertTrue(isset($actions['Second step']));

        
        $this->assertTrue($actions['First step']->exists());

        
        $transitions = $actions['First step']->Transitions();

        $this->assertTrue($transitions->count() == 1);

    }
    
    /**
     * Tests whether if user(s) are able to delete a workflow, dependent on permissions.
     */
    public function testCanDeleteWorkflow()
    {
        // Create a definition
        $def = $this->createDefinition();
        
        // Test a user with lame permissions
        $memberID = $this->logInWithPermission('SITETREE_VIEW_ALL');
        $member = DataObject::get_by_id('Member', $memberID);
        $this->assertFalse($def->canCreate($member));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        
        // Test a user with good permissions
        $memberID = $this->logInWithPermission('CREATE_WORKFLOW');
        $member = DataObject::get_by_id('Member', $memberID);
        $this->assertTrue($def->canCreate($member));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
    
    /**
     * For a context around this test, see: https://github.com/silverstripe-australia/advancedworkflow/issues/141
     * 
     *	1). Create a workflow definition
     *	2). Step the content into that workflow
     *	3). Delete the workflow
     *	4). Check that the content:
     *		i). Has no remaining related actions
     *		ii). Can be re-assigned a new Workflow 
     *	5). Check that the object under workflow, maintains its status (Draft, Published etc)
     */
    public function testDeleteWorkflowTargetStillWorks()
    {
        // 1). Create a workflow definition
        $def = $this->createDefinition();
        $page = Page::create();
        $page->Title = 'dummy test';
        $page->WorkflowDefinitionID = $def->ID;    // Normally done via CMS
        Versioned::reading_stage('Stage');
        $page->write();
        
        // Check $page is in draft, pre-deletion
        $status = ($page->getIsAddedToStage() && !$page->getExistsOnLive());
        $this->assertTrue($status);

        
        // 2). Step the content into that workflow
        $instance = new WorkflowInstance();
        $instance->beginWorkflow($def, $page);
        $instance->execute();
        
        // Check the content is assigned
        $testPage = DataObject::get_by_id('Page', $page->ID);
        $this->assertEquals($instance->TargetID, $testPage->ID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        
        // 3). Delete the workflow
        $def->delete();
        
        // Check $testPage is _still_ in draft, post-deletion
        $status = ($testPage->getIsAddedToStage() && !$testPage->getExistsOnLive());

        $this->assertTrue($status);

        
        /*
         * 4). i). Check that the content: Has no remaining related actions
         * Note: WorkflowApplicable::WorkflowDefinitionID does _not_ get updated until assigned a new workflow
         * so we can use it to check that all related actions are gone
         */
        $defID = $testPage->WorkflowDefinitionID;
        $this->assertEquals(0, DataObject::get('WorkflowAction')->filter('WorkflowDefID', $defID)->count());

        
        /*
         * 4). ii). Check that the content: Can be re-assigned a new Workflow Definition
         */
        $newDef = $this->createDefinition();
        $testPage->WorkflowDefinitionID = $newDef->ID;    // Normally done via CMS	
        $instance = new WorkflowInstance();
        $instance->beginWorkflow($newDef, $testPage);
        $instance->execute();
        
        // Check the content is assigned to the new Workflow Definition correctly
        $this->assertEquals($newDef->ID, $testPage->WorkflowDefinitionID);

        $this->assertEquals($newDef->Actions()->count(), DataObject::get('WorkflowAction')->filter('WorkflowDefID', $newDef->ID)->count());

        
        // 5). Check that the object under workflow, maintains its status
        $newDef2 = $this->createDefinition();
        
        // Login so SiteTree::canPublish() returns true
        $testPage->WorkflowDefinitionID = $newDef2->ID;    // Normally done via CMS	
        $this->logInWithPermission();
        $testPage->doPublish();
        
        // Check $testPage is published, pre-deletion (getStatusFlags() returns empty array)
        $this->assertTrue($testPage->getExistsOnLive());


        $instance = new WorkflowInstance();
        $instance->beginWorkflow($newDef2, $testPage);
        $instance->execute();
        
        // Now delete the related WorkflowDefinition and ensure status is the same (i.e. so it's not 'modified' for example)
        $newDef2->delete();
        
        // Check $testPage is _still_ published, post-deletion (getStatusFlags() returns empty array)
        $this->assertTrue($testPage->getExistsOnLive());

    }
}


1			<?php
2			/**
3			* Tests for the workflow engine.
4			*
5			* @author [email protected]
6			* @license BSD License (http://silverstripe.org/bsd-license/)
7			* @package advancedworkflow
8			* @subpackage tests
9			*/
10			class WorkflowEngineTest extends SapphireTest
			0 ignored issues – show Coding Style Compatibility introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12
13			public static $fixture_file = 'advancedworkflow/tests/workflowinstancetargets.yml';
14
15			public function testCreateWorkflowInstance()
16			{
17			$definition = new WorkflowDefinition();
18			$definition->Title = "Create Workflow Instance";
			0 ignored issues – show Documentation introduced 2015-11-21 06:31 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<WorkflowDefinition>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
19			$definition->write();
20
21			$stepOne = new WorkflowAction();
22			$stepOne->Title = "Step One";
			0 ignored issues – show Documentation introduced 2015-12-17 06:55 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<WorkflowAction>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			$stepOne->WorkflowDefID = $definition->ID;
			0 ignored issues – show Documentation introduced 2015-12-17 06:55 UTC by Report Bug Copy Issue Report The property `WorkflowDefID` does not exist on `object<WorkflowAction>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24			$stepOne->write();
25
26			$stepTwo = new WorkflowAction();
27			$stepTwo->Title = "Step Two";
			0 ignored issues – show Documentation introduced 2015-12-17 06:55 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<WorkflowAction>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28			$stepTwo->WorkflowDefID = $definition->ID;
			0 ignored issues – show Documentation introduced 2015-12-17 06:55 UTC by Report Bug Copy Issue Report The property `WorkflowDefID` does not exist on `object<WorkflowAction>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29			$stepTwo->write();
30
31			$transitionOne = new WorkflowTransition();
32			$transitionOne->Title = 'Step One T1';
			0 ignored issues – show Documentation introduced 2015-12-17 06:55 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<WorkflowTransition>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33			$transitionOne->ActionID = $stepOne->ID;

silverstripe-australia / advancedworkflow

Pull Request — master (#230)

WorkflowEngineTest::testPublishAction() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like