WorkflowField

Complexity

Total Complexity

18

Size/Duplication

Total Lines	123
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	action()	0	4	1
A	transition()	0	4	1
B	sort()	0	34	6
A	getTemplate()	0	4	1
A	FieldHolder()	0	9	1
A	Definition()	0	4	1
A	ActionLink()	0	7	1
A	TransitionLink()	0	7	1
B	CreateableActions()	0	22	4

<?php
/**
 * A form field that allows workflow actions and transitions to be edited,
 * while showing a visual overview of the flow.
 *
 * @package advancedworkflow
 */
class WorkflowField extends FormField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    public static $allowed_actions = array(
        'action',
        'transition',
        'sort'
    );

    protected $definition;

    public function __construct($name, $title, WorkflowDefinition $definition)
    {
        $this->definition = $definition;
        $this->addExtraClass('workflow-field');

        parent::__construct($name, $title);
    }

    public function action()
    {
        return new WorkflowFieldActionController($this, 'action');
    }

    public function transition()
    {
        return new WorkflowFieldTransitionController($this, 'transition');
    }

    public function sort($request)
    {
        if (!SecurityToken::inst()->checkRequest($request)) {
            $this->httpError(404);
        }

        $class = $request->postVar('class');
        $ids   = $request->postVar('id');

        if ($class == 'WorkflowAction') {
            $objects = $this->Definition()->Actions();

The method Actions() does not exist on WorkflowDefinition. Did you maybe mean updateAdminActions()?

        } elseif ($class == 'WorkflowTransition') {
            $parent = $request->postVar('parent');
            $action = $this->Definition()->Actions()->byID($parent);

The method Actions() does not exist on WorkflowDefinition. Did you maybe mean updateAdminActions()?

            if (!$action) {
                $this->httpError(400, _t('AdvancedWorkflowAdmin.INVALIDPARENTID', 'An invalid parent ID was specified.'));
            }

            $objects = $action->Transitions();
        } else {
            $this->httpError(400, _t('AdvancedWorkflowAdmin.INVALIDCLASSTOORDER', 'An invalid class to order was specified.'));
        }

        if (array_diff($ids, $objects->column('ID'))) {

The variable $objects does not seem to be defined for all execution paths leading up to this point.

            $this->httpError(400, _t('AdvancedWorkflowAdmin.INVALIDIDLIST', 'An invalid list of IDs was provided.'));
        }

        singleton('WorkflowService')->reorder($objects, $ids);

        return new SS_HTTPResponse(
            null, 200, _t('AdvancedWorkflowAdmin.SORTORDERSAVED', 'The sort order has been saved.')
        );
    }

    public function getTemplate()
    {
        return 'WorkflowField';
    }

    public function FieldHolder($properties = array())
    {
        Requirements::javascript(THIRDPARTY_DIR . '/jquery/jquery.js');
        Requirements::javascript(THIRDPARTY_DIR . '/jquery-entwine/dist/jquery.entwine-dist.js');
        Requirements::javascript(ADVANCED_WORKFLOW_DIR . '/javascript/WorkflowField.js');
        Requirements::css(ADVANCED_WORKFLOW_DIR . '/css/WorkflowField.css');

        return $this->Field($properties);
    }

    public function Definition()
    {
        return $this->definition;
    }

    public function ActionLink()
    {
        $parts = func_get_args();
        array_unshift($parts, 'action');

        return $this->Link(implode('/', $parts));
    }

    public function TransitionLink()
    {
        $parts = func_get_args();
        array_unshift($parts, 'transition');

        return $this->Link(implode('/', $parts));
    }

    public function CreateableActions()
    {
        $list    = new ArrayList();
        $classes = ClassInfo::subclassesFor('WorkflowAction');

        array_shift($classes);
        sort($classes);

        foreach ($classes as $class) {
            $reflect = new ReflectionClass($class);
            $can     = singleton($class)->canCreate() && !$reflect->isAbstract();

            if ($can) {
                $list->push(new ArrayData(array(
                'Title' => singleton($class)->singular_name(),
                'Class' => $class
            )));
            }
        }

        return $list;
    }
}