for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* Handles actions triggered from external sources, eg emails or web frontend
*
* @author [email protected]
* @license BSD License http://silverstripe.org/bsd-license/
*/
class AdvancedWorkflowActionController extends Controller {
You can fix this by adding a namespace to your class:
namespace YourVendor; class YourClass { }
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.
public function transition($request) {
$request
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.
if (!Member::currentUserID()) {
return Security::permissionFailure($this,
_t(
'AdvancedWorkflowActionController.ACTION_ERROR',
"You must be logged in"
)
);
}
$id = $this->request->requestVar('id');
$transition = $this->request->requestVar('transition');
$instance = DataObject::get_by_id('WorkflowInstance', (int) $id);
if ($instance && $instance->canEdit()) {
$transition = DataObject::get_by_id('WorkflowTransition', (int) $transition);
if ($transition) {
if ($this->request->requestVar('comments')) {
$action = $instance->CurrentAction();
$action->Comment = $this->request->requestVar('comments');
$action->write();
singleton('WorkflowService')->executeTransition($instance->getTarget(), $transition->ID);
$result = array(
'success' => true,
'link' => $instance->getTarget()->AbsoluteLink()
if (Director::is_ajax()) {
return Convert::raw2json($result);
} else {
return $this->redirect($instance->getTarget()->Link());
'success' => false,
$this->redirect($instance->getTarget()->Link());
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.