DistanceShippingMethodTest::testDistanceFare() - Code Metrics - silvershop/silvershop-shipping - Measure and Improve Code Quality continuously with Scrutinizer

DistanceShippingMethodTest::testDistanceFare() A
last analyzed 2017-12-15 03:16 UTC

↳ Parent: DistanceShippingMethodTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0

<?php

class DistanceShippingMethodTest extends SapphireTest{
    
    protected static $fixture_file = array(
        'silvershop-shipping/tests/fixtures/DistanceShippingMethod.yml',
        'silvershop-shipping/tests/fixtures/Warehouses.yml'
    );

    function testDistanceFare() {

        $method = $this->objFromFixture("DistanceShippingMethod", "ds");
        $this->assertEquals(0, $method->getDistanceFare(9));

        $this->assertEquals(0, $method->getDistanceFare(0.5));

        $this->assertEquals(234, $method->getDistanceFare(150));

        $this->assertEquals(678, $method->getDistanceFare(999999));


        //TODO: what if distane can't be calculated?
        //what if warehouse can't be found?
        //what if address is invalid?
    }

    function testCalculateRates() {

        $method = $this->objFromFixture("DistanceShippingMethod", "ds");
        $this->assertEquals(234,

            $method->calculateRate(
                new ShippingPackage(), 
                $this->objFromFixture("Address", "customeraddress1")
            )
        );
        $this->assertEquals(567,

            $method->calculateRate(
                new ShippingPackage(), 
                $this->objFromFixture("Address", "customeraddress2")
            )
        );
    }

}

1			<?php
2
3			class DistanceShippingMethodTest extends SapphireTest{
4
5			protected static $fixture_file = array(
6			'silvershop-shipping/tests/fixtures/DistanceShippingMethod.yml',
7			'silvershop-shipping/tests/fixtures/Warehouses.yml'
8			);
9
10			function testDistanceFare() {
			0 ignored issues – show Best Practice introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
11			$method = $this->objFromFixture("DistanceShippingMethod", "ds");
12			$this->assertEquals(0, $method->getDistanceFare(9));
			0 ignored issues – show Bug introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DistanceShippingMethodTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
13			$this->assertEquals(0, $method->getDistanceFare(0.5));
			0 ignored issues – show Bug introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DistanceShippingMethodTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
14			$this->assertEquals(234, $method->getDistanceFare(150));
			0 ignored issues – show Bug introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DistanceShippingMethodTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
15			$this->assertEquals(678, $method->getDistanceFare(999999));
			0 ignored issues – show Bug introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DistanceShippingMethodTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
16
17			//TODO: what if distane can't be calculated?
18			//what if warehouse can't be found?
19			//what if address is invalid?
20			}
21
22			function testCalculateRates() {
			0 ignored issues – show Best Practice introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
23			$method = $this->objFromFixture("DistanceShippingMethod", "ds");
24			$this->assertEquals(234,
			0 ignored issues – show Bug introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DistanceShippingMethodTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
25			$method->calculateRate(
26			new ShippingPackage(),
27			$this->objFromFixture("Address", "customeraddress1")
28			)
29			);
30			$this->assertEquals(567,
			0 ignored issues – show Bug introduced 2016-03-01 01:25 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not seem to exist on `object<DistanceShippingMethodTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			$method->calculateRate(
32			new ShippingPackage(),
33			$this->objFromFixture("Address", "customeraddress2")
34			)
35			);
36			}
37
38			}

silvershop / silvershop-shipping

DistanceShippingMethodTest::testDistanceFare() A last analyzed 2017-12-15 03:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DistanceShippingMethodTest::testDistanceFare() A
last analyzed 2017-12-15 03:16 UTC