ShippingMethodAdmin

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getEditForm()	0	16	2

<?php

/**
 * @package silvershop-shipping
 */
class ShippingMethodAdmin extends ModelAdmin
{
    private static $url_segment = "shipping";

Consider using a different property name as you override a private property of the parent class.

    private static $menu_title = "Shipping";

Consider using a different property name as you override a private property of the parent class.

    private static $menu_priority = 3;

Consider using a different property name as you override a private property of the parent class.

    private static $menu_icon = 'silvershop-shipping/images/shipping.png';

Consider using a different property name as you override a private property of the parent class.

    private static $managed_models = array(

Consider using a different property name as you override a private property of the parent class.

        'ShippingMethod',
        'Warehouse'
    );

    public static $model_importers = array();

    public function getEditForm($id = null, $fields = null)
    {
        $form = parent::getEditForm($id, $fields);
        if ($this->modelClass === "ShippingMethod") {
            $gridfield = $form->Fields()->fieldByName($this->sanitiseClassName($this->modelClass));
            $config = $gridfield->getConfig();
            $config->removeComponentsByType("GridFieldAddNewButton");
            $config->removeComponentsByType("GridFieldPrintButton");
            $config->removeComponentsByType("GridFieldExportButton");
            $config->addComponent($multiclass = new GridFieldAddNewMultiClass());
            $classes = ClassInfo::subclassesFor($this->modelClass);
            unset($classes[$this->modelClass]);
            $multiclass->setClasses($classes);

It seems like $classes defined by \ClassInfo::subclassesFor($this->modelClass) on line 33 can also be of type null; however, GridFieldAddNewMultiClass::setClasses() does only seem to accept array, maybe add an additional type check?

        }
        return $form;
    }
}